Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-19912

The flag "writeToWAL" of Region#checkAndRowMutate is useless

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 2.0.0-beta-2, 2.0.0
    • None
    • Reviewed
    • Remove useless 'writeToWAL' flag of Region#checkAndRowMutate & related class

    Attachments

      1. HBASE-19912.branch-2.v0.patch
        5 kB
        Mu Chun Wang

      Activity

        kewang Mu Chun Wang added a comment -

        Hi chia7712

        I have interest to resolve the issue.

        kewang Mu Chun Wang added a comment - Hi chia7712 I have interest to resolve the issue.
        chia7712 Chia-Ping Tsai added a comment -

        I have assigned this issue to you.

        chia7712 Chia-Ping Tsai added a comment - I have assigned this issue to you.
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
              Prechecks
        0 findbugs 0m 0s Findbugs executables are not available.
        +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              branch-2 Compile Tests
        +1 mvninstall 3m 40s branch-2 passed
        +1 compile 0m 47s branch-2 passed
        +1 checkstyle 1m 23s branch-2 passed
        +1 shadedjars 6m 4s branch has no errors when building our shaded downstream artifacts.
        +1 javadoc 0m 36s branch-2 passed
              Patch Compile Tests
        +1 mvninstall 3m 52s the patch passed
        +1 compile 0m 49s the patch passed
        +1 javac 0m 49s the patch passed
        -1 checkstyle 1m 20s hbase-server: The patch generated 1 new + 429 unchanged - 2 fixed = 430 total (was 431)
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 shadedjars 4m 30s patch has no errors when building our shaded downstream artifacts.
        +1 hadoopcheck 16m 48s Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0.
        +1 javadoc 0m 35s the patch passed
              Other Tests
        +1 unit 111m 53s hbase-server in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        147m 8s



        Subsystem Report/Notes
        Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db
        JIRA Issue HBASE-19912
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12908771/HBASE-19912.branch-2.v0.patch
        Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
        uname Linux 88dc3100d37d 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
        git revision branch-2 / 4c210eb212
        maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z)
        Default Java 1.8.0_151
        checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11325/artifact/patchprocess/diff-checkstyle-hbase-server.txt
        Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/11325/testReport/
        Max. process+thread count 5150 (vs. ulimit of 20000)
        modules C: hbase-server U: hbase-server
        Console output https://builds.apache.org/job/PreCommit-HBASE-Build/11325/console
        Powered by Apache Yetus 0.7.0 http://yetus.apache.org

        This message was automatically generated.

        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated.       Prechecks 0 findbugs 0m 0s Findbugs executables are not available. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       branch-2 Compile Tests +1 mvninstall 3m 40s branch-2 passed +1 compile 0m 47s branch-2 passed +1 checkstyle 1m 23s branch-2 passed +1 shadedjars 6m 4s branch has no errors when building our shaded downstream artifacts. +1 javadoc 0m 36s branch-2 passed       Patch Compile Tests +1 mvninstall 3m 52s the patch passed +1 compile 0m 49s the patch passed +1 javac 0m 49s the patch passed -1 checkstyle 1m 20s hbase-server: The patch generated 1 new + 429 unchanged - 2 fixed = 430 total (was 431) +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedjars 4m 30s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 16m 48s Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. +1 javadoc 0m 35s the patch passed       Other Tests +1 unit 111m 53s hbase-server in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 147m 8s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db JIRA Issue HBASE-19912 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12908771/HBASE-19912.branch-2.v0.patch Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile uname Linux 88dc3100d37d 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision branch-2 / 4c210eb212 maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) Default Java 1.8.0_151 checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11325/artifact/patchprocess/diff-checkstyle-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/11325/testReport/ Max. process+thread count 5150 (vs. ulimit of 20000) modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/11325/console Powered by Apache Yetus 0.7.0 http://yetus.apache.org This message was automatically generated.
        stack Michael Stack added a comment -

        Pushed to master and branch-2. Thanks for the patch kewang

        stack Michael Stack added a comment - Pushed to master and branch-2. Thanks for the patch kewang
        stack Michael Stack added a comment -

        Oh, useless removes argument from Region Interface which is limited private for Coprocessors.

        stack Michael Stack added a comment - Oh, useless removes argument from Region Interface which is limited private for Coprocessors.
        chia7712 Chia-Ping Tsai added a comment -

        Oh, useless removes argument from Region Interface which is limited private for Coprocessors.

        Yep, that is why this issue is only for both of branch-2 and master.

        chia7712 Chia-Ping Tsai added a comment - Oh, useless removes argument from Region Interface which is limited private for Coprocessors. Yep, that is why this issue is only for both of branch-2 and master.
        hudson Hudson added a comment -

        FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4510 (See https://builds.apache.org/job/HBase-Trunk_matrix/4510/)
        HBASE-19912 Remove useless 'writeToWAL' flag of Region#checkAndRowMutate (stack: rev 38c8144a065bc6d330330f611ec8beaa1477a884)

        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
        • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4510 (See https://builds.apache.org/job/HBase-Trunk_matrix/4510/ ) HBASE-19912 Remove useless 'writeToWAL' flag of Region#checkAndRowMutate (stack: rev 38c8144a065bc6d330330f611ec8beaa1477a884) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        kewang Mu Chun Wang added a comment -

        Thanks a lot, it is my first contribution at HBase. XDDD

        kewang Mu Chun Wang added a comment - Thanks a lot, it is my first contribution at HBase. XDDD
        stack Michael Stack added a comment -

        Thank you kewang

        stack Michael Stack added a comment - Thank you kewang

        People

          kewang Mu Chun Wang
          chia7712 Chia-Ping Tsai
          Votes:
          0 Vote for this issue
          Watchers:
          6 Start watching this issue

          Dates

            Created:
            Updated:
            Resolved: