[HBASE-19873] Add a CategoryBasedTimeout ClassRule for all UTs - ASF JIRA

XML

Word

Printable

JSON

Hadoop Flags:

Incompatible change, Reviewed
Release Note:

Hide
Along with @category -- small, medium, large -- all hbase tests must now carry a ClassRule as follows:

+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestInterfaceAudienceAnnotations.class);

where the class changes by test.

Currently the classrule enforces timeout for the whole test suite -- i.e. if a SmallTest Category then all the tests in the TestSuite must complete inside 60seconds, the timeout we set on SmallTest Category test suite -- but is meant to be a repository for general, runtime, hbase test facility.

Show
Along with @category -- small, medium, large -- all hbase tests must now carry a ClassRule as follows: + @ClassRule + public static final HBaseClassTestRule CLASS_RULE = + HBaseClassTestRule.forClass(TestInterfaceAudienceAnnotations.class); where the class changes by test. Currently the classrule enforces timeout for the whole test suite -- i.e. if a SmallTest Category then all the tests in the TestSuite must complete inside 60seconds, the timeout we set on SmallTest Category test suite -- but is meant to be a repository for general, runtime, hbase test facility.

So that our test can timeout as expected without making the surefire plugin kill other tests.

is related to

HBASE-19803 False positive for the HBASE-Find-Flaky-Tests job

links to

Review Board