[HBASE-19708] Avoid NPE when the RPC listener's accept channel is closed

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.98.24
• Fix Version/s: 1.3.2, 1.4.1, 1.2.7
• Hadoop Flags: Reviewed
• Assignee: Andrew Kyle Purtell
• Reporter: Andrew Kyle Purtell
• Created: 04/Jan/18 18:27
• Updated: 01/Feb/19 19:58
• Resolved: 05/Jan/18 19:27

Description

Rare NPE when the listener's accept channel is closed. We serialize access to related state to avoid a previously fixed related NPE and need to do the same for acceptChannel. Seen in a 0.98 deploy but I think applicable to later code lines. Let me check.

Exception in thread "MetadataRpcServer.handler=191,queue=0,port=60020" java.lang.NullPointerException
at org.apache.hadoop.hbase.ipc.RpcServer$Listener.getAddress(RpcServer.java:858)
at org.apache.hadoop.hbase.ipc.RpcServer.getListenerAddress(RpcServer.java:2338)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:140)
at org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:133)
at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:108)
at java.lang.Thread.run(Thread.java:745)