[HBASE-19684] BlockCacheKey toString Performance

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1
• Fix Version/s: 1.3.2, 1.4.1, 2.0.0-beta-1, 2.0.0, 1.2.7
• Hadoop Flags: Reviewed
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 02/Jan/18 00:01
• Updated: 01/Feb/19 20:20
• Resolved: 08/Jan/18 10:11

Description

  @Override
  public String toString() {
    return String.format("%s_%d", hfileName, offset);
  }

I found through bench-marking that the following code is 10x faster.

  @Override
  public String toString() {
    return hfileName.concat("_").concat(Long.toString(offset));
  }

Normally it wouldn't matter for a toString() method, but this is comes into play because MemcachedBlockCache uses it.

MemcachedBlockCache.java

  @Override
  public void cacheBlock(BlockCacheKey cacheKey, Cacheable buf) {
    if (buf instanceof HFileBlock) {
      client.add(cacheKey.toString(), MAX_SIZE, (HFileBlock) buf, tc);
    } else {
      if (LOG.isDebugEnabled()) {
        LOG.debug("MemcachedBlockCache can not cache Cacheable's of type "
            + buf.getClass().toString());
      }
    }
  }