[HBASE-19677] Miscellaneous HFileCleaner Improvements

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1
• Fix Version/s: 2.0.0-beta-2, 2.0.0
• Hadoop Flags: Reviewed
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 31/Dec/17 03:46
• Updated: 18/Jun/18 15:07
• Resolved: 31/Dec/17 17:48

Description

• Remove superfluous logging code guards
• Introduce SLF4J parameter logging
• Some simplifying:

-    for (HFileDeleteTask task : largeFileQueue) {
-      leftOverTasks.add(task);
-    }
-    for (HFileDeleteTask task : smallFileQueue) {
-      leftOverTasks.add(task);
-    }
+    leftOverTasks.addAll(largeFileQueue);
+    leftOverTasks.addAll(smallFileQueue);