[HBASE-19675] Miscellaneous HStore Class Improvements

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1
• Fix Version/s: 2.0.0-beta-2, 2.0.0
• Flags: Patch
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 31/Dec/17 03:12
• Updated: 18/Jun/18 15:07
• Resolved: 02/Jan/18 23:22

Description

• Remove logging code guards in favor of slf4j parameters
• Use CollectionsUtils.isEmpty() consistently
• Small check-style fixes
• Remove flow control logic from trace statement

            if (LOG.isTraceEnabled()) {
              LOG.trace("No compacted files to archive");
              return;
            }

• Replace two calls to the same getter to ensure that the value doesn't change between calls

        if (getCompactedFiles() != null) {
          for (HStoreFile file : getCompactedFiles()) {
            name2File.put(file.getFileInfo().getActiveFileName(), file);
          }
        }

• Make 'inputFiles' a Set for fast calls to contains method instead

      //some of the input files might already be deleted
      List<HStoreFile> inputStoreFiles = new ArrayList<>(compactionInputs.size());
      for (HStoreFile sf : this.getStorefiles()) {
        if (inputFiles.contains(sf.getPath().getName())) {
          inputStoreFiles.add(sf);
        }
      }

Issue Links

• relates to: HBASE-19682 Use Collections.emptyList() For Empty List Values