Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-19672

Correct comments for default values of major compaction in SortedCompactionPolicy#getNextMajorCompactTime()

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 2.0.0-beta-2, 2.0.0
    • None
    • None
    • Reviewed

    Description

      hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/SortedCompactionPolicy.java
      public long getNextMajorCompactTime(Collection<HStoreFile> filesToCompact) {
      {
          // default = 24hrs
         long period = comConf.getMajorCompactionPeriod();
          ...
          // default = 20% = +/- 4.8 hrs
          double jitterPct = comConf.getMajorCompactionJitter();
          ...
      }
      

      If I get it correctly, currently, default major compaction period is 7 days,and jitter is 0.5, so 3.5 days.
      We could either remove those comments, or add {@link} to link to the default value definitions.

      Attachments

        1. HBASE-19672.master.000.patch
          5 kB
          Xiang Li
        2. HBASE-19672.master.001.patch
          5 kB
          Xiang Li
        3. HBASE-19672.master.002.patch
          5 kB
          Xiang Li

        Activity

          People

            xiangli Xiang Li
            xiangli Xiang Li
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: