[HBASE-19653] Reduce the default hbase.client.start.log.errors.counter

• Type: Sub-task
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 2.0.0-beta-1, 2.0.0
• Component/s: Operability
• Hadoop Flags: Reviewed
• Assignee: Guanghao Zhang
• Reporter: Guanghao Zhang
• Created: 28/Dec/17 06:44
• Updated: 07/May/19 16:09
• Resolved: 28/Dec/17 15:58

Description

As we reduce the default retries number to 10 and now the default start log errors counter is 9. So it only log the error at the last retry. So we should reduce the default hbase.client.start.log.errors.counter, too.

  /**
   * Configure the number of failures after which the client will start logging. A few failures
   * is fine: region moved, then is not opened, then is overloaded. We try to have an acceptable
   * heuristic for the number of errors we don't log. 9 was chosen because we wait for 1s at
   * this stage.
   */
  public static final String START_LOG_ERRORS_AFTER_COUNT_KEY =
      "hbase.client.start.log.errors.counter";
  public static final int DEFAULT_START_LOG_ERRORS_AFTER_COUNT = 9;

public static final int [] RETRY_BACKOFF = {1, 2, 3, 5, 10, 20, 40, 100, 100, 100, 100, 200, 200};
public static final long DEFAULT_HBASE_CLIENT_PAUSE = 100;

The default pause is 100ms and 100ms * 10 = 1s. The old comment of DEFAULT_START_LOG_ERRORS_AFTER_COUNT seems not right...

Open this issue to reduce the default hbase.client.start.log.errors.counter to 5.