Details

    • Sub-task
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • None
    • 2.0.0-beta-1, 2.0.0
    • None
    • None

    Description

      Fix the remaining Checkstyle errors in the hbase-client-project module and enable Checkstyle to fail on violations.

      Attachments

        1. HBASE-19566.master.001.patch
          7 kB
          Jan Hentschel

        Issue Links

          Activity

            janh Jan Hentschel added a comment -

            Did it for the complete archetypes module instead to not include Checkstyle in the POM of the individual archetypes.

            janh Jan Hentschel added a comment - Did it for the complete archetypes module instead to not include Checkstyle in the POM of the individual archetypes.
            hadoopqa Hadoop QA added a comment -
            +1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 9s Docker mode activated.
                  Prechecks
            0 findbugs 0m 0s Findbugs executables are not available.
            +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
                  master Compile Tests
            0 mvndep 0m 8s Maven dependency ordering for branch
            +1 mvninstall 5m 20s master passed
            +1 compile 1m 18s master passed
            +1 checkstyle 0m 35s master passed
            +1 shadedjars 5m 57s branch has no errors when building our shaded downstream artifacts.
            +1 javadoc 0m 37s master passed
                  Patch Compile Tests
            0 mvndep 0m 9s Maven dependency ordering for patch
            +1 mvninstall 5m 13s the patch passed
            +1 compile 1m 28s the patch passed
            +1 javac 1m 28s the patch passed
            +1 checkstyle 0m 12s hbase-archetypes: The patch generated 0 new + 0 unchanged - 18 fixed = 0 total (was 18)
            +1 checkstyle 0m 11s hbase-archetypes/hbase-client-project: The patch generated 0 new + 0 unchanged - 9 fixed = 0 total (was 9)
            +1 checkstyle 0m 12s hbase-archetypes/hbase-shaded-client-project: The patch generated 0 new + 0 unchanged - 9 fixed = 0 total (was 9)
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 xml 0m 2s The patch has no ill-formed XML file.
            +1 shadedjars 5m 3s patch has no errors when building our shaded downstream artifacts.
            +1 hadoopcheck 22m 28s Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0.
            +1 javadoc 0m 46s the patch passed
                  Other Tests
            +1 unit 1m 42s hbase-archetypes in the patch passed.
            +1 unit 0m 48s hbase-client-project in the patch passed.
            +1 unit 0m 48s hbase-shaded-client-project in the patch passed.
            +1 asflicense 0m 26s The patch does not generate ASF License warnings.
            48m 18s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01
            JIRA Issue HBASE-19566
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12903077/HBASE-19566.master.001.patch
            Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml
            uname Linux f328a33e1b93 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux
            Build tool maven
            Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
            git revision master / 55fefd4b5a
            maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z)
            Default Java 1.8.0_151
            Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/10585/testReport/
            modules C: hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: hbase-archetypes
            Console output https://builds.apache.org/job/PreCommit-HBASE-Build/10585/console
            Powered by Apache Yetus 0.6.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated.       Prechecks 0 findbugs 0m 0s Findbugs executables are not available. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       master Compile Tests 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 5m 20s master passed +1 compile 1m 18s master passed +1 checkstyle 0m 35s master passed +1 shadedjars 5m 57s branch has no errors when building our shaded downstream artifacts. +1 javadoc 0m 37s master passed       Patch Compile Tests 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 5m 13s the patch passed +1 compile 1m 28s the patch passed +1 javac 1m 28s the patch passed +1 checkstyle 0m 12s hbase-archetypes: The patch generated 0 new + 0 unchanged - 18 fixed = 0 total (was 18) +1 checkstyle 0m 11s hbase-archetypes/hbase-client-project: The patch generated 0 new + 0 unchanged - 9 fixed = 0 total (was 9) +1 checkstyle 0m 12s hbase-archetypes/hbase-shaded-client-project: The patch generated 0 new + 0 unchanged - 9 fixed = 0 total (was 9) +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 shadedjars 5m 3s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 22m 28s Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. +1 javadoc 0m 46s the patch passed       Other Tests +1 unit 1m 42s hbase-archetypes in the patch passed. +1 unit 0m 48s hbase-client-project in the patch passed. +1 unit 0m 48s hbase-shaded-client-project in the patch passed. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 48m 18s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 JIRA Issue HBASE-19566 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12903077/HBASE-19566.master.001.patch Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml uname Linux f328a33e1b93 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 55fefd4b5a maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) Default Java 1.8.0_151 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/10585/testReport/ modules C: hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: hbase-archetypes Console output https://builds.apache.org/job/PreCommit-HBASE-Build/10585/console Powered by Apache Yetus 0.6.0 http://yetus.apache.org This message was automatically generated.

            +1

            appy Apekshit Sharma added a comment - +1
            hudson Hudson added a comment -

            FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4263 (See https://builds.apache.org/job/HBase-Trunk_matrix/4263/)
            HBASE-19566 Fixed Checkstyle errors in hbase-archetypes and enabled (jan.hentschel: rev d95cf54ba644b18e35a4d88334c674df83e01c7f)

            • (edit) hbase-archetypes/hbase-client-project/src/test/java/org/apache/hbase/archetypes/exemplars/client/TestHelloHBase.java
            • (edit) hbase-archetypes/hbase-shaded-client-project/src/test/java/org/apache/hbase/archetypes/exemplars/shaded_client/TestHelloHBase.java
            • (edit) hbase-archetypes/pom.xml
            hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4263 (See https://builds.apache.org/job/HBase-Trunk_matrix/4263/ ) HBASE-19566 Fixed Checkstyle errors in hbase-archetypes and enabled (jan.hentschel: rev d95cf54ba644b18e35a4d88334c674df83e01c7f) (edit) hbase-archetypes/hbase-client-project/src/test/java/org/apache/hbase/archetypes/exemplars/client/TestHelloHBase.java (edit) hbase-archetypes/hbase-shaded-client-project/src/test/java/org/apache/hbase/archetypes/exemplars/shaded_client/TestHelloHBase.java (edit) hbase-archetypes/pom.xml

            Why do we need this? It's not needed for modules like hbase-server.

            81	      <plugin>
            82	        <groupId>org.apache.maven.plugins</groupId>
            83	        <artifactId>maven-checkstyle-plugin</artifactId>
            84	        <executions>
            85	          <execution>
            86	            <id>checkstyle</id>
            87	            <phase>validate</phase>
            88	            <goals>
            89	              <goal>check</goal>
            90	            </goals>
            91	            <configuration>
            92	              <failOnViolation>true</failOnViolation>
            93	            </configuration>
            94	          </execution>
            95	        </executions>
            96	      </plugin>
            
            appy Apekshit Sharma added a comment - Why do we need this? It's not needed for modules like hbase-server. 81 <plugin> 82 <groupId>org.apache.maven.plugins</groupId> 83 <artifactId>maven-checkstyle-plugin</artifactId> 84 <executions> 85 <execution> 86 <id>checkstyle</id> 87 <phase>validate</phase> 88 <goals> 89 <goal>check</goal> 90 </goals> 91 <configuration> 92 <failOnViolation>true</failOnViolation> 93 </configuration> 94 </execution> 95 </executions> 96 </plugin>

            Oh nvm, figured it, to avoid new ones from getting added.

            appy Apekshit Sharma added a comment - Oh nvm, figured it, to avoid new ones from getting added.

            People

              janh Jan Hentschel
              janh Jan Hentschel
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: