[HBASE-19561] maxCacheSize in CacheEvictionStats can't be accumulated repeatedly When dealing with each region

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0-beta-1, 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Guangxu Cheng
• Reporter: Guangxu Cheng
• Created: 20/Dec/17 03:55
• Updated: 01/Aug/18 06:23
• Resolved: 20/Dec/17 15:06

Description

HRegionServer.java

  public CacheEvictionStats clearRegionBlockCache(Region region) {
    BlockCache blockCache = this.getCacheConfig().getBlockCache();
    long evictedBlocks = 0;

    for(Store store : region.getStores()) {
      for(StoreFile hFile : store.getStorefiles()) {
        evictedBlocks += blockCache.evictBlocksByHfileName(hFile.getPath().getName());
      }
    }

    return CacheEvictionStats.builder()
        .withEvictedBlocks(evictedBlocks)
        .withMaxCacheSize(blockCache.getMaxSize())
        .build();
  }

BlockCache is the regionserver level object.If we accumulate this value for each region, we will get a wrong result.
The value of maxCacheSize should be set to BlockCache.getMaxSize() after processing all the regions on this regionserver.