[HBASE-19532] AssignProcedure#COMPARATOR may produce incorrect sort order

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.0.0-beta-1, 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 16/Dec/17 15:43
• Updated: 01/Aug/18 06:21
• Resolved: 19/Dec/17 02:33

Description

The intention of AssignProcedure#COMPARATOR is to put the regions in the following order:

meta regions
system table regions
user table regions

However, the current implementation may produce incorrect sort order.

With the modified test, the test fails with:

testComparatorWithMetas(org.apache.hadoop.hbase.master.snapshot.TestAssignProcedure)  Time elapsed: 0.038 sec  <<< FAILURE!
junit.framework.AssertionFailedError
  at org.apache.hadoop.hbase.master.snapshot.TestAssignProcedure.testComparatorWithMetas(TestAssignProcedure.java:88)