Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-19478

Utilize multi-get to speed up WAL file checking in BackupLogCleaner

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently BackupLogCleaner#getDeletableFiles() issues one Get per WAL file:

            for (FileStatus file : files) {
              String wal = file.getPath().toString();
              boolean logInSystemTable = table.isWALFileDeletable(wal);
      

      This is rather inefficient considering the number of WAL files in production can get quite large.

      We should use multi-get to reduce the number of calls to backup table (which normally resides on another server).

        Attachments

        1. HBASE-19478.patch
          6 kB
          Toshihiro Suzuki
        2. HBASE-19478.v2.patch
          6 kB
          Toshihiro Suzuki
        3. HBASE-19478.v3.patch
          6 kB
          Toshihiro Suzuki

          Activity

            People

            • Assignee:
              brfrn169 Toshihiro Suzuki
              Reporter:
              yuzhihong@gmail.com Ted Yu
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: