Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-19325

Pass a list of server name to postClearDeadServers

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-beta-2
    • Fix Version/s: 1.4.0, 2.0.0-beta-1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Over on the tail of HBASE-18131. Chia-Ping Tsai said

      (Revisiting the AccessController remind me of this issue)
      Could we remove the duplicate code on the server side? Why not pass a list of server name to postClearDeadServers and postListDeadServers?

      The duplicate code has been removed in HBASE-19131.Now Pass a list of server name to postClearDeadServers

      1. HBASE-19325.branch-2.001.patch
        3 kB
        Guangxu Cheng
      2. HBASE-19325.branch-1.001.patch
        8 kB
        Guangxu Cheng
      3. HBASE-19325.branch-1.001.patch
        8 kB
        Guangxu Cheng

        Activity

        Hide
        andrewcheng Guangxu Cheng added a comment -

        Upload the first patch. Thanks

        Show
        andrewcheng Guangxu Cheng added a comment - Upload the first patch. Thanks
        Hide
        chia7712 Chia-Ping Tsai added a comment -

        What about passing the servers coming from request to preClearDeadServers?

        Show
        chia7712 Chia-Ping Tsai added a comment - What about passing the servers coming from request to preClearDeadServers?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
              Prechecks
        0 findbugs 0m 0s Findbugs executables are not available.
        +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              branch-2 Compile Tests
        +1 mvninstall 3m 55s branch-2 passed
        +1 compile 0m 45s branch-2 passed
        +1 checkstyle 1m 6s branch-2 passed
        +1 shadedjars 5m 17s branch has no errors when building our shaded downstream artifacts.
        +1 javadoc 0m 30s branch-2 passed
              Patch Compile Tests
        +1 mvninstall 3m 57s the patch passed
        +1 compile 0m 43s the patch passed
        +1 javac 0m 43s the patch passed
        +1 checkstyle 1m 4s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 shadedjars 4m 19s patch has no errors when building our shaded downstream artifacts.
        +1 hadoopcheck 45m 11s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4.
        +1 javadoc 0m 33s the patch passed
              Other Tests
        +1 unit 92m 36s hbase-server in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        155m 14s



        Subsystem Report/Notes
        Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db
        JIRA Issue HBASE-19325
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12898823/HBASE-19325.branch-2.001.patch
        Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
        uname Linux e94b3d456fcd 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
        git revision branch-2 / 8c2a962d1c
        maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z)
        Default Java 1.8.0_151
        Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9965/testReport/
        modules C: hbase-server U: hbase-server
        Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9965/console
        Powered by Apache Yetus 0.6.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated.       Prechecks 0 findbugs 0m 0s Findbugs executables are not available. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       branch-2 Compile Tests +1 mvninstall 3m 55s branch-2 passed +1 compile 0m 45s branch-2 passed +1 checkstyle 1m 6s branch-2 passed +1 shadedjars 5m 17s branch has no errors when building our shaded downstream artifacts. +1 javadoc 0m 30s branch-2 passed       Patch Compile Tests +1 mvninstall 3m 57s the patch passed +1 compile 0m 43s the patch passed +1 javac 0m 43s the patch passed +1 checkstyle 1m 4s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedjars 4m 19s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 45m 11s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. +1 javadoc 0m 33s the patch passed       Other Tests +1 unit 92m 36s hbase-server in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 155m 14s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db JIRA Issue HBASE-19325 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12898823/HBASE-19325.branch-2.001.patch Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile uname Linux e94b3d456fcd 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision branch-2 / 8c2a962d1c maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) Default Java 1.8.0_151 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9965/testReport/ modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9965/console Powered by Apache Yetus 0.6.0 http://yetus.apache.org This message was automatically generated.
        Hide
        yuzhihong@gmail.com Ted Yu added a comment -

        MasterObserver in branch-1 has:

          void postClearDeadServers(ObserverContext<MasterCoprocessorEnvironment> ctx) throws IOException;
        

        Don't we need to preserve / provide the same method signature ?

        Show
        yuzhihong@gmail.com Ted Yu added a comment - MasterObserver in branch-1 has: void postClearDeadServers(ObserverContext<MasterCoprocessorEnvironment> ctx) throws IOException; Don't we need to preserve / provide the same method signature ?
        Hide
        andrewcheng Guangxu Cheng added a comment -

        What about passing the servers coming from request to preClearDeadServers?

        preClearDeadServers is called only in AccessController, and does not use the variable deadservers. So, I do not think it is necessary to pass dead servers to preClearDeadServers.WDYT?Thanks

        Show
        andrewcheng Guangxu Cheng added a comment - What about passing the servers coming from request to preClearDeadServers? preClearDeadServers is called only in AccessController, and does not use the variable deadservers. So, I do not think it is necessary to pass dead servers to preClearDeadServers.WDYT?Thanks
        Hide
        andrewcheng Guangxu Cheng added a comment -

        Don't we need to preserve / provide the same method signature ?

        I will submit the branch-1 patch later.Thanks

        Show
        andrewcheng Guangxu Cheng added a comment - Don't we need to preserve / provide the same method signature ? I will submit the branch-1 patch later.Thanks
        Hide
        andrewcheng Guangxu Cheng added a comment -

        upload branch-1 patch

        Show
        andrewcheng Guangxu Cheng added a comment - upload branch-1 patch
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
              Prechecks
        +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              branch-1 Compile Tests
        0 mvndep 0m 31s Maven dependency ordering for branch
        +1 mvninstall 3m 7s branch-1 passed
        +1 compile 1m 29s branch-1 passed with JDK v1.8.0_141
        +1 compile 1m 20s branch-1 passed with JDK v1.7.0_151
        +1 checkstyle 2m 3s branch-1 passed
        +1 shadedjars 5m 41s branch has no errors when building our shaded downstream artifacts.
        -1 findbugs 3m 12s hbase-server in branch-1 has 1 extant Findbugs warnings.
        +1 javadoc 1m 24s branch-1 passed with JDK v1.8.0_141
        +1 javadoc 1m 14s branch-1 passed with JDK v1.7.0_151
              Patch Compile Tests
        0 mvndep 0m 20s Maven dependency ordering for patch
        +1 mvninstall 2m 43s the patch passed
        +1 compile 1m 27s the patch passed with JDK v1.8.0_141
        +1 javac 1m 27s the patch passed
        +1 compile 1m 22s the patch passed with JDK v1.7.0_151
        +1 javac 1m 22s the patch passed
        +1 checkstyle 2m 3s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 shadedjars 3m 37s patch has no errors when building our shaded downstream artifacts.
        +1 hadoopcheck 41m 0s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4.
        +1 findbugs 4m 17s the patch passed
        +1 javadoc 1m 3s the patch passed with JDK v1.8.0_141
        +1 javadoc 1m 12s the patch passed with JDK v1.7.0_151
              Other Tests
        -1 unit 26m 5s hbase-server in the patch failed.
        +1 unit 1m 2s hbase-rsgroup in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        103m 0s



        Reason Tests
        Failed junit tests hadoop.hbase.quotas.TestRateLimiter



        Subsystem Report/Notes
        Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:4bf71c3
        JIRA Issue HBASE-19325
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12898987/HBASE-19325.branch-1.001.patch
        Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
        uname Linux 984d2e7f9f2a 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
        git revision branch-1 / 20d8111
        maven version: Apache Maven 3.0.5
        Default Java 1.7.0_151
        Multi-JDK versions /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_141 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_151
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/9985/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
        unit https://builds.apache.org/job/PreCommit-HBASE-Build/9985/artifact/patchprocess/patch-unit-hbase-server.txt
        Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9985/testReport/
        modules C: hbase-server hbase-rsgroup U: .
        Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9985/console
        Powered by Apache Yetus 0.6.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       branch-1 Compile Tests 0 mvndep 0m 31s Maven dependency ordering for branch +1 mvninstall 3m 7s branch-1 passed +1 compile 1m 29s branch-1 passed with JDK v1.8.0_141 +1 compile 1m 20s branch-1 passed with JDK v1.7.0_151 +1 checkstyle 2m 3s branch-1 passed +1 shadedjars 5m 41s branch has no errors when building our shaded downstream artifacts. -1 findbugs 3m 12s hbase-server in branch-1 has 1 extant Findbugs warnings. +1 javadoc 1m 24s branch-1 passed with JDK v1.8.0_141 +1 javadoc 1m 14s branch-1 passed with JDK v1.7.0_151       Patch Compile Tests 0 mvndep 0m 20s Maven dependency ordering for patch +1 mvninstall 2m 43s the patch passed +1 compile 1m 27s the patch passed with JDK v1.8.0_141 +1 javac 1m 27s the patch passed +1 compile 1m 22s the patch passed with JDK v1.7.0_151 +1 javac 1m 22s the patch passed +1 checkstyle 2m 3s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedjars 3m 37s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 41m 0s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4. +1 findbugs 4m 17s the patch passed +1 javadoc 1m 3s the patch passed with JDK v1.8.0_141 +1 javadoc 1m 12s the patch passed with JDK v1.7.0_151       Other Tests -1 unit 26m 5s hbase-server in the patch failed. +1 unit 1m 2s hbase-rsgroup in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 103m 0s Reason Tests Failed junit tests hadoop.hbase.quotas.TestRateLimiter Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:4bf71c3 JIRA Issue HBASE-19325 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12898987/HBASE-19325.branch-1.001.patch Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile uname Linux 984d2e7f9f2a 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision branch-1 / 20d8111 maven version: Apache Maven 3.0.5 Default Java 1.7.0_151 Multi-JDK versions /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_141 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_151 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/9985/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html unit https://builds.apache.org/job/PreCommit-HBASE-Build/9985/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9985/testReport/ modules C: hbase-server hbase-rsgroup U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9985/console Powered by Apache Yetus 0.6.0 http://yetus.apache.org This message was automatically generated.
        Hide
        andrewcheng Guangxu Cheng added a comment -

        The failed ut not related.Retry again

        Show
        andrewcheng Guangxu Cheng added a comment - The failed ut not related.Retry again
        Hide
        chia7712 Chia-Ping Tsai added a comment -

        Andrew Purtell Do you want this in branch-1.4?

        Show
        chia7712 Chia-Ping Tsai added a comment - Andrew Purtell Do you want this in branch-1.4?
        Hide
        andrewcheng Guangxu Cheng added a comment -

        ping Chia-Ping Tsai Ted Yu Andrew Purtell, Any other concerns? Thanks.

        Show
        andrewcheng Guangxu Cheng added a comment - ping Chia-Ping Tsai Ted Yu Andrew Purtell , Any other concerns? Thanks.
        Hide
        apurtell Andrew Purtell added a comment -

        Sure, we can get it in now before the 1.4.0 release.

        Show
        apurtell Andrew Purtell added a comment - Sure, we can get it in now before the 1.4.0 release.
        Hide
        chia7712 Chia-Ping Tsai added a comment -

        LGTM. Let me run the QA locally. Will attach the result asap.

        Show
        chia7712 Chia-Ping Tsai added a comment - LGTM. Let me run the QA locally. Will attach the result asap.
        Hide
        yuzhihong@gmail.com Ted Yu added a comment -

        lgtm

        Show
        yuzhihong@gmail.com Ted Yu added a comment - lgtm
        Hide
        chia7712 Chia-Ping Tsai added a comment -
        13:52:18 -1 overall
        13:52:18 
        13:52:18  _____     _ _                _ 
        13:52:18 |  ___|_ _(_) |_   _ _ __ ___| |
        13:52:18 | |_ / _` | | | | | | '__/ _ \ |
        13:52:18 |  _| (_| | | | |_| | | |  __/_|
        13:52:18 |_|  \__,_|_|_|\__,_|_|  \___(_)
        13:52:18                                 
        13:52:18 
        13:52:18 
        13:52:18 | Vote |       Subsystem |  Runtime   | Comment
        13:52:18 ============================================================================
        13:52:18 |      |                 |            | Prechecks 
        13:52:18 |  +1  |      hbaseanti  |   0m  0s   | Patch does not have any anti-patterns. 
        13:52:18 |  +1  |        @author  |   0m  0s   | The patch does not contain any @author 
        13:52:18 |      |                 |            | tags.
        13:52:18 |  +1  |     test4tests  |   0m  0s   | The patch appears to include 1 new or 
        13:52:18 |      |                 |            | modified test files.
        13:52:18 |      |                 |            | branch-1 Compile Tests 
        13:52:18 |   0  |         mvndep  |   6m  1s   | Maven dependency ordering for branch 
        13:52:18 |  +1  |     mvninstall  |   1m  2s   | branch-1 passed 
        13:52:18 |  +1  |        compile  |   0m 25s   | branch-1 passed 
        13:52:18 |  +1  |     checkstyle  |   0m 50s   | branch-1 passed 
        13:52:18 |   0  |       findbugs  |   0m 57s   | hbase-server in branch-1 has 1 extant 
        13:52:18 |      |                 |            | Findbugs warnings.
        13:52:18 |  +1  |        javadoc  |   0m 32s   | branch-1 passed 
        13:52:18 |      |                 |            | Patch Compile Tests 
        13:52:18 |   0  |         mvndep  |   0m  6s   | Maven dependency ordering for patch 
        13:52:18 |  +1  |     mvninstall  |   0m 29s   | the patch passed 
        13:52:18 |  +1  |        compile  |   0m 25s   | the patch passed 
        13:52:18 |  +1  |          javac  |   0m 25s   | the patch passed 
        13:52:19 |  +1  |     checkstyle  |   0m 37s   | the patch passed 
        13:52:19 |  +1  |     whitespace  |   0m  0s   | The patch has no whitespace issues. 
        13:52:19 |  +1  |    hadoopcheck  |   8m 38s   | The patch does not cause any errors 
        13:52:19 |      |                 |            | with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1
        13:52:19 |      |                 |            | 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
        13:52:19 |  +1  |       findbugs  |   1m 17s   | the patch passed 
        13:52:19 |  +1  |        javadoc  |   0m 18s   | the patch passed 
        13:52:19 |      |                 |            | Other Tests 
        13:52:19 |  -1  |           unit  |  80m 29s   | hbase-server in the patch failed. 
        13:52:19 |  +1  |           unit  |   3m 58s   | hbase-rsgroup in the patch passed. 
        13:52:19 |  +1  |     asflicense  |   0m 19s   | The patch does not generate ASF License 
        13:52:19 |      |                 |            | warnings.
        13:52:19 |      |                 | 107m 21s   | 
        13:52:19 
        13:52:19 
        13:52:19               Reason | Tests
        13:52:19  Failed junit tests  |  hadoop.hbase.client.TestHTableMultiplexerFlushCache 
        13:52:19                      |  hadoop.hbase.replication.TestReplicationSmallTests 
        13:52:19                      |  hadoop.hbase.client.TestMetaWithReplicas 
        13:52:19                      |  hadoop.hbase.regionserver.TestEndToEndSplitTransaction 
        13:52:19                      |  hadoop.hbase.mapreduce.TestMultithreadedTableMapper 
        13:52:19                      |  hadoop.hbase.regionserver.TestCompactionInDeadRegionServer 
        13:52:19 
        13:52:19 
        13:52:19 || Subsystem || Report/Notes ||
        13:52:19 ============================================================================
        13:52:19 | Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  hbaseanti  checkstyle  compile  |
        13:52:19 | uname | Linux 2060d48154ce 4.10.0-38-generic #42-Ubuntu SMP Tue Oct 10 13:24:27 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
        13:52:19 | Build tool | maven |
        13:52:19 | Personality | /script/yetus/precommit/personality/hbase.sh |
        13:52:19 | git revision | branch-1 / 20d811121f |
        13:52:19 | maven | version: Apache Maven 3.3.9 |
        13:52:19 | Default Java | 1.8.0_131 |
        13:52:19 | findbugs | v3.1.0-RC1 |
        13:52:19 | unit | /patchprocess/patch-unit-hbase-server.txt |
        13:52:19 | modules | C: hbase-server hbase-rsgroup U: . |
        13:52:19 | Powered by | Apache Yetus 0.6.0   http://yetus.apache.org |
        

        TestCompactionInDeadRegionServer is traced by HBASE-19056.
        TestMultithreadedTableMapper -> HBASE-19300
        Others fail without the patch.

        Will commit it tomorrow if no objections.

        Show
        chia7712 Chia-Ping Tsai added a comment - 13:52:18 -1 overall 13:52:18 13:52:18 _____ _ _ _ 13:52:18 | ___|_ _(_) |_ _ _ __ ___| | 13:52:18 | |_ / _` | | | | | | '__/ _ \ | 13:52:18 | _| (_| | | | |_| | | | __/_| 13:52:18 |_| \__,_|_|_|\__,_|_| \___(_) 13:52:18 13:52:18 13:52:18 13:52:18 | Vote | Subsystem | Runtime | Comment 13:52:18 ============================================================================ 13:52:18 | | | | Prechecks 13:52:18 | +1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. 13:52:18 | +1 | @author | 0m 0s | The patch does not contain any @author 13:52:18 | | | | tags. 13:52:18 | +1 | test4tests | 0m 0s | The patch appears to include 1 new or 13:52:18 | | | | modified test files. 13:52:18 | | | | branch-1 Compile Tests 13:52:18 | 0 | mvndep | 6m 1s | Maven dependency ordering for branch 13:52:18 | +1 | mvninstall | 1m 2s | branch-1 passed 13:52:18 | +1 | compile | 0m 25s | branch-1 passed 13:52:18 | +1 | checkstyle | 0m 50s | branch-1 passed 13:52:18 | 0 | findbugs | 0m 57s | hbase-server in branch-1 has 1 extant 13:52:18 | | | | Findbugs warnings. 13:52:18 | +1 | javadoc | 0m 32s | branch-1 passed 13:52:18 | | | | Patch Compile Tests 13:52:18 | 0 | mvndep | 0m 6s | Maven dependency ordering for patch 13:52:18 | +1 | mvninstall | 0m 29s | the patch passed 13:52:18 | +1 | compile | 0m 25s | the patch passed 13:52:18 | +1 | javac | 0m 25s | the patch passed 13:52:19 | +1 | checkstyle | 0m 37s | the patch passed 13:52:19 | +1 | whitespace | 0m 0s | The patch has no whitespace issues. 13:52:19 | +1 | hadoopcheck | 8m 38s | The patch does not cause any errors 13:52:19 | | | | with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 13:52:19 | | | | 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. 13:52:19 | +1 | findbugs | 1m 17s | the patch passed 13:52:19 | +1 | javadoc | 0m 18s | the patch passed 13:52:19 | | | | Other Tests 13:52:19 | -1 | unit | 80m 29s | hbase-server in the patch failed. 13:52:19 | +1 | unit | 3m 58s | hbase-rsgroup in the patch passed. 13:52:19 | +1 | asflicense | 0m 19s | The patch does not generate ASF License 13:52:19 | | | | warnings. 13:52:19 | | | 107m 21s | 13:52:19 13:52:19 13:52:19 Reason | Tests 13:52:19 Failed junit tests | hadoop.hbase.client.TestHTableMultiplexerFlushCache 13:52:19 | hadoop.hbase.replication.TestReplicationSmallTests 13:52:19 | hadoop.hbase.client.TestMetaWithReplicas 13:52:19 | hadoop.hbase.regionserver.TestEndToEndSplitTransaction 13:52:19 | hadoop.hbase.mapreduce.TestMultithreadedTableMapper 13:52:19 | hadoop.hbase.regionserver.TestCompactionInDeadRegionServer 13:52:19 13:52:19 13:52:19 || Subsystem || Report/Notes || 13:52:19 ============================================================================ 13:52:19 | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | 13:52:19 | uname | Linux 2060d48154ce 4.10.0-38- generic #42-Ubuntu SMP Tue Oct 10 13:24:27 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | 13:52:19 | Build tool | maven | 13:52:19 | Personality | /script/yetus/precommit/personality/hbase.sh | 13:52:19 | git revision | branch-1 / 20d811121f | 13:52:19 | maven | version: Apache Maven 3.3.9 | 13:52:19 | Default Java | 1.8.0_131 | 13:52:19 | findbugs | v3.1.0-RC1 | 13:52:19 | unit | /patchprocess/patch-unit-hbase-server.txt | 13:52:19 | modules | C: hbase-server hbase-rsgroup U: . | 13:52:19 | Powered by | Apache Yetus 0.6.0 http: //yetus.apache.org | TestCompactionInDeadRegionServer is traced by HBASE-19056 . TestMultithreadedTableMapper -> HBASE-19300 Others fail without the patch. Will commit it tomorrow if no objections.
        Hide
        chia7712 Chia-Ping Tsai added a comment -

        Push to branch-1.4, branch-1, branch-2, and master.
        Thanks for the contribution. Guangxu Cheng

        Show
        chia7712 Chia-Ping Tsai added a comment - Push to branch-1.4, branch-1, branch-2, and master. Thanks for the contribution. Guangxu Cheng
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Jenkins build HBase-1.5 #167 (See https://builds.apache.org/job/HBase-1.5/167/)
        HBASE-19325 Pass a list of server name to postClearDeadServers (chia7712: rev de16690b7a3b25ecff5c1ebfe5002698be4ff018)

        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterAndRegionObserver.java
        • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
        • (edit) hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterObserver.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-1.5 #167 (See https://builds.apache.org/job/HBase-1.5/167/ ) HBASE-19325 Pass a list of server name to postClearDeadServers (chia7712: rev de16690b7a3b25ecff5c1ebfe5002698be4ff018) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterAndRegionObserver.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java (edit) hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterObserver.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Jenkins build HBase-1.4 #1025 (See https://builds.apache.org/job/HBase-1.4/1025/)
        HBASE-19325 Pass a list of server name to postClearDeadServers (chia7712: rev b4c2066e73c055426c207ea585743fac0e1ebbf6)

        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
        • (edit) hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterObserver.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
        • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterAndRegionObserver.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-1.4 #1025 (See https://builds.apache.org/job/HBase-1.4/1025/ ) HBASE-19325 Pass a list of server name to postClearDeadServers (chia7712: rev b4c2066e73c055426c207ea585743fac0e1ebbf6) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java (edit) hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterObserver.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterAndRegionObserver.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Jenkins build HBase-2.0 #926 (See https://builds.apache.org/job/HBase-2.0/926/)
        HBASE-19325 Pass a list of server name to postClearDeadServers (chia7712: rev 44bd94721c5601046871eb864239a51486a21297)

        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-2.0 #926 (See https://builds.apache.org/job/HBase-2.0/926/ ) HBASE-19325 Pass a list of server name to postClearDeadServers (chia7712: rev 44bd94721c5601046871eb864239a51486a21297) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4128 (See https://builds.apache.org/job/HBase-Trunk_matrix/4128/)
        HBASE-19325 Pass a list of server name to postClearDeadServers (chia7712: rev 5a0881a98b3575d900d483222e2fdfab15159656)

        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4128 (See https://builds.apache.org/job/HBase-Trunk_matrix/4128/ ) HBASE-19325 Pass a list of server name to postClearDeadServers (chia7712: rev 5a0881a98b3575d900d483222e2fdfab15159656) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
        Hide
        andrewcheng Guangxu Cheng added a comment -

        Thanks all for reviewing.

        Show
        andrewcheng Guangxu Cheng added a comment - Thanks all for reviewing.

          People

          • Assignee:
            andrewcheng Guangxu Cheng
            Reporter:
            andrewcheng Guangxu Cheng
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development