Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-19262

Revisit checkstyle rules

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Reviewed
    • Change the import order rule that now we should put the shaded import at bottom. Ignore the VisibilityModifier warnings for test code.

    Description

      For the shaded imports, I prefer we put it at the bottom with a separated block. And also, for UTs which use junit rule, we usually declare the field as public but checkstyle will report a VisibilityModifier problem.

      Attachments

        1. HBASE-19262.patch
          2 kB
          Duo Zhang
        2. idea_import_layout.png
          60 kB
          Apekshit Sharma

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            zhangduo Duo Zhang
            zhangduo Duo Zhang
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment