Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-18169 Coprocessor fix and cleanup before 2.0.0 release
  3. HBASE-19122

preCompact and preFlush can bypass by returning null scanner; shut it down

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Reviewed
    • Remove the ability to 'bypass' preFlush and preCompact by returning a null Scanner. Bypass is disallowed on these methods in hbase2.

    Description

      Noticed by Anoop Sam John during review of HBASE-18770, preCompact and preFlush can bypass normal processing by returning null. They are not bypasable by ordained route. We should shut down this avenue.

      The preCompact at least may be new coming in with:

      tree dbf13093842f85a713f023d7219caccf8f4eb05f
      parent a4dcf51415616772e462091ce93622f070ea8810
      author zhangduo <zhangduo@apache.org> Sat Apr 9 16:18:08 2016 +0800
      committer zhangduo <zhangduo@apache.org> Sun Apr 10 09:26:28 2016 +0800
      
      HBASE-15527 Refactor Compactor related classes
      

      Would have to dig in more to figure for sure.

      Attachments

        1. HBASE-19122.master.001.patch
          14 kB
          Michael Stack
        2. HBASE-19122.master.002.patch
          17 kB
          Michael Stack
        3. HBASE-19122.master.003.patch
          17 kB
          Michael Stack
        4. HBASE-19122.master.004.patch
          17 kB
          Michael Stack

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            stack Michael Stack
            stack Michael Stack
            Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment