Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-18169 Coprocessor fix and cleanup before 2.0.0 release
  3. HBASE-19046

RegionObserver#postCompactSelection Avoid passing shaded ImmutableList param

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 2.0.0-alpha-4, 2.0.0
    • Coprocessors
    • None
    • Incompatible change, Reviewed
    • Hide
      RegionObserver#postCompactSelection signature is changed.
      Arg type org.apache.hadoop.hbase.shaded.com.google.common.collect.ImmutableList is replaced with java.util.List
      Show
      RegionObserver#postCompactSelection signature is changed. Arg type org.apache.hadoop.hbase.shaded.com.google.common.collect.ImmutableList is replaced with java.util.List

    Description

      Dont think there is any specific need for passing this PB type. We can just pass an unmodifiableList list object. Javadoc can say this is an unmodifiableList . Thats it . No need that the type itself to be Immutable...

      Attachments

        1. HBASE-19046.patch
          4 kB
          Anoop Sam John
        2. HBASE-19046.patch
          3 kB
          Anoop Sam John

        Activity

          People

            anoop.hbase Anoop Sam John
            anoop.hbase Anoop Sam John
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: