Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-18978 Align the methods in Table and AsyncTable
  3. HBASE-19029

Align RPC timout methods in Table and AsyncTableBase

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha-3
    • Fix Version/s: 2.0.0-alpha-4, 2.0.0
    • Component/s: asyncclient, Client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      Deprecate the following methods in Table:
      - int getRpcTimeout()
      - int getReadRpcTimeout()
      - int getWriteRpcTimeout()
      - int getOperationTimeout()

      Add the following methods to Table:
      - long getRpcTimeout(TimeUnit)
      - long getReadRpcTimeout(TimeUnit)
      - long getWriteRpcTimeout(TimeUnit)
      - long getOperationTimeout(TimeUnit)

      Add missing deprecation tag for long getRpcTimeout(TimeUnit unit) in AsyncTableBase
      Show
      Deprecate the following methods in Table: - int getRpcTimeout() - int getReadRpcTimeout() - int getWriteRpcTimeout() - int getOperationTimeout() Add the following methods to Table: - long getRpcTimeout(TimeUnit) - long getReadRpcTimeout(TimeUnit) - long getWriteRpcTimeout(TimeUnit) - long getOperationTimeout(TimeUnit) Add missing deprecation tag for long getRpcTimeout(TimeUnit unit) in AsyncTableBase

      Description

      Table and AsyncTableBase have similar RPC timeout methods but the async version supports TimeUtils to be passed.
      To align these 2 interfaces lets depricate the existing methods in Table and add the ones that are currently in AsyncTableBase.

      These methods are the following:

      • long getRpcTimeout(TimeUnit unit)
      • long getReadRpcTimeout(TimeUnit unit)
      • long getWriteRpcTimeout(TimeUnit unit)
      • long getOperationTimeout(TimeUnit unit)

      We do not have long getScanTimeout(TimeUnit unit) since scan is handled differently.

        Attachments

        1. HBASE-19029.master.001.patch
          32 kB
          Peter Somogyi
        2. HBASE-19029.master.002.patch
          31 kB
          Peter Somogyi
        3. HBASE-19029.master.002.patch
          31 kB
          Peter Somogyi
        4. HBASE-19029.master.003.patch
          31 kB
          Peter Somogyi
        5. HBASE-19029.master.003.patch
          31 kB
          Peter Somogyi
        6. HBASE-19029.master.003.patch
          31 kB
          Peter Somogyi
        7. HBASE-19029.master.004.patch
          28 kB
          Peter Somogyi

          Issue Links

            Activity

              People

              • Assignee:
                psomogyi Peter Somogyi
                Reporter:
                psomogyi Peter Somogyi
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: