[HBASE-18834] fix shellcheck warning on hbase personality

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.0.0-alpha-4, 2.0.0
• Component/s: test
• Assignee: Sean Busbey
• Reporter: Sean Busbey
• Created: 18/Sep/17 04:54
• Updated: 01/Aug/18 06:21
• Resolved: 18/Sep/17 13:56

Description

current shellcheck gives us two warnings:

$ shellcheck dev-support/hbase-personality.sh 

In dev-support/hbase-personality.sh line 123:
        if [[ $? -eq 0 ]]; then
              ^-- SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.


In dev-support/hbase-personality.sh line 136:
        if [[ $? -eq 0 ]]; then
              ^-- SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.