[HBASE-18808] Ineffective config check in BackupLogCleaner#getDeletableFiles()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0-alpha-4, 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Reid Chan
• Reporter: Ted Yu
• Created: 13/Sep/17 17:08
• Updated: 01/Jul/22 20:11
• Resolved: 18/Sep/17 17:17

Description

Here is related code:

    if (this.getConf() == null || !BackupManager.isBackupEnabled(getConf())) {
      LOG.warn("Backup is not enabled. Check your " + BackupRestoreConstants.BACKUP_ENABLE_KEY
          + " setting");
      return files;
    }

However, in setConf() we don't store the Configuration where backup is disabled:

  public void setConf(Configuration config) {
    // If backup is disabled, keep all members null
    if (!config.getBoolean(BackupRestoreConstants.BACKUP_ENABLE_KEY,
      BackupRestoreConstants.BACKUP_ENABLE_DEFAULT)) {
      LOG.warn("Backup is disabled - allowing all wals to be deleted");
      return;
    }

This means that once config with backup enabled is remembered, it won't go to disabled state.

Issue Links

• is part of: HBASE-18892 B&R testing