Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-18169 Coprocessor fix and cleanup before 2.0.0 release
  3. HBASE-18793

Remove deprecated methods in RegionObserver

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 3.0.0-alpha-1, 2.0.0-alpha-2
    • 2.0.0-alpha-3, 2.0.0
    • Coprocessors
    • None
    • Incompatible change, Reviewed
    • Hide
      These deprecated methods are removed from RegionObserver:
      InternalScanner preFlushScannerOpen(ObserverContext, Store, List, InternalScanner) throws IOException;
      void preCompactSelection(ObserverContext, Store, List) throws IOException;
      void postCompactSelection(ObserverContext, Store, ImmutableList);
      InternalScanner preCompact(ObserverContext, Store, InternalScanner, ScanType) throws IOException;
      InternalScanner preCompactScannerOpen(ObserverContext, Store, List, ScanType, long, InternalScanner, CompactionRequest) throws IOException;
      InternalScanner preCompactScannerOpen( ObserverContext, Store store, List, ScanType, long, InternalScanner) throws IOException;
      void preSplit(ObserverContext) throws IOException;
      void preSplit(ObserverContext, byte[]) throws IOException;
      void postSplit(ObserverContext, Region, Region) throws IOException;
      void preSplitBeforePONR(ObserverContext, byte[], List) throws IOException;
      void preSplitAfterPONR(ObserverContext) throws IOException;
      void preRollBackSplit(ObserverContext) throws IOException;
      void postRollBackSplit(ObserverContext) throws IOException;
      void postCompleteSplit(ObserverContext) throws IOException;
      long preIncrementColumnValue(ObserverContext, byte[], byte[], byte[], long, boolean) throws IOException;
      long postIncrementColumnValue(ObserverContextc, byte[], byte[], byte[], long, boolean, long) throws IOException;
      KeyValueScanner preStoreScannerOpen(ObserverContext, Store, Scan, NavigableSet, KeyValueScanner) throws IOException;
      boolean postScannerFilterRow(ObserverContext, InternalScanner, byte[], int, short, boolean) throws IOException;
      boolean postBulkLoadHFile(ObserverContext, List, boolean) throws IOException;

      And this method is also removed since we never call it in our code base:
      InternalScanner preFlushScannerOpen(ObserverContext, Store, KeyValueScanner, InternalScanner, long) throws IOException;

      The deprecated annotation is removed for these two methods as they are still being used:
      void preFlush(ObserverContext) throws IOException;
      void postFlush(ObserverContextc) throws IOException;
      Show
      These deprecated methods are removed from RegionObserver: InternalScanner preFlushScannerOpen(ObserverContext, Store, List, InternalScanner) throws IOException; void preCompactSelection(ObserverContext, Store, List) throws IOException; void postCompactSelection(ObserverContext, Store, ImmutableList); InternalScanner preCompact(ObserverContext, Store, InternalScanner, ScanType) throws IOException; InternalScanner preCompactScannerOpen(ObserverContext, Store, List, ScanType, long, InternalScanner, CompactionRequest) throws IOException; InternalScanner preCompactScannerOpen( ObserverContext, Store store, List, ScanType, long, InternalScanner) throws IOException; void preSplit(ObserverContext) throws IOException; void preSplit(ObserverContext, byte[]) throws IOException; void postSplit(ObserverContext, Region, Region) throws IOException; void preSplitBeforePONR(ObserverContext, byte[], List) throws IOException; void preSplitAfterPONR(ObserverContext) throws IOException; void preRollBackSplit(ObserverContext) throws IOException; void postRollBackSplit(ObserverContext) throws IOException; void postCompleteSplit(ObserverContext) throws IOException; long preIncrementColumnValue(ObserverContext, byte[], byte[], byte[], long, boolean) throws IOException; long postIncrementColumnValue(ObserverContextc, byte[], byte[], byte[], long, boolean, long) throws IOException; KeyValueScanner preStoreScannerOpen(ObserverContext, Store, Scan, NavigableSet, KeyValueScanner) throws IOException; boolean postScannerFilterRow(ObserverContext, InternalScanner, byte[], int, short, boolean) throws IOException; boolean postBulkLoadHFile(ObserverContext, List, boolean) throws IOException; And this method is also removed since we never call it in our code base: InternalScanner preFlushScannerOpen(ObserverContext, Store, KeyValueScanner, InternalScanner, long) throws IOException; The deprecated annotation is removed for these two methods as they are still being used: void preFlush(ObserverContext) throws IOException; void postFlush(ObserverContextc) throws IOException;

    Description

      As we have already done lots of incomplete changes on CP APIs and it is allowed to do breaking changes on major release.

      Let's make the API clean.

      Attachments

        1. HBASE-18793.patch
          96 kB
          Duo Zhang
        2. HBASE-18793-v1.patch
          97 kB
          Duo Zhang

        Issue Links

          is related to

          New Feature - A new feature of the product, which has yet to be developed. HBASE-6427 Pluggable compaction and scan policies via coprocessors

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          links to

          Web Link Review Board

          Activity

            People

              zhangduo Duo Zhang
              zhangduo Duo Zhang
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: