Details

    • Type: Sub-task
    • Status: Patch Available
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      HBASE-18444 adds a method of specifying a meta table suffix. To continue work on HBASE-18477, we need a way to determine if a TableName is a meta table. This patch adds this method and a unit test.

      1. HBASE-18773.HBASE-18477.001.patch
        2 kB
        Zach York
      2. HBASE-18773.HBASE-18477.002.patch
        6 kB
        Zach York
      3. HBASE-18773.HBASE-18477.003.patch
        6 kB
        Zach York
      4. HBASE-18773.HBASE-18477.004.patch
        6 kB
        Zach York
      5. HBASE-18773.HBASE-18477.005.patch
        6 kB
        Zach York
      6. HBASE-18773.HBASE-18477.006.patch
        6 kB
        Zach York

        Issue Links

          Activity

          Hide
          zyork Zach York added a comment -

          The reason this is broken out into a separate commit is because multiple JIRAs will depend on this (the first of which being HBASE-18775)

          Show
          zyork Zach York added a comment - The reason this is broken out into a separate commit is because multiple JIRAs will depend on this (the first of which being HBASE-18775 )
          Hide
          uagashe Umesh Agashe added a comment -

          Zach York, there is existing method

          public static boolean isMetaTableName(final TableName tn)
          

          Does new method serve different purpose?

          Show
          uagashe Umesh Agashe added a comment - Zach York , there is existing method public static boolean isMetaTableName( final TableName tn) Does new method serve different purpose?
          Hide
          zyork Zach York added a comment -

          Umesh Agashe Ah, I originally did the dev on branch-1 where this method doesn't exist.

          However this is an interesting question. I think it might make sense to have two methods:

          1. is the TableName this cluster's meta table
          2. is the TableName any cluster's meta table (i.e. with any suffix - see HBASE-18444)

          Show
          zyork Zach York added a comment - Umesh Agashe Ah, I originally did the dev on branch-1 where this method doesn't exist. However this is an interesting question. I think it might make sense to have two methods: 1. is the TableName this cluster's meta table 2. is the TableName any cluster's meta table (i.e. with any suffix - see HBASE-18444 )
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 17m 31s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 47s HBASE-18477 passed
          +1 compile 0m 18s HBASE-18477 passed
          +1 checkstyle 0m 28s HBASE-18477 passed
          +1 mvneclipse 0m 20s HBASE-18477 passed
          +1 findbugs 0m 39s HBASE-18477 passed
          +1 javadoc 0m 24s HBASE-18477 passed
          +1 mvninstall 0m 19s the patch passed
          +1 compile 0m 19s the patch passed
          +1 javac 0m 19s the patch passed
          +1 checkstyle 0m 24s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 hadoopcheck 35m 29s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          +1 findbugs 0m 39s the patch passed
          +1 javadoc 0m 17s the patch passed
          +1 unit 2m 40s hbase-common in the patch passed.
          +1 asflicense 0m 11s The patch does not generate ASF License warnings.
          68m 18s



          Subsystem Report/Notes
          Docker Client=1.12.0 Server=1.12.0 Image:yetus/hbase:5d60123
          JIRA Issue HBASE-18773
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885925/HBASE-18773.HBASE-18477.001.patch
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux fdf626544ff7 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision HBASE-18477 / 8e866d6
          Default Java 1.8.0_144
          findbugs v3.1.0-RC3
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8504/testReport/
          modules C: hbase-common U: hbase-common
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8504/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 17m 31s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 47s HBASE-18477 passed +1 compile 0m 18s HBASE-18477 passed +1 checkstyle 0m 28s HBASE-18477 passed +1 mvneclipse 0m 20s HBASE-18477 passed +1 findbugs 0m 39s HBASE-18477 passed +1 javadoc 0m 24s HBASE-18477 passed +1 mvninstall 0m 19s the patch passed +1 compile 0m 19s the patch passed +1 javac 0m 19s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 35m 29s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. +1 findbugs 0m 39s the patch passed +1 javadoc 0m 17s the patch passed +1 unit 2m 40s hbase-common in the patch passed. +1 asflicense 0m 11s The patch does not generate ASF License warnings. 68m 18s Subsystem Report/Notes Docker Client=1.12.0 Server=1.12.0 Image:yetus/hbase:5d60123 JIRA Issue HBASE-18773 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885925/HBASE-18773.HBASE-18477.001.patch Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux fdf626544ff7 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision HBASE-18477 / 8e866d6 Default Java 1.8.0_144 findbugs v3.1.0-RC3 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8504/testReport/ modules C: hbase-common U: hbase-common Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8504/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          zyork Zach York added a comment -

          For some reason RB is not letting me publish my comment. Putting it here for now:

          Umesh Agashe, yes the HRegionInfo methods used this new method I created in the implementation (in a separate patch).

          stack, do you mean something like what I have below (dynamic isMeta):

          public boolean isMeta() {
          String[] parts = getNameWithNamespaceInclAsString().split(String.valueOf(NAMESPACE_DELIM));
          if (parts[0].equals(NamespaceDescriptor.SYSTEM_NAMESPACE_NAME_STR) && parts[1].contains(DEFAULT_META_TABLE_NAME_STR))

          { return true; }

          return false;
          }

          The only issue I see with this approach is that it might be confusing for TableName.isMetaTableName() and tableName.isMeta to return different results.

          Show
          zyork Zach York added a comment - For some reason RB is not letting me publish my comment. Putting it here for now: Umesh Agashe , yes the HRegionInfo methods used this new method I created in the implementation (in a separate patch). stack , do you mean something like what I have below (dynamic isMeta): public boolean isMeta() { String[] parts = getNameWithNamespaceInclAsString().split(String.valueOf(NAMESPACE_DELIM)); if (parts [0] .equals(NamespaceDescriptor.SYSTEM_NAMESPACE_NAME_STR) && parts [1] .contains(DEFAULT_META_TABLE_NAME_STR)) { return true; } return false; } The only issue I see with this approach is that it might be confusing for TableName.isMetaTableName() and tableName.isMeta to return different results.
          Hide
          stack stack added a comment -

          The only issue I see with this approach is that it might be confusing for TableName.isMetaTableName() and tableName.isMeta to return different results.

          Yeah. That looks about right. Make them the same.

          Show
          stack stack added a comment - The only issue I see with this approach is that it might be confusing for TableName.isMetaTableName() and tableName.isMeta to return different results. Yeah. That looks about right. Make them the same.
          Hide
          zyork Zach York added a comment -

          Yeah. That looks about right. Make them the same.

          stack I think there is some miscommunication here. While I think that making a dynamic way of accessing this makes sense, I also need to have both implementations of this function. (1) One that checks that this is the correct meta table name EXACTLY (including meta suffix if applicable) and (2) one that checks if it is a meta table (without any suffixes applied).

          I can change the funtionality of isMeta() and isMetaTableName() to (1) and then create a new method isMetaTableNameWithSuffix() for (2). What do you think of this approach?

          Show
          zyork Zach York added a comment - Yeah. That looks about right. Make them the same. stack I think there is some miscommunication here. While I think that making a dynamic way of accessing this makes sense, I also need to have both implementations of this function. (1) One that checks that this is the correct meta table name EXACTLY (including meta suffix if applicable) and (2) one that checks if it is a meta table (without any suffixes applied). I can change the funtionality of isMeta() and isMetaTableName() to (1) and then create a new method isMetaTableNameWithSuffix() for (2). What do you think of this approach?
          Hide
          stack stack added a comment -

          Sounds good.

          Can you corral isMetaTableNameWithSuffix so it is hard-to-find unless you are doing this Read Replica Cluster feature – put it in a utility class or whatever (no harm if not as long as it has good javadoc... to distingush it from 'normal' function).

          Show
          stack stack added a comment - Sounds good. Can you corral isMetaTableNameWithSuffix so it is hard-to-find unless you are doing this Read Replica Cluster feature – put it in a utility class or whatever (no harm if not as long as it has good javadoc... to distingush it from 'normal' function).
          Hide
          zyork Zach York added a comment -

          stack I added a new patch that incorporates these comments.

          Show
          zyork Zach York added a comment - stack I added a new patch that incorporates these comments.
          Hide
          zyork Zach York added a comment -

          Added patch 004 to address issues Ted Yu brought up in https://reviews.apache.org/r/62260/.

          Show
          zyork Zach York added a comment - Added patch 004 to address issues Ted Yu brought up in https://reviews.apache.org/r/62260/ .
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 22s HBASE-18477 passed
          +1 compile 0m 16s HBASE-18477 passed
          +1 checkstyle 0m 24s HBASE-18477 passed
          +1 mvneclipse 0m 21s HBASE-18477 passed
          +1 findbugs 0m 31s HBASE-18477 passed
          +1 javadoc 0m 19s HBASE-18477 passed
          +1 mvninstall 0m 16s the patch passed
          +1 compile 0m 15s the patch passed
          +1 javac 0m 15s the patch passed
          +1 checkstyle 0m 20s the patch passed
          +1 mvneclipse 0m 9s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 hadoopcheck 33m 34s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          +1 findbugs 0m 40s the patch passed
          +1 javadoc 0m 15s the patch passed
          +1 unit 2m 20s hbase-common in the patch passed.
          +1 asflicense 0m 10s The patch does not generate ASF License warnings.
          47m 52s



          Subsystem Report/Notes
          Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:5d60123
          JIRA Issue HBASE-18773
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886735/HBASE-18773.HBASE-18477.003.patch
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux 4c1dccb94df5 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision HBASE-18477 / 8e866d6
          Default Java 1.8.0_144
          findbugs v3.1.0-RC3
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8591/testReport/
          modules C: hbase-common U: hbase-common
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8591/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 22s HBASE-18477 passed +1 compile 0m 16s HBASE-18477 passed +1 checkstyle 0m 24s HBASE-18477 passed +1 mvneclipse 0m 21s HBASE-18477 passed +1 findbugs 0m 31s HBASE-18477 passed +1 javadoc 0m 19s HBASE-18477 passed +1 mvninstall 0m 16s the patch passed +1 compile 0m 15s the patch passed +1 javac 0m 15s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 33m 34s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. +1 findbugs 0m 40s the patch passed +1 javadoc 0m 15s the patch passed +1 unit 2m 20s hbase-common in the patch passed. +1 asflicense 0m 10s The patch does not generate ASF License warnings. 47m 52s Subsystem Report/Notes Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:5d60123 JIRA Issue HBASE-18773 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886735/HBASE-18773.HBASE-18477.003.patch Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 4c1dccb94df5 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision HBASE-18477 / 8e866d6 Default Java 1.8.0_144 findbugs v3.1.0-RC3 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8591/testReport/ modules C: hbase-common U: hbase-common Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8591/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 8m 4s HBASE-18477 passed
          +1 compile 0m 20s HBASE-18477 passed
          +1 checkstyle 0m 27s HBASE-18477 passed
          +1 mvneclipse 0m 25s HBASE-18477 passed
          +1 findbugs 0m 38s HBASE-18477 passed
          +1 javadoc 0m 23s HBASE-18477 passed
          +1 mvninstall 0m 20s the patch passed
          +1 compile 0m 21s the patch passed
          +1 javac 0m 21s the patch passed
          +1 checkstyle 0m 24s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 hadoopcheck 37m 25s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          +1 findbugs 0m 41s the patch passed
          +1 javadoc 0m 16s the patch passed
          +1 unit 2m 19s hbase-common in the patch passed.
          +1 asflicense 0m 10s The patch does not generate ASF License warnings.
          53m 1s



          Subsystem Report/Notes
          Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:5d60123
          JIRA Issue HBASE-18773
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886749/HBASE-18773.HBASE-18477.004.patch
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux 4147040561d4 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
          git revision HBASE-18477 / 8e866d6
          Default Java 1.8.0_144
          findbugs v3.1.0-RC3
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8592/testReport/
          modules C: hbase-common U: hbase-common
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8592/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 4s HBASE-18477 passed +1 compile 0m 20s HBASE-18477 passed +1 checkstyle 0m 27s HBASE-18477 passed +1 mvneclipse 0m 25s HBASE-18477 passed +1 findbugs 0m 38s HBASE-18477 passed +1 javadoc 0m 23s HBASE-18477 passed +1 mvninstall 0m 20s the patch passed +1 compile 0m 21s the patch passed +1 javac 0m 21s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 37m 25s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. +1 findbugs 0m 41s the patch passed +1 javadoc 0m 16s the patch passed +1 unit 2m 19s hbase-common in the patch passed. +1 asflicense 0m 10s The patch does not generate ASF License warnings. 53m 1s Subsystem Report/Notes Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:5d60123 JIRA Issue HBASE-18773 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886749/HBASE-18773.HBASE-18477.004.patch Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 4147040561d4 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision HBASE-18477 / 8e866d6 Default Java 1.8.0_144 findbugs v3.1.0-RC3 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8592/testReport/ modules C: hbase-common U: hbase-common Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8592/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 36s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 14m 0s HBASE-18477 passed
          +1 compile 0m 47s HBASE-18477 passed
          +1 checkstyle 0m 47s HBASE-18477 passed
          +1 mvneclipse 0m 36s HBASE-18477 passed
          +1 findbugs 1m 30s HBASE-18477 passed
          +1 javadoc 0m 45s HBASE-18477 passed
          +1 mvninstall 0m 41s the patch passed
          +1 compile 0m 41s the patch passed
          +1 javac 0m 41s the patch passed
          +1 checkstyle 0m 46s the patch passed
          +1 mvneclipse 0m 25s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 hadoopcheck 87m 53s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          +1 findbugs 2m 4s the patch passed
          +1 javadoc 0m 43s the patch passed
          +1 unit 4m 22s hbase-common in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          118m 0s



          Subsystem Report/Notes
          Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:5d60123
          JIRA Issue HBASE-18773
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886734/HBASE-18773.HBASE-18477.002.patch
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux 8a2a552f96db 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
          git revision HBASE-18477 / 8e866d6
          Default Java 1.8.0_144
          findbugs v3.1.0-RC3
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8590/testReport/
          modules C: hbase-common U: hbase-common
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8590/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 36s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 14m 0s HBASE-18477 passed +1 compile 0m 47s HBASE-18477 passed +1 checkstyle 0m 47s HBASE-18477 passed +1 mvneclipse 0m 36s HBASE-18477 passed +1 findbugs 1m 30s HBASE-18477 passed +1 javadoc 0m 45s HBASE-18477 passed +1 mvninstall 0m 41s the patch passed +1 compile 0m 41s the patch passed +1 javac 0m 41s the patch passed +1 checkstyle 0m 46s the patch passed +1 mvneclipse 0m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 87m 53s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. +1 findbugs 2m 4s the patch passed +1 javadoc 0m 43s the patch passed +1 unit 4m 22s hbase-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 118m 0s Subsystem Report/Notes Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:5d60123 JIRA Issue HBASE-18773 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886734/HBASE-18773.HBASE-18477.002.patch Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 8a2a552f96db 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision HBASE-18477 / 8e866d6 Default Java 1.8.0_144 findbugs v3.1.0-RC3 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8590/testReport/ modules C: hbase-common U: hbase-common Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8590/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          zyork Zach York added a comment - - edited

          stack Umesh Agashe Ted Yu Any other concerns with the patch? I'd like to get this done so the other patches that depend on this don't also include this code (for example HBASE-18775).

          Show
          zyork Zach York added a comment - - edited stack Umesh Agashe Ted Yu Any other concerns with the patch? I'd like to get this done so the other patches that depend on this don't also include this code (for example HBASE-18775 ).
          Hide
          zyork Zach York added a comment -

          stack Umesh Agashe Ted Yu Ping?

          I'm getting ready to put up another patch depending on this and would love to be able to rebase on top of this commit (and avoid some complications with dev-support/submit-patch which only allows 1 commit to be present)

          Show
          zyork Zach York added a comment - stack Umesh Agashe Ted Yu Ping? I'm getting ready to put up another patch depending on this and would love to be able to rebase on top of this commit (and avoid some complications with dev-support/submit-patch which only allows 1 commit to be present)
          Hide
          uagashe Umesh Agashe added a comment -

          +1 non-binding. One nit posted on reviewboard. Thanks for the patch Zach York!

          Show
          uagashe Umesh Agashe added a comment - +1 non-binding. One nit posted on reviewboard. Thanks for the patch Zach York !
          Hide
          zyork Zach York added a comment -

          Umesh Agashe I made the fix in the latest patch.

          stack What do you think of the latest patch?

          Show
          zyork Zach York added a comment - Umesh Agashe I made the fix in the latest patch. stack What do you think of the latest patch?
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 44s HBASE-18477 passed
          +1 compile 0m 19s HBASE-18477 passed
          +1 checkstyle 0m 27s HBASE-18477 passed
          +1 mvneclipse 0m 21s HBASE-18477 passed
          +1 findbugs 0m 39s HBASE-18477 passed
          +1 javadoc 0m 22s HBASE-18477 passed
          +1 mvninstall 0m 19s the patch passed
          +1 compile 0m 18s the patch passed
          +1 javac 0m 18s the patch passed
          +1 checkstyle 0m 22s the patch passed
          +1 mvneclipse 0m 9s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 hadoopcheck 34m 4s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          +1 findbugs 0m 44s the patch passed
          +1 javadoc 0m 19s the patch passed
          +1 unit 2m 23s hbase-common in the patch passed.
          +1 asflicense 0m 9s The patch does not generate ASF License warnings.
          49m 17s



          Subsystem Report/Notes
          Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:5d60123
          JIRA Issue HBASE-18773
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887154/HBASE-18773.HBASE-18477.006.patch
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux a103675146b9 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision HBASE-18477 / 8e866d6
          Default Java 1.8.0_144
          findbugs v3.1.0-RC3
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8631/testReport/
          modules C: hbase-common U: hbase-common
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8631/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 44s HBASE-18477 passed +1 compile 0m 19s HBASE-18477 passed +1 checkstyle 0m 27s HBASE-18477 passed +1 mvneclipse 0m 21s HBASE-18477 passed +1 findbugs 0m 39s HBASE-18477 passed +1 javadoc 0m 22s HBASE-18477 passed +1 mvninstall 0m 19s the patch passed +1 compile 0m 18s the patch passed +1 javac 0m 18s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 34m 4s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. +1 findbugs 0m 44s the patch passed +1 javadoc 0m 19s the patch passed +1 unit 2m 23s hbase-common in the patch passed. +1 asflicense 0m 9s The patch does not generate ASF License warnings. 49m 17s Subsystem Report/Notes Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:5d60123 JIRA Issue HBASE-18773 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887154/HBASE-18773.HBASE-18477.006.patch Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux a103675146b9 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision HBASE-18477 / 8e866d6 Default Java 1.8.0_144 findbugs v3.1.0-RC3 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8631/testReport/ modules C: hbase-common U: hbase-common Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8631/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          zyork Zach York added a comment -

          stack Sorry for the relentless pinging I know you are busy with the 2.0.0 release

          Can you take another look?

          Show
          zyork Zach York added a comment - stack Sorry for the relentless pinging I know you are busy with the 2.0.0 release Can you take another look?

            People

            • Assignee:
              zyork Zach York
              Reporter:
              zyork Zach York
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:

                Development