Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-18623

Frequent failed to parse at EOF warnings from WALEntryStream

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0, 3.0.0, 1.4.0, 1.5.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Lots of messages like this

      2017-08-17 15:10:36,363 INFO
      [main-EventThread.replicationSource,2.replicationSource.replicationWALReaderThread.onyx%2C8120%2C1503007587035,2]
      regionserver.WALEntryStream: Reached the end of WAL file 'hdfs://localhost:8020/hbase-1/WALs/onyx,8120,1503007587035/onyx%2C8120%2C1503007587035.1503007826083'.
      It was not closed cleanly, so we did not parse 8 bytes of data.
      

      Fix this, either the message (if harmless) or the underlying cause.

      1. HBASE-18623.patch
        1 kB
        Andrew Purtell

        Activity

        Hide
        busbey Sean Busbey added a comment -

        IIRC, this was added back when I was trying to get more information out of the replication system. The situation described is probably harmless, since we expect non-cleanly closed WALs to have unparseable partial entries. It's hard to say it's always fine, since we have yet to find the source of the corruption in HBASE-15983.

        How about we move the message to DEBUG and expressly have it say that the failure to parse some data in an unclosed file is usually fine?

        Show
        busbey Sean Busbey added a comment - IIRC, this was added back when I was trying to get more information out of the replication system. The situation described is probably harmless, since we expect non-cleanly closed WALs to have unparseable partial entries. It's hard to say it's always fine, since we have yet to find the source of the corruption in HBASE-15983 . How about we move the message to DEBUG and expressly have it say that the failure to parse some data in an unclosed file is usually fine?
        Hide
        apurtell Andrew Purtell added a comment -

        Ok Sean Busbey I'll implement that suggestion.

        Show
        apurtell Andrew Purtell added a comment - Ok Sean Busbey I'll implement that suggestion.
        Hide
        apurtell Andrew Purtell added a comment -

        Trivial patch

        Show
        apurtell Andrew Purtell added a comment - Trivial patch
        Hide
        apurtell Andrew Purtell added a comment -

        Going to commit trivial patch implementing Sean's suggestion, a logging only change, tomorrow unless objection.

        Show
        apurtell Andrew Purtell added a comment - Going to commit trivial patch implementing Sean's suggestion, a logging only change, tomorrow unless objection.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 24s Docker mode activated.
        +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 4m 15s master passed
        +1 compile 0m 42s master passed
        +1 checkstyle 0m 51s master passed
        +1 mvneclipse 0m 16s master passed
        +1 findbugs 3m 36s master passed
        +1 javadoc 0m 36s master passed
        +1 mvninstall 0m 54s the patch passed
        +1 compile 0m 46s the patch passed
        +1 javac 0m 46s the patch passed
        +1 checkstyle 0m 54s the patch passed
        +1 mvneclipse 0m 16s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 hadoopcheck 38m 27s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
        +1 findbugs 4m 12s the patch passed
        +1 javadoc 0m 36s the patch passed
        +1 unit 145m 30s hbase-server in the patch passed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        202m 53s



        Subsystem Report/Notes
        Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:bdc94b1
        JIRA Issue HBASE-18623
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882695/HBASE-18623.patch
        Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
        uname Linux 4033d28d9340 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
        git revision master / b932d38
        Default Java 1.8.0_144
        findbugs v3.1.0-RC3
        Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8171/testReport/
        modules C: hbase-server U: hbase-server
        Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8171/console
        Powered by Apache Yetus 0.4.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 24s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 4m 15s master passed +1 compile 0m 42s master passed +1 checkstyle 0m 51s master passed +1 mvneclipse 0m 16s master passed +1 findbugs 3m 36s master passed +1 javadoc 0m 36s master passed +1 mvninstall 0m 54s the patch passed +1 compile 0m 46s the patch passed +1 javac 0m 46s the patch passed +1 checkstyle 0m 54s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 38m 27s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. +1 findbugs 4m 12s the patch passed +1 javadoc 0m 36s the patch passed +1 unit 145m 30s hbase-server in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 202m 53s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:bdc94b1 JIRA Issue HBASE-18623 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882695/HBASE-18623.patch Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 4033d28d9340 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / b932d38 Default Java 1.8.0_144 findbugs v3.1.0-RC3 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8171/testReport/ modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8171/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
        Hide
        busbey Sean Busbey added a comment -

        +1.

        Show
        busbey Sean Busbey added a comment - +1.
        Hide
        apurtell Andrew Purtell added a comment -

        Pushed to branch-1.4 and up.

        Show
        apurtell Andrew Purtell added a comment - Pushed to branch-1.4 and up.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Jenkins build HBase-1.5 #20 (See https://builds.apache.org/job/HBase-1.5/20/)
        HBASE-18623 Frequent failed to parse at EOF warnings from WALEntryStream (apurtell: rev 19fffacd3a95bc6eebd3ea3bc0d9ff0a2593e37b)

        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-1.5 #20 (See https://builds.apache.org/job/HBase-1.5/20/ ) HBASE-18623 Frequent failed to parse at EOF warnings from WALEntryStream (apurtell: rev 19fffacd3a95bc6eebd3ea3bc0d9ff0a2593e37b) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Jenkins build HBase-1.4 #873 (See https://builds.apache.org/job/HBase-1.4/873/)
        HBASE-18623 Frequent failed to parse at EOF warnings from WALEntryStream (apurtell: rev c51c784697b1dc108e7ad31fdae7992b754c9430)

        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-1.4 #873 (See https://builds.apache.org/job/HBase-1.4/873/ ) HBASE-18623 Frequent failed to parse at EOF warnings from WALEntryStream (apurtell: rev c51c784697b1dc108e7ad31fdae7992b754c9430) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Jenkins build HBase-2.0 #371 (See https://builds.apache.org/job/HBase-2.0/371/)
        HBASE-18623 Frequent failed to parse at EOF warnings from WALEntryStream (apurtell: rev 7fef60634952135a063493051220a83308d04e22)

        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-2.0 #371 (See https://builds.apache.org/job/HBase-2.0/371/ ) HBASE-18623 Frequent failed to parse at EOF warnings from WALEntryStream (apurtell: rev 7fef60634952135a063493051220a83308d04e22) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3572 (See https://builds.apache.org/job/HBase-Trunk_matrix/3572/)
        HBASE-18623 Frequent failed to parse at EOF warnings from WALEntryStream (apurtell: rev 70d48b113e3b824e2804164e80edf01522c85272)

        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3572 (See https://builds.apache.org/job/HBase-Trunk_matrix/3572/ ) HBASE-18623 Frequent failed to parse at EOF warnings from WALEntryStream (apurtell: rev 70d48b113e3b824e2804164e80edf01522c85272) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Jenkins build HBASE-14070.HLC #263 (See https://builds.apache.org/job/HBASE-14070.HLC/263/)
        HBASE-18623 Frequent failed to parse at EOF warnings from WALEntryStream (apurtell: rev 70d48b113e3b824e2804164e80edf01522c85272)

        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBASE-14070 .HLC #263 (See https://builds.apache.org/job/HBASE-14070.HLC/263/ ) HBASE-18623 Frequent failed to parse at EOF warnings from WALEntryStream (apurtell: rev 70d48b113e3b824e2804164e80edf01522c85272) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java

          People

          • Assignee:
            apurtell Andrew Purtell
            Reporter:
            apurtell Andrew Purtell
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development