Details

    • Type: Task
    • Status: Patch Available
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 2.0.0, 3.0.0
    • Fix Version/s: 2.0.0-alpha-4
    • Component/s: None
    • Labels:
      None

      Description

      HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, the upgrade to 4.x is not trivial and would take time. It might not worth to keep it in this state, so would be better to remove it.

      Of course it doesn't mean tracing would be useless, just that in this form the use of HTrace 3.2 might not add any value to the project and fixing it would be far too much effort.
      ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
      Based on the decision of the community we keep htrace now and update version

      1. HBASE-18601.master.001.patch
        158 kB
        Tamas Penzes
      2. HBASE-18601.master.002.patch
        116 kB
        Tamas Penzes
      3. HBASE-18601.master.003.patch
        133 kB
        Tamas Penzes
      4. HBASE-18601.master.003 (3).patch
        133 kB
        stack
      5. HBASE-18601.master.004.patch
        134 kB
        stack
      6. HBASE-18601.master.004.patch
        134 kB
        Tamas Penzes

        Issue Links

          Activity

          Hide
          busbey Sean Busbey added a comment -

          Please start a DISCUSS thread on dev@hbase about this change. I don't disagree about the state of tracing in HBase, but we should ensure there isn't someone prepared to make it work in time for 2.0.

          Show
          busbey Sean Busbey added a comment - Please start a DISCUSS thread on dev@hbase about this change. I don't disagree about the state of tracing in HBase, but we should ensure there isn't someone prepared to make it work in time for 2.0.
          Hide
          apurtell Andrew Purtell added a comment -

          -1 for removal without replacement

          Also, we will need to sync with HDFS and Phoenix.

          Show
          apurtell Andrew Purtell added a comment - -1 for removal without replacement Also, we will need to sync with HDFS and Phoenix.
          Hide
          tamaas Tamas Penzes added a comment -

          Let's wait to apply the patch until the discussion is finished.

          Show
          tamaas Tamas Penzes added a comment - Let's wait to apply the patch until the discussion is finished.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 5s HBASE-18601 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for help.



          Subsystem Report/Notes
          JIRA Issue HBASE-18601
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882095/HBASE-18601.master.001.patch
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8114/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 5s HBASE-18601 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for help. Subsystem Report/Notes JIRA Issue HBASE-18601 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882095/HBASE-18601.master.001.patch Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8114/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          apurtell Andrew Purtell added a comment -

          -1

          I have a technical objection. That objection has two parts

          1. Compatibility concerns.
          2. Provide an alternative tracing API first.

          Please do not commit with valid technical objection in place or I will revert. Thanks.

          Show
          apurtell Andrew Purtell added a comment - -1 I have a technical objection. That objection has two parts 1. Compatibility concerns. 2. Provide an alternative tracing API first. Please do not commit with valid technical objection in place or I will revert. Thanks.
          Hide
          apurtell Andrew Purtell added a comment -

          There is a discussion underway about moving htrace to the attic. See https://lists.apache.org/thread.html/ff87eb11bbfc3ca27a83c0ab377459767a46175447f763b1bf052987@%3Cdev.htrace.apache.org%3E

          If this happens I withdraw my objection. The remaining question would then be only which branches the patch should be applied to.

          Show
          apurtell Andrew Purtell added a comment - There is a discussion underway about moving htrace to the attic. See https://lists.apache.org/thread.html/ff87eb11bbfc3ca27a83c0ab377459767a46175447f763b1bf052987@%3Cdev.htrace.apache.org%3E If this happens I withdraw my objection. The remaining question would then be only which branches the patch should be applied to.
          Hide
          busbey Sean Busbey added a comment -

          Regardless of the outcome for HTrace in HBase, it sounds like we should call out tracing in our compatibility concerns section on versioning.

          Show
          busbey Sean Busbey added a comment - Regardless of the outcome for HTrace in HBase, it sounds like we should call out tracing in our compatibility concerns section on versioning.
          Hide
          stack stack added a comment -

          Above cited discussion up on dev@htrace has died down. If I were to summarize, it would be that htrace is near death but not just yet; lets give it one more go. In particular, let the proofing project be hooking up hbase and hdfs (and ycsb even since it has trace too).

          Meantime, lets upgrade our htrace internally. Will assign Tamas Penzes to have a go at it (hope you don't mind my reassign Andrew Purtell). This issue is about updating lib only. Not about telling a good trace story. That we can do later.

          Tamas Penzes You saw HBASE-14451 ? It has a bunch of updating going on. It was unfinished. Might be of some use to you sir.

          Show
          stack stack added a comment - Above cited discussion up on dev@htrace has died down. If I were to summarize, it would be that htrace is near death but not just yet; lets give it one more go. In particular, let the proofing project be hooking up hbase and hdfs (and ycsb even since it has trace too). Meantime, lets upgrade our htrace internally. Will assign Tamas Penzes to have a go at it (hope you don't mind my reassign Andrew Purtell ). This issue is about updating lib only. Not about telling a good trace story. That we can do later. Tamas Penzes You saw HBASE-14451 ? It has a bunch of updating going on. It was unfinished. Might be of some use to you sir.
          Hide
          stack stack added a comment -

          Oh, summary says remove htrace-3.2. Should it be update?

          Show
          stack stack added a comment - Oh, summary says remove htrace-3.2. Should it be update?
          Hide
          tamaas Tamas Penzes added a comment - - edited

          after the agreement to not remove htrace I made a new patch to update it to 4.2.0

          updated title and description of ticket

          Show
          tamaas Tamas Penzes added a comment - - edited after the agreement to not remove htrace I made a new patch to update it to 4.2.0 updated title and description of ticket
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 20m 34s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 6 new or modified test files.
          0 mvndep 0m 47s Maven dependency ordering for branch
          +1 mvninstall 4m 29s master passed
          +1 compile 10m 41s master passed
          +1 checkstyle 3m 5s master passed
          +1 mvneclipse 7m 1s master passed
          +1 shadedjars 4m 33s branch has no errors when building our shaded downstream artifacts.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-testing-util .
          +1 findbugs 13m 52s master passed
          +1 javadoc 7m 34s master passed
          0 mvndep 0m 20s Maven dependency ordering for patch
          -1 mvninstall 0m 14s hbase-rest in the patch failed.
          -1 mvninstall 0m 34s hbase-spark in the patch failed.
          +1 compile 9m 25s the patch passed
          +1 javac 9m 25s the patch passed
          +1 checkstyle 2m 43s the patch passed
          +1 mvneclipse 6m 25s the patch passed
          +1 rubocop 0m 3s There were no new rubocop issues.
          +1 ruby-lint 0m 1s There were no new ruby-lint issues.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 26s The patch has no ill-formed XML file.
          +1 shadedjars 4m 24s patch has no errors when building our shaded downstream artifacts.
          +1 hadoopcheck 37m 34s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-testing-util .
          -1 findbugs 2m 24s hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 6m 56s the patch passed
          +1 unit 0m 27s hbase-protocol-shaded in the patch passed.
          +1 unit 2m 26s hbase-common in the patch passed.
          +1 unit 0m 30s hbase-hadoop2-compat in the patch passed.
          -1 unit 1m 31s hbase-client in the patch failed.
          +1 unit 0m 11s hbase-replication in the patch passed.
          +1 unit 0m 28s hbase-prefix-tree in the patch passed.
          +1 unit 3m 9s hbase-procedure in the patch passed.
          -1 unit 19m 42s hbase-server in the patch failed.
          -1 unit 21m 57s hbase-mapreduce in the patch failed.
          +1 unit 0m 15s hbase-testing-util in the patch passed.
          -1 unit 0m 38s hbase-thrift in the patch failed.
          +1 unit 0m 25s hbase-rsgroup in the patch passed.
          -1 unit 0m 46s hbase-shell in the patch failed.
          -1 unit 1m 15s hbase-endpoint in the patch failed.
          -1 unit 0m 48s hbase-backup in the patch failed.
          +1 unit 0m 22s hbase-it in the patch passed.
          -1 unit 0m 36s hbase-examples in the patch failed.
          -1 unit 21m 11s hbase-rest in the patch failed.
          +1 unit 0m 15s hbase-external-blockcache in the patch passed.
          -1 unit 1m 18s hbase-spark in the patch failed.
          -1 unit 8m 28s root in the patch failed.
          +1 asflicense 3m 17s The patch does not generate ASF License warnings.
          253m 36s



          Reason Tests
          FindBugs module:hbase-server
            Possible null pointer dereference of traceScope in org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.readBlock(long, long, boolean, boolean, boolean, boolean, BlockType, DataBlockEncoding) Dereferenced at HFileReaderImpl.java:traceScope in org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.readBlock(long, long, boolean, boolean, boolean, boolean, BlockType, DataBlockEncoding) Dereferenced at HFileReaderImpl.java:[line 1509]
          Failed junit tests hadoop.hbase.client.TestClientScanner
            hadoop.hbase.client.TestClientNoCluster
            hadoop.hbase.client.TestIntraRowPagination
            hadoop.hbase.regionserver.TestDateTieredCompactionPolicy
            hadoop.hbase.regionserver.TestMinVersions
            hadoop.hbase.regionserver.wal.TestWALActionsListener
            hadoop.hbase.io.hfile.TestSeekTo
            hadoop.hbase.regionserver.TestHRegionInfo
            hadoop.hbase.filter.TestInvocationRecordFilter
            hadoop.hbase.ipc.TestNettyRpcServer
            hadoop.hbase.io.hfile.TestPrefetch
            hadoop.hbase.io.encoding.TestPrefixTree
            hadoop.hbase.io.hfile.TestHFileInlineToRootChunkConversion
            hadoop.hbase.regionserver.TestHStoreFile
            hadoop.hbase.io.hfile.TestScannerSelectionUsingKeyRange
            hadoop.hbase.filter.TestMultipleColumnPrefixFilter
            hadoop.hbase.regionserver.TestResettingCounters
            hadoop.hbase.regionserver.TestScanWithBloomError
            hadoop.hbase.procedure.TestProcedureManager
            hadoop.hbase.regionserver.TestWALMonotonicallyIncreasingSeqId
            hadoop.hbase.master.locking.TestLockManager
            hadoop.hbase.regionserver.TestStoreFileScannerWithTagCompression
            hadoop.hbase.filter.TestFilterFromRegionSide
            hadoop.hbase.mob.TestMobFile
            hadoop.hbase.regionserver.TestWideScanner
            hadoop.hbase.io.hfile.TestReseekTo
            hadoop.hbase.filter.TestColumnPrefixFilter
            hadoop.hbase.regionserver.TestDefaultCompactSelection
            hadoop.hbase.master.locking.TestLockProcedure
            hadoop.hbase.wal.TestWALMethods
            hadoop.hbase.mob.TestCachedMobFile
            hadoop.hbase.regionserver.TestStoreFileRefresherChore
            hadoop.hbase.io.TestHalfStoreFileReader
            hadoop.hbase.executor.TestExecutorService
            hadoop.hbase.master.balancer.TestRegionLocationFinder
            hadoop.hbase.io.hfile.TestHFileEncryption
            hadoop.hbase.regionserver.TestBlocksScanned
            hadoop.hbase.filter.TestDependentColumnFilter
            hadoop.hbase.coprocessor.TestCoprocessorInterface
            hadoop.hbase.regionserver.TestDateTieredCompactionPolicyOverflow
            hadoop.hbase.regionserver.TestKeepDeletes
            hadoop.hbase.mob.TestMobFileCache
            hadoop.hbase.regionserver.TestHRegionFileSystem
            hadoop.hbase.regionserver.TestScanner
            hadoop.hbase.coprocessor.TestRegionObserverStacking
            hadoop.hbase.io.hfile.TestLazyDataBlockDecompression
            hadoop.hbase.io.encoding.TestSeekBeforeWithReverseScan
            hadoop.hbase.io.hfile.TestHFile
            hadoop.hbase.filter.TestFilter
            hadoop.hbase.mapreduce.TestTableInputFormat
            hadoop.hbase.mapreduce.TestCellCounter
            hadoop.hbase.mapreduce.TestImportTsv
            hadoop.hbase.mapreduce.TestTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestTableMapReduce
            hadoop.hbase.mapred.TestTableMapReduceUtil
            hadoop.hbase.mapred.TestTableOutputFormatConnectionExhaust
            hadoop.hbase.mapreduce.TestTableInputFormatScan1
            hadoop.hbase.mapred.TestTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestHashTable
            hadoop.hbase.mapreduce.TestTableInputFormatScan2
            hadoop.hbase.mapreduce.TestHFileOutputFormat2
            hadoop.hbase.mapreduce.TestHRegionPartitioner
            hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes
            hadoop.hbase.mapreduce.TestImportTSVWithTTLs
            hadoop.hbase.mapred.TestMultiTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestWALRecordReader
            hadoop.hbase.mapreduce.TestSyncTable
            hadoop.hbase.mapreduce.TestMultiTableInputFormat
            hadoop.hbase.mapred.TestTableMapReduce
            hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestWALPlayer
            hadoop.hbase.mapreduce.TestRowCounter
            hadoop.hbase.replication.TestReplicationSmallTests
            hadoop.hbase.mapreduce.TestCopyTable
            hadoop.hbase.mapreduce.TestTimeRangeMapRed
            hadoop.hbase.mapreduce.TestMultithreadedTableMapper
            hadoop.hbase.mapreduce.TestImportExport
            hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels
            hadoop.hbase.mapred.TestTableInputFormat
            hadoop.hbase.thrift.TestThriftHttpServer
            hadoop.hbase.thrift.TestThriftServerCmdLine
            hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
            hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels
            hadoop.hbase.thrift.TestThriftServer
            hadoop.hbase.client.TestShell
            hadoop.hbase.client.TestReplicationShell
            hadoop.hbase.coprocessor.TestRowProcessorEndpoint
            hadoop.hbase.coprocessor.TestCoprocessorTableEndpoint
            hadoop.hbase.regionserver.TestServerCustomProtocol
            hadoop.hbase.coprocessor.TestAsyncCoprocessorEndpoint
            hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint
            hadoop.hbase.coprocessor.TestClassLoading
            hadoop.hbase.coprocessor.TestImportExport
            hadoop.hbase.coprocessor.TestSecureExport
            hadoop.hbase.client.TestRpcControllerFactory
            hadoop.hbase.coprocessor.TestCoprocessorEndpoint
            hadoop.hbase.replication.TestReplicationSyncUpToolWithBulkLoadedData
            hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint
            hadoop.hbase.client.TestAsyncAggregationClient
            hadoop.hbase.backup.TestBackupHFileCleaner
            hadoop.hbase.client.example.TestHttpProxyExample
            hadoop.hbase.client.example.TestAsyncClientExample
            hadoop.hbase.coprocessor.example.TestRefreshHFilesEndpoint
            hadoop.hbase.rest.TestNamespacesResource
            hadoop.hbase.rest.TestScannersWithLabels
            hadoop.hbase.rest.TestGzipFilter
            hadoop.hbase.rest.TestMultiRowResource
            hadoop.hbase.rest.TestTableResource
            hadoop.hbase.rest.TestVersionResource
            hadoop.hbase.rest.TestStatusResource
            hadoop.hbase.rest.TestSchemaResource
            hadoop.hbase.rest.TestResourceFilter
            hadoop.hbase.rest.TestGetAndPutResource
            hadoop.hbase.rest.TestDeleteRow
            hadoop.hbase.rest.TestTableScan
            hadoop.hbase.rest.client.TestRemoteTable
            hadoop.hbase.rest.TestScannerResource
            hadoop.hbase.rest.TestScannersWithFilters
            hadoop.hbase.rest.TestNamespacesInstanceResource
            hadoop.hbase.mapreduce.TestTableInputFormat
            hadoop.hbase.mapreduce.TestCellCounter
            hadoop.hbase.mapreduce.TestImportTsv
            hadoop.hbase.mapreduce.TestTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestTableMapReduce
            hadoop.hbase.mapred.TestTableMapReduceUtil
            hadoop.hbase.mapred.TestTableOutputFormatConnectionExhaust
            hadoop.hbase.mapreduce.TestTableInputFormatScan1
            hadoop.hbase.mapred.TestTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestHashTable
            hadoop.hbase.mapreduce.TestTableInputFormatScan2
            hadoop.hbase.mapreduce.TestHFileOutputFormat2
            hadoop.hbase.mapreduce.TestHRegionPartitioner
            hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes
            hadoop.hbase.mapreduce.TestImportTSVWithTTLs
            hadoop.hbase.mapred.TestMultiTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestWALRecordReader
            hadoop.hbase.mapreduce.TestSyncTable
            hadoop.hbase.mapreduce.TestMultiTableInputFormat
            hadoop.hbase.mapred.TestTableMapReduce
            hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestWALPlayer
            hadoop.hbase.mapreduce.TestRowCounter
            hadoop.hbase.replication.TestReplicationSmallTests
            hadoop.hbase.mapreduce.TestCopyTable
            hadoop.hbase.mapreduce.TestTimeRangeMapRed
            hadoop.hbase.mapreduce.TestMultithreadedTableMapper
            hadoop.hbase.mapreduce.TestImportExport
            hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels
            hadoop.hbase.mapred.TestTableInputFormat
            hadoop.hbase.thrift.TestThriftHttpServer
            hadoop.hbase.thrift.TestThriftServerCmdLine
            hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
            hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels
            hadoop.hbase.thrift.TestThriftServer
            hadoop.hbase.client.TestIntraRowPagination
            hadoop.hbase.regionserver.TestDateTieredCompactionPolicy
            hadoop.hbase.regionserver.TestMinVersions
            hadoop.hbase.regionserver.wal.TestWALActionsListener
            hadoop.hbase.io.hfile.TestSeekTo
            hadoop.hbase.regionserver.TestHRegionInfo
            hadoop.hbase.filter.TestInvocationRecordFilter
            hadoop.hbase.ipc.TestNettyRpcServer
            hadoop.hbase.io.hfile.TestPrefetch
            hadoop.hbase.io.encoding.TestPrefixTree
            hadoop.hbase.io.hfile.TestHFileInlineToRootChunkConversion
            hadoop.hbase.regionserver.TestHStoreFile
            hadoop.hbase.io.hfile.TestScannerSelectionUsingKeyRange
            hadoop.hbase.filter.TestMultipleColumnPrefixFilter
            hadoop.hbase.regionserver.TestResettingCounters
            hadoop.hbase.regionserver.TestScanWithBloomError
            hadoop.hbase.procedure.TestProcedureManager
            hadoop.hbase.regionserver.TestWALMonotonicallyIncreasingSeqId
            hadoop.hbase.master.locking.TestLockManager
            hadoop.hbase.regionserver.TestStoreFileScannerWithTagCompression
            hadoop.hbase.filter.TestFilterFromRegionSide
            hadoop.hbase.mob.TestMobFile
            hadoop.hbase.regionserver.TestWideScanner
            hadoop.hbase.io.hfile.TestReseekTo
            hadoop.hbase.filter.TestColumnPrefixFilter
            hadoop.hbase.regionserver.TestDefaultCompactSelection
            hadoop.hbase.master.locking.TestLockProcedure
            hadoop.hbase.wal.TestWALMethods
            hadoop.hbase.mob.TestCachedMobFile
            hadoop.hbase.regionserver.TestStoreFileRefresherChore
            hadoop.hbase.io.TestHalfStoreFileReader
            hadoop.hbase.executor.TestExecutorService
            hadoop.hbase.master.balancer.TestRegionLocationFinder
            hadoop.hbase.io.hfile.TestHFileEncryption
            hadoop.hbase.regionserver.TestBlocksScanned
            hadoop.hbase.filter.TestDependentColumnFilter
            hadoop.hbase.coprocessor.TestCoprocessorInterface
            hadoop.hbase.regionserver.TestDateTieredCompactionPolicyOverflow
            hadoop.hbase.regionserver.TestKeepDeletes
            hadoop.hbase.mob.TestMobFileCache
            hadoop.hbase.regionserver.TestHRegionFileSystem
            hadoop.hbase.regionserver.TestScanner
            hadoop.hbase.coprocessor.TestRegionObserverStacking
            hadoop.hbase.io.hfile.TestLazyDataBlockDecompression
            hadoop.hbase.io.encoding.TestSeekBeforeWithReverseScan
            hadoop.hbase.io.hfile.TestHFile
            hadoop.hbase.filter.TestFilter
            hadoop.hbase.coprocessor.TestRowProcessorEndpoint
            hadoop.hbase.coprocessor.TestCoprocessorTableEndpoint
            hadoop.hbase.regionserver.TestServerCustomProtocol
            hadoop.hbase.coprocessor.TestAsyncCoprocessorEndpoint
            hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint
            hadoop.hbase.coprocessor.TestClassLoading
            hadoop.hbase.coprocessor.TestImportExport
            hadoop.hbase.coprocessor.TestSecureExport
            hadoop.hbase.client.TestRpcControllerFactory
            hadoop.hbase.coprocessor.TestCoprocessorEndpoint
            hadoop.hbase.replication.TestReplicationSyncUpToolWithBulkLoadedData
            hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint
            hadoop.hbase.client.TestAsyncAggregationClient
            hadoop.hbase.backup.TestBackupHFileCleaner
            hadoop.hbase.client.TestClientScanner
            hadoop.hbase.client.TestClientNoCluster
            hadoop.hbase.client.TestShell
            hadoop.hbase.client.TestReplicationShell
            hadoop.hbase.client.example.TestHttpProxyExample
            hadoop.hbase.client.example.TestAsyncClientExample
            hadoop.hbase.coprocessor.example.TestRefreshHFilesEndpoint
            hadoop.hbase.rest.TestNamespacesResource
            hadoop.hbase.rest.TestScannersWithLabels
            hadoop.hbase.rest.TestGzipFilter
            hadoop.hbase.rest.TestMultiRowResource
            hadoop.hbase.rest.TestTableResource
            hadoop.hbase.rest.TestVersionResource
            hadoop.hbase.rest.TestStatusResource
            hadoop.hbase.rest.TestSchemaResource
            hadoop.hbase.rest.TestResourceFilter
            hadoop.hbase.rest.TestGetAndPutResource
            hadoop.hbase.rest.TestDeleteRow
            hadoop.hbase.rest.TestTableScan
            hadoop.hbase.rest.client.TestRemoteTable
            hadoop.hbase.rest.TestScannerResource
            hadoop.hbase.rest.TestScannersWithFilters
            hadoop.hbase.rest.TestNamespacesInstanceResource



          Subsystem Report/Notes
          Docker Client=1.13.1 Server=1.13.1 Image:yetus/hbase:5d60123
          JIRA Issue HBASE-18601
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886916/HBASE-18601.master.002.patch
          Optional Tests asflicense shadedjars javac javadoc unit xml compile findbugs hadoopcheck hbaseanti checkstyle rubocop ruby_lint
          uname Linux 48982fc1103a 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 5d6b20a
          Default Java 1.8.0_144
          findbugs v3.1.0-RC3
          mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-mvninstall-hbase-rest.txt
          mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-mvninstall-hbase-spark.txt
          rubocop v0.49.1
          ruby-lint v2.3.1
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/new-findbugs-hbase-server.html
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-unit-hbase-client.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-unit-hbase-server.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-unit-hbase-mapreduce.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-unit-hbase-thrift.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-unit-hbase-shell.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-unit-hbase-endpoint.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-unit-hbase-backup.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-unit-hbase-examples.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-unit-hbase-rest.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-unit-hbase-spark.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-unit-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8615/testReport/
          modules C: hbase-protocol-shaded hbase-common hbase-hadoop2-compat hbase-client hbase-replication hbase-prefix-tree hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-backup hbase-it hbase-examples hbase-rest hbase-external-blockcache hbase-spark . U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8615/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 20m 34s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 6 new or modified test files. 0 mvndep 0m 47s Maven dependency ordering for branch +1 mvninstall 4m 29s master passed +1 compile 10m 41s master passed +1 checkstyle 3m 5s master passed +1 mvneclipse 7m 1s master passed +1 shadedjars 4m 33s branch has no errors when building our shaded downstream artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-testing-util . +1 findbugs 13m 52s master passed +1 javadoc 7m 34s master passed 0 mvndep 0m 20s Maven dependency ordering for patch -1 mvninstall 0m 14s hbase-rest in the patch failed. -1 mvninstall 0m 34s hbase-spark in the patch failed. +1 compile 9m 25s the patch passed +1 javac 9m 25s the patch passed +1 checkstyle 2m 43s the patch passed +1 mvneclipse 6m 25s the patch passed +1 rubocop 0m 3s There were no new rubocop issues. +1 ruby-lint 0m 1s There were no new ruby-lint issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 26s The patch has no ill-formed XML file. +1 shadedjars 4m 24s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 37m 34s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. 0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-testing-util . -1 findbugs 2m 24s hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 6m 56s the patch passed +1 unit 0m 27s hbase-protocol-shaded in the patch passed. +1 unit 2m 26s hbase-common in the patch passed. +1 unit 0m 30s hbase-hadoop2-compat in the patch passed. -1 unit 1m 31s hbase-client in the patch failed. +1 unit 0m 11s hbase-replication in the patch passed. +1 unit 0m 28s hbase-prefix-tree in the patch passed. +1 unit 3m 9s hbase-procedure in the patch passed. -1 unit 19m 42s hbase-server in the patch failed. -1 unit 21m 57s hbase-mapreduce in the patch failed. +1 unit 0m 15s hbase-testing-util in the patch passed. -1 unit 0m 38s hbase-thrift in the patch failed. +1 unit 0m 25s hbase-rsgroup in the patch passed. -1 unit 0m 46s hbase-shell in the patch failed. -1 unit 1m 15s hbase-endpoint in the patch failed. -1 unit 0m 48s hbase-backup in the patch failed. +1 unit 0m 22s hbase-it in the patch passed. -1 unit 0m 36s hbase-examples in the patch failed. -1 unit 21m 11s hbase-rest in the patch failed. +1 unit 0m 15s hbase-external-blockcache in the patch passed. -1 unit 1m 18s hbase-spark in the patch failed. -1 unit 8m 28s root in the patch failed. +1 asflicense 3m 17s The patch does not generate ASF License warnings. 253m 36s Reason Tests FindBugs module:hbase-server   Possible null pointer dereference of traceScope in org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.readBlock(long, long, boolean, boolean, boolean, boolean, BlockType, DataBlockEncoding) Dereferenced at HFileReaderImpl.java:traceScope in org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.readBlock(long, long, boolean, boolean, boolean, boolean, BlockType, DataBlockEncoding) Dereferenced at HFileReaderImpl.java: [line 1509] Failed junit tests hadoop.hbase.client.TestClientScanner   hadoop.hbase.client.TestClientNoCluster   hadoop.hbase.client.TestIntraRowPagination   hadoop.hbase.regionserver.TestDateTieredCompactionPolicy   hadoop.hbase.regionserver.TestMinVersions   hadoop.hbase.regionserver.wal.TestWALActionsListener   hadoop.hbase.io.hfile.TestSeekTo   hadoop.hbase.regionserver.TestHRegionInfo   hadoop.hbase.filter.TestInvocationRecordFilter   hadoop.hbase.ipc.TestNettyRpcServer   hadoop.hbase.io.hfile.TestPrefetch   hadoop.hbase.io.encoding.TestPrefixTree   hadoop.hbase.io.hfile.TestHFileInlineToRootChunkConversion   hadoop.hbase.regionserver.TestHStoreFile   hadoop.hbase.io.hfile.TestScannerSelectionUsingKeyRange   hadoop.hbase.filter.TestMultipleColumnPrefixFilter   hadoop.hbase.regionserver.TestResettingCounters   hadoop.hbase.regionserver.TestScanWithBloomError   hadoop.hbase.procedure.TestProcedureManager   hadoop.hbase.regionserver.TestWALMonotonicallyIncreasingSeqId   hadoop.hbase.master.locking.TestLockManager   hadoop.hbase.regionserver.TestStoreFileScannerWithTagCompression   hadoop.hbase.filter.TestFilterFromRegionSide   hadoop.hbase.mob.TestMobFile   hadoop.hbase.regionserver.TestWideScanner   hadoop.hbase.io.hfile.TestReseekTo   hadoop.hbase.filter.TestColumnPrefixFilter   hadoop.hbase.regionserver.TestDefaultCompactSelection   hadoop.hbase.master.locking.TestLockProcedure   hadoop.hbase.wal.TestWALMethods   hadoop.hbase.mob.TestCachedMobFile   hadoop.hbase.regionserver.TestStoreFileRefresherChore   hadoop.hbase.io.TestHalfStoreFileReader   hadoop.hbase.executor.TestExecutorService   hadoop.hbase.master.balancer.TestRegionLocationFinder   hadoop.hbase.io.hfile.TestHFileEncryption   hadoop.hbase.regionserver.TestBlocksScanned   hadoop.hbase.filter.TestDependentColumnFilter   hadoop.hbase.coprocessor.TestCoprocessorInterface   hadoop.hbase.regionserver.TestDateTieredCompactionPolicyOverflow   hadoop.hbase.regionserver.TestKeepDeletes   hadoop.hbase.mob.TestMobFileCache   hadoop.hbase.regionserver.TestHRegionFileSystem   hadoop.hbase.regionserver.TestScanner   hadoop.hbase.coprocessor.TestRegionObserverStacking   hadoop.hbase.io.hfile.TestLazyDataBlockDecompression   hadoop.hbase.io.encoding.TestSeekBeforeWithReverseScan   hadoop.hbase.io.hfile.TestHFile   hadoop.hbase.filter.TestFilter   hadoop.hbase.mapreduce.TestTableInputFormat   hadoop.hbase.mapreduce.TestCellCounter   hadoop.hbase.mapreduce.TestImportTsv   hadoop.hbase.mapreduce.TestTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestTableMapReduce   hadoop.hbase.mapred.TestTableMapReduceUtil   hadoop.hbase.mapred.TestTableOutputFormatConnectionExhaust   hadoop.hbase.mapreduce.TestTableInputFormatScan1   hadoop.hbase.mapred.TestTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestHashTable   hadoop.hbase.mapreduce.TestTableInputFormatScan2   hadoop.hbase.mapreduce.TestHFileOutputFormat2   hadoop.hbase.mapreduce.TestHRegionPartitioner   hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes   hadoop.hbase.mapreduce.TestImportTSVWithTTLs   hadoop.hbase.mapred.TestMultiTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestWALRecordReader   hadoop.hbase.mapreduce.TestSyncTable   hadoop.hbase.mapreduce.TestMultiTableInputFormat   hadoop.hbase.mapred.TestTableMapReduce   hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestWALPlayer   hadoop.hbase.mapreduce.TestRowCounter   hadoop.hbase.replication.TestReplicationSmallTests   hadoop.hbase.mapreduce.TestCopyTable   hadoop.hbase.mapreduce.TestTimeRangeMapRed   hadoop.hbase.mapreduce.TestMultithreadedTableMapper   hadoop.hbase.mapreduce.TestImportExport   hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels   hadoop.hbase.mapred.TestTableInputFormat   hadoop.hbase.thrift.TestThriftHttpServer   hadoop.hbase.thrift.TestThriftServerCmdLine   hadoop.hbase.thrift2.TestThriftHBaseServiceHandler   hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels   hadoop.hbase.thrift.TestThriftServer   hadoop.hbase.client.TestShell   hadoop.hbase.client.TestReplicationShell   hadoop.hbase.coprocessor.TestRowProcessorEndpoint   hadoop.hbase.coprocessor.TestCoprocessorTableEndpoint   hadoop.hbase.regionserver.TestServerCustomProtocol   hadoop.hbase.coprocessor.TestAsyncCoprocessorEndpoint   hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint   hadoop.hbase.coprocessor.TestClassLoading   hadoop.hbase.coprocessor.TestImportExport   hadoop.hbase.coprocessor.TestSecureExport   hadoop.hbase.client.TestRpcControllerFactory   hadoop.hbase.coprocessor.TestCoprocessorEndpoint   hadoop.hbase.replication.TestReplicationSyncUpToolWithBulkLoadedData   hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint   hadoop.hbase.client.TestAsyncAggregationClient   hadoop.hbase.backup.TestBackupHFileCleaner   hadoop.hbase.client.example.TestHttpProxyExample   hadoop.hbase.client.example.TestAsyncClientExample   hadoop.hbase.coprocessor.example.TestRefreshHFilesEndpoint   hadoop.hbase.rest.TestNamespacesResource   hadoop.hbase.rest.TestScannersWithLabels   hadoop.hbase.rest.TestGzipFilter   hadoop.hbase.rest.TestMultiRowResource   hadoop.hbase.rest.TestTableResource   hadoop.hbase.rest.TestVersionResource   hadoop.hbase.rest.TestStatusResource   hadoop.hbase.rest.TestSchemaResource   hadoop.hbase.rest.TestResourceFilter   hadoop.hbase.rest.TestGetAndPutResource   hadoop.hbase.rest.TestDeleteRow   hadoop.hbase.rest.TestTableScan   hadoop.hbase.rest.client.TestRemoteTable   hadoop.hbase.rest.TestScannerResource   hadoop.hbase.rest.TestScannersWithFilters   hadoop.hbase.rest.TestNamespacesInstanceResource   hadoop.hbase.mapreduce.TestTableInputFormat   hadoop.hbase.mapreduce.TestCellCounter   hadoop.hbase.mapreduce.TestImportTsv   hadoop.hbase.mapreduce.TestTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestTableMapReduce   hadoop.hbase.mapred.TestTableMapReduceUtil   hadoop.hbase.mapred.TestTableOutputFormatConnectionExhaust   hadoop.hbase.mapreduce.TestTableInputFormatScan1   hadoop.hbase.mapred.TestTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestHashTable   hadoop.hbase.mapreduce.TestTableInputFormatScan2   hadoop.hbase.mapreduce.TestHFileOutputFormat2   hadoop.hbase.mapreduce.TestHRegionPartitioner   hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes   hadoop.hbase.mapreduce.TestImportTSVWithTTLs   hadoop.hbase.mapred.TestMultiTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestWALRecordReader   hadoop.hbase.mapreduce.TestSyncTable   hadoop.hbase.mapreduce.TestMultiTableInputFormat   hadoop.hbase.mapred.TestTableMapReduce   hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestWALPlayer   hadoop.hbase.mapreduce.TestRowCounter   hadoop.hbase.replication.TestReplicationSmallTests   hadoop.hbase.mapreduce.TestCopyTable   hadoop.hbase.mapreduce.TestTimeRangeMapRed   hadoop.hbase.mapreduce.TestMultithreadedTableMapper   hadoop.hbase.mapreduce.TestImportExport   hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels   hadoop.hbase.mapred.TestTableInputFormat   hadoop.hbase.thrift.TestThriftHttpServer   hadoop.hbase.thrift.TestThriftServerCmdLine   hadoop.hbase.thrift2.TestThriftHBaseServiceHandler   hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels   hadoop.hbase.thrift.TestThriftServer   hadoop.hbase.client.TestIntraRowPagination   hadoop.hbase.regionserver.TestDateTieredCompactionPolicy   hadoop.hbase.regionserver.TestMinVersions   hadoop.hbase.regionserver.wal.TestWALActionsListener   hadoop.hbase.io.hfile.TestSeekTo   hadoop.hbase.regionserver.TestHRegionInfo   hadoop.hbase.filter.TestInvocationRecordFilter   hadoop.hbase.ipc.TestNettyRpcServer   hadoop.hbase.io.hfile.TestPrefetch   hadoop.hbase.io.encoding.TestPrefixTree   hadoop.hbase.io.hfile.TestHFileInlineToRootChunkConversion   hadoop.hbase.regionserver.TestHStoreFile   hadoop.hbase.io.hfile.TestScannerSelectionUsingKeyRange   hadoop.hbase.filter.TestMultipleColumnPrefixFilter   hadoop.hbase.regionserver.TestResettingCounters   hadoop.hbase.regionserver.TestScanWithBloomError   hadoop.hbase.procedure.TestProcedureManager   hadoop.hbase.regionserver.TestWALMonotonicallyIncreasingSeqId   hadoop.hbase.master.locking.TestLockManager   hadoop.hbase.regionserver.TestStoreFileScannerWithTagCompression   hadoop.hbase.filter.TestFilterFromRegionSide   hadoop.hbase.mob.TestMobFile   hadoop.hbase.regionserver.TestWideScanner   hadoop.hbase.io.hfile.TestReseekTo   hadoop.hbase.filter.TestColumnPrefixFilter   hadoop.hbase.regionserver.TestDefaultCompactSelection   hadoop.hbase.master.locking.TestLockProcedure   hadoop.hbase.wal.TestWALMethods   hadoop.hbase.mob.TestCachedMobFile   hadoop.hbase.regionserver.TestStoreFileRefresherChore   hadoop.hbase.io.TestHalfStoreFileReader   hadoop.hbase.executor.TestExecutorService   hadoop.hbase.master.balancer.TestRegionLocationFinder   hadoop.hbase.io.hfile.TestHFileEncryption   hadoop.hbase.regionserver.TestBlocksScanned   hadoop.hbase.filter.TestDependentColumnFilter   hadoop.hbase.coprocessor.TestCoprocessorInterface   hadoop.hbase.regionserver.TestDateTieredCompactionPolicyOverflow   hadoop.hbase.regionserver.TestKeepDeletes   hadoop.hbase.mob.TestMobFileCache   hadoop.hbase.regionserver.TestHRegionFileSystem   hadoop.hbase.regionserver.TestScanner   hadoop.hbase.coprocessor.TestRegionObserverStacking   hadoop.hbase.io.hfile.TestLazyDataBlockDecompression   hadoop.hbase.io.encoding.TestSeekBeforeWithReverseScan   hadoop.hbase.io.hfile.TestHFile   hadoop.hbase.filter.TestFilter   hadoop.hbase.coprocessor.TestRowProcessorEndpoint   hadoop.hbase.coprocessor.TestCoprocessorTableEndpoint   hadoop.hbase.regionserver.TestServerCustomProtocol   hadoop.hbase.coprocessor.TestAsyncCoprocessorEndpoint   hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint   hadoop.hbase.coprocessor.TestClassLoading   hadoop.hbase.coprocessor.TestImportExport   hadoop.hbase.coprocessor.TestSecureExport   hadoop.hbase.client.TestRpcControllerFactory   hadoop.hbase.coprocessor.TestCoprocessorEndpoint   hadoop.hbase.replication.TestReplicationSyncUpToolWithBulkLoadedData   hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint   hadoop.hbase.client.TestAsyncAggregationClient   hadoop.hbase.backup.TestBackupHFileCleaner   hadoop.hbase.client.TestClientScanner   hadoop.hbase.client.TestClientNoCluster   hadoop.hbase.client.TestShell   hadoop.hbase.client.TestReplicationShell   hadoop.hbase.client.example.TestHttpProxyExample   hadoop.hbase.client.example.TestAsyncClientExample   hadoop.hbase.coprocessor.example.TestRefreshHFilesEndpoint   hadoop.hbase.rest.TestNamespacesResource   hadoop.hbase.rest.TestScannersWithLabels   hadoop.hbase.rest.TestGzipFilter   hadoop.hbase.rest.TestMultiRowResource   hadoop.hbase.rest.TestTableResource   hadoop.hbase.rest.TestVersionResource   hadoop.hbase.rest.TestStatusResource   hadoop.hbase.rest.TestSchemaResource   hadoop.hbase.rest.TestResourceFilter   hadoop.hbase.rest.TestGetAndPutResource   hadoop.hbase.rest.TestDeleteRow   hadoop.hbase.rest.TestTableScan   hadoop.hbase.rest.client.TestRemoteTable   hadoop.hbase.rest.TestScannerResource   hadoop.hbase.rest.TestScannersWithFilters   hadoop.hbase.rest.TestNamespacesInstanceResource Subsystem Report/Notes Docker Client=1.13.1 Server=1.13.1 Image:yetus/hbase:5d60123 JIRA Issue HBASE-18601 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886916/HBASE-18601.master.002.patch Optional Tests asflicense shadedjars javac javadoc unit xml compile findbugs hadoopcheck hbaseanti checkstyle rubocop ruby_lint uname Linux 48982fc1103a 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 5d6b20a Default Java 1.8.0_144 findbugs v3.1.0-RC3 mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-mvninstall-hbase-rest.txt mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-mvninstall-hbase-spark.txt rubocop v0.49.1 ruby-lint v2.3.1 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/new-findbugs-hbase-server.html unit https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-unit-hbase-client.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-unit-hbase-server.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-unit-hbase-mapreduce.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-unit-hbase-thrift.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-unit-hbase-shell.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-unit-hbase-endpoint.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-unit-hbase-backup.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-unit-hbase-examples.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-unit-hbase-rest.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-unit-hbase-spark.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8615/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8615/testReport/ modules C: hbase-protocol-shaded hbase-common hbase-hadoop2-compat hbase-client hbase-replication hbase-prefix-tree hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-backup hbase-it hbase-examples hbase-rest hbase-external-blockcache hbase-spark . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8615/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          stack stack added a comment -

          Tamas Penzes The findbugs looks legit and the first test I tried failed locally for me; does it fail for you sir?

          On the patch:

          The exclusions of old htrace seem like a good idea.

          Man, looking at all the null checks reminds me of how the htrace API needs a bit of work...

          But patch seems fine sir. We can do hookup in a follow-on.

          Show
          stack stack added a comment - Tamas Penzes The findbugs looks legit and the first test I tried failed locally for me; does it fail for you sir? On the patch: The exclusions of old htrace seem like a good idea. Man, looking at all the null checks reminds me of how the htrace API needs a bit of work... But patch seems fine sir. We can do hookup in a follow-on.
          Hide
          mdrob Mike Drob added a comment -

          Do we need null checks in IntegrationTestSendTraceRequests

          We could probably refactor stuff out to have a createTrace method so that the null checks are consolidated?

          Something like...

          class TraceUtil {
            TraceScope createTrace(String description) {
              Tracer tracer = Tracer.curThreadTracer();
              return (tracer == null) ? null : tracer.newScope(description);
            }
          }
          

          Then we can do try-with-resources in lots of places:

          try (TraceScope scope = TraceUtil.createTrace("action")) {
            // process
          }
          

          because that will correctly handle null resource returned for when it is time to close it.

          Even if we don't use try blocks, it's still less change and cruft inline right now. I understand this is largely mechanical changes, but I don't want to create more work for us down the line since we know this will be changing again soon.

          We're dropping all tracing from IPC? Is that correct? Let's file a JIRA for improving the tracing story that we can have as a follow up to this and record notes like this in there. Maybe it will be a good GSOC project for somebody?

          In AbstractFSWAL, I don't think we should be calling detach, should we? That seems problematic. It was there before already, this is another thing that gets fixed by try-blocks... that might be too much work for this pass though.

          What do you think we should do with all your TODO notes about the API changes?

          Show
          mdrob Mike Drob added a comment - Do we need null checks in IntegrationTestSendTraceRequests We could probably refactor stuff out to have a createTrace method so that the null checks are consolidated? Something like... class TraceUtil { TraceScope createTrace( String description) { Tracer tracer = Tracer.curThreadTracer(); return (tracer == null ) ? null : tracer.newScope(description); } } Then we can do try-with-resources in lots of places: try (TraceScope scope = TraceUtil.createTrace( "action" )) { // process } because that will correctly handle null resource returned for when it is time to close it. Even if we don't use try blocks, it's still less change and cruft inline right now. I understand this is largely mechanical changes, but I don't want to create more work for us down the line since we know this will be changing again soon. We're dropping all tracing from IPC? Is that correct? Let's file a JIRA for improving the tracing story that we can have as a follow up to this and record notes like this in there. Maybe it will be a good GSOC project for somebody? In AbstractFSWAL, I don't think we should be calling detach, should we? That seems problematic. It was there before already, this is another thing that gets fixed by try-blocks... that might be too much work for this pass though. What do you think we should do with all your TODO notes about the API changes?
          Hide
          stack stack added a comment -

          Yeah, the null-checks are a pain. Its a condemnation of current API. I like your TraceUtil suggestion Mike Drob

          Show
          stack stack added a comment - Yeah, the null-checks are a pain. Its a condemnation of current API. I like your TraceUtil suggestion Mike Drob
          Hide
          tamaas Tamas Penzes added a comment -

          Yeah, Mike Drob, we have also talked about using a wrapper class yesterday, but then my patch was already done.
          But this way the replacement of the tracing might be easy later too.

          Show
          tamaas Tamas Penzes added a comment - Yeah, Mike Drob , we have also talked about using a wrapper class yesterday, but then my patch was already done. But this way the replacement of the tracing might be easy later too.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 29s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 6 new or modified test files.
          0 mvndep 0m 36s Maven dependency ordering for branch
          +1 mvninstall 3m 30s master passed
          +1 compile 9m 14s master passed
          +1 checkstyle 3m 9s master passed
          +1 mvneclipse 6m 22s master passed
          +1 shadedjars 3m 32s branch has no errors when building our shaded downstream artifacts.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-testing-util .
          +1 findbugs 11m 29s master passed
          +1 javadoc 6m 58s master passed
          0 mvndep 0m 15s Maven dependency ordering for patch
          -1 mvninstall 0m 14s hbase-rest in the patch failed.
          -1 mvninstall 0m 31s hbase-spark in the patch failed.
          +1 compile 8m 46s the patch passed
          +1 javac 8m 46s the patch passed
          +1 checkstyle 2m 52s the patch passed
          +1 mvneclipse 5m 51s the patch passed
          +1 rubocop 0m 3s There were no new rubocop issues.
          +1 ruby-lint 0m 1s There were no new ruby-lint issues.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 28s The patch has no ill-formed XML file.
          +1 shadedjars 4m 1s patch has no errors when building our shaded downstream artifacts.
          -1 hadoopcheck 4m 54s The patch causes 16 errors with Hadoop v2.6.1.
          -1 hadoopcheck 5m 50s The patch causes 16 errors with Hadoop v2.6.2.
          -1 hadoopcheck 6m 43s The patch causes 16 errors with Hadoop v2.6.3.
          -1 hadoopcheck 7m 37s The patch causes 16 errors with Hadoop v2.6.4.
          -1 hadoopcheck 8m 32s The patch causes 16 errors with Hadoop v2.6.5.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-testing-util .
          -1 findbugs 0m 38s hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 6m 18s the patch passed
          +1 unit 0m 24s hbase-protocol-shaded in the patch passed.
          +1 unit 2m 23s hbase-common in the patch passed.
          +1 unit 0m 26s hbase-hadoop2-compat in the patch passed.
          -1 unit 1m 24s hbase-client in the patch failed.
          +1 unit 0m 9s hbase-replication in the patch passed.
          +1 unit 0m 24s hbase-prefix-tree in the patch passed.
          +1 unit 3m 1s hbase-procedure in the patch passed.
          -1 unit 19m 7s hbase-server in the patch failed.
          -1 unit 21m 4s hbase-mapreduce in the patch failed.
          +1 unit 0m 13s hbase-testing-util in the patch passed.
          -1 unit 0m 36s hbase-thrift in the patch failed.
          +1 unit 0m 24s hbase-rsgroup in the patch passed.
          -1 unit 0m 47s hbase-shell in the patch failed.
          -1 unit 1m 0s hbase-endpoint in the patch failed.
          -1 unit 0m 46s hbase-backup in the patch failed.
          +1 unit 0m 20s hbase-it in the patch passed.
          -1 unit 0m 34s hbase-examples in the patch failed.
          -1 unit 20m 54s hbase-rest in the patch failed.
          +1 unit 0m 12s hbase-external-blockcache in the patch passed.
          -1 unit 1m 3s hbase-spark in the patch failed.
          -1 unit 8m 10s root in the patch failed.
          +1 asflicense 3m 26s The patch does not generate ASF License warnings.
          204m 11s



          Reason Tests
          FindBugs module:hbase-common
            Possible null pointer dereference of null in org.apache.hadoop.hbase.trace.TraceUtil.addSampler(Sampler) Dereferenced at TraceUtil.java:null in org.apache.hadoop.hbase.trace.TraceUtil.addSampler(Sampler) Dereferenced at TraceUtil.java:[line 37]
          Failed junit tests hadoop.hbase.client.TestClientNoCluster
            hadoop.hbase.client.TestClientScanner
            hadoop.hbase.ipc.TestBlockingIPC
            hadoop.hbase.master.balancer.TestRegionLocationFinder
            hadoop.hbase.regionserver.TestWideScanner
            hadoop.hbase.coprocessor.TestCoprocessorInterface
            hadoop.hbase.procedure.TestProcedureManager
            hadoop.hbase.regionserver.TestMinVersions
            hadoop.hbase.filter.TestFilterFromRegionSide
            hadoop.hbase.io.encoding.TestPrefixTree
            hadoop.hbase.regionserver.TestScanWithBloomError
            hadoop.hbase.master.locking.TestLockProcedure
            hadoop.hbase.master.locking.TestLockManager
            hadoop.hbase.io.encoding.TestSeekBeforeWithReverseScan
            hadoop.hbase.regionserver.TestStoreFileRefresherChore
            hadoop.hbase.coprocessor.TestRegionObserverStacking
            hadoop.hbase.filter.TestFilter
            hadoop.hbase.executor.TestExecutorService
            hadoop.hbase.regionserver.TestResettingCounters
            hadoop.hbase.regionserver.TestScanner
            hadoop.hbase.regionserver.wal.TestWALActionsListener
            hadoop.hbase.io.hfile.TestHFile
            hadoop.hbase.filter.TestMultipleColumnPrefixFilter
            hadoop.hbase.filter.TestInvocationRecordFilter
            hadoop.hbase.filter.TestColumnPrefixFilter
            hadoop.hbase.io.hfile.TestScannerSelectionUsingKeyRange
            hadoop.hbase.regionserver.TestKeepDeletes
            hadoop.hbase.client.TestIntraRowPagination
            hadoop.hbase.regionserver.TestHRegionFileSystem
            hadoop.hbase.ipc.TestNettyRpcServer
            hadoop.hbase.io.TestHalfStoreFileReader
            hadoop.hbase.regionserver.TestBlocksScanned
            hadoop.hbase.filter.TestDependentColumnFilter
            hadoop.hbase.regionserver.TestHStoreFile
            hadoop.hbase.io.hfile.TestPrefetch
            hadoop.hbase.mapreduce.TestImportTSVWithTTLs
            hadoop.hbase.mapred.TestTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestTableInputFormat
            hadoop.hbase.mapreduce.TestImportTsv
            hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestTimeRangeMapRed
            hadoop.hbase.mapreduce.TestSyncTable
            hadoop.hbase.mapreduce.TestRowCounter
            hadoop.hbase.mapred.TestTableMapReduceUtil
            hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes
            hadoop.hbase.mapred.TestTableMapReduce
            hadoop.hbase.mapred.TestMultiTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestWALRecordReader
            hadoop.hbase.mapred.TestTableInputFormat
            hadoop.hbase.mapreduce.TestHRegionPartitioner
            hadoop.hbase.mapreduce.TestTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestCellCounter
            hadoop.hbase.mapred.TestTableOutputFormatConnectionExhaust
            hadoop.hbase.mapreduce.TestWALPlayer
            hadoop.hbase.mapreduce.TestMultiTableInputFormat
            hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels
            hadoop.hbase.mapreduce.TestHFileOutputFormat2
            hadoop.hbase.mapreduce.TestTableMapReduce
            hadoop.hbase.mapreduce.TestMultithreadedTableMapper
            hadoop.hbase.mapreduce.TestImportExport
            hadoop.hbase.mapreduce.TestCopyTable
            hadoop.hbase.mapreduce.TestTableInputFormatScan2
            hadoop.hbase.mapreduce.TestHashTable
            hadoop.hbase.mapreduce.TestTableInputFormatScan1
            hadoop.hbase.thrift.TestThriftHttpServer
            hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
            hadoop.hbase.thrift.TestThriftServer
            hadoop.hbase.thrift.TestThriftServerCmdLine
            hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels
            hadoop.hbase.client.TestReplicationShell
            hadoop.hbase.client.TestShell
            hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint
            hadoop.hbase.client.TestAsyncAggregationClient
            hadoop.hbase.regionserver.TestServerCustomProtocol
            hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint
            hadoop.hbase.replication.TestReplicationSyncUpToolWithBulkLoadedData
            hadoop.hbase.coprocessor.TestImportExport
            hadoop.hbase.coprocessor.TestAsyncCoprocessorEndpoint
            hadoop.hbase.coprocessor.TestCoprocessorEndpoint
            hadoop.hbase.coprocessor.TestRowProcessorEndpoint
            hadoop.hbase.coprocessor.TestSecureExport
            hadoop.hbase.coprocessor.TestClassLoading
            hadoop.hbase.coprocessor.TestCoprocessorTableEndpoint
            hadoop.hbase.client.TestRpcControllerFactory
            hadoop.hbase.backup.TestBackupHFileCleaner
            hadoop.hbase.client.example.TestHttpProxyExample
            hadoop.hbase.client.example.TestAsyncClientExample
            hadoop.hbase.coprocessor.example.TestRefreshHFilesEndpoint
            hadoop.hbase.rest.TestResourceFilter
            hadoop.hbase.rest.TestScannerResource
            hadoop.hbase.rest.client.TestRemoteTable
            hadoop.hbase.rest.TestMultiRowResource
            hadoop.hbase.rest.TestTableResource
            hadoop.hbase.rest.TestVersionResource
            hadoop.hbase.rest.TestDeleteRow
            hadoop.hbase.rest.TestNamespacesResource
            hadoop.hbase.rest.TestSchemaResource
            hadoop.hbase.rest.TestNamespacesInstanceResource
            hadoop.hbase.rest.TestStatusResource
            hadoop.hbase.rest.TestScannersWithLabels
            hadoop.hbase.rest.TestGetAndPutResource
            hadoop.hbase.rest.TestScannersWithFilters
            hadoop.hbase.rest.TestGzipFilter
            hadoop.hbase.rest.TestTableScan
            hadoop.hbase.client.TestClientNoCluster
            hadoop.hbase.client.TestClientScanner
            hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint
            hadoop.hbase.client.TestAsyncAggregationClient
            hadoop.hbase.regionserver.TestServerCustomProtocol
            hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint
            hadoop.hbase.replication.TestReplicationSyncUpToolWithBulkLoadedData
            hadoop.hbase.coprocessor.TestImportExport
            hadoop.hbase.coprocessor.TestAsyncCoprocessorEndpoint
            hadoop.hbase.coprocessor.TestCoprocessorEndpoint
            hadoop.hbase.coprocessor.TestRowProcessorEndpoint
            hadoop.hbase.coprocessor.TestSecureExport
            hadoop.hbase.coprocessor.TestClassLoading
            hadoop.hbase.coprocessor.TestCoprocessorTableEndpoint
            hadoop.hbase.client.TestRpcControllerFactory
            hadoop.hbase.rest.TestResourceFilter
            hadoop.hbase.rest.TestScannerResource
            hadoop.hbase.rest.client.TestRemoteTable
            hadoop.hbase.rest.TestMultiRowResource
            hadoop.hbase.rest.TestTableResource
            hadoop.hbase.rest.TestVersionResource
            hadoop.hbase.rest.TestDeleteRow
            hadoop.hbase.rest.TestNamespacesResource
            hadoop.hbase.rest.TestSchemaResource
            hadoop.hbase.rest.TestNamespacesInstanceResource
            hadoop.hbase.rest.TestStatusResource
            hadoop.hbase.rest.TestScannersWithLabels
            hadoop.hbase.rest.TestGetAndPutResource
            hadoop.hbase.rest.TestScannersWithFilters
            hadoop.hbase.rest.TestGzipFilter
            hadoop.hbase.rest.TestTableScan
            hadoop.hbase.client.example.TestHttpProxyExample
            hadoop.hbase.client.example.TestAsyncClientExample
            hadoop.hbase.coprocessor.example.TestRefreshHFilesEndpoint
            hadoop.hbase.mapreduce.TestImportTSVWithTTLs
            hadoop.hbase.mapred.TestTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestTableInputFormat
            hadoop.hbase.mapreduce.TestImportTsv
            hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestTimeRangeMapRed
            hadoop.hbase.mapreduce.TestSyncTable
            hadoop.hbase.mapreduce.TestRowCounter
            hadoop.hbase.mapred.TestTableMapReduceUtil
            hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes
            hadoop.hbase.mapred.TestTableMapReduce
            hadoop.hbase.mapred.TestMultiTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestWALRecordReader
            hadoop.hbase.mapred.TestTableInputFormat
            hadoop.hbase.mapreduce.TestHRegionPartitioner
            hadoop.hbase.mapreduce.TestTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestCellCounter
            hadoop.hbase.mapred.TestTableOutputFormatConnectionExhaust
            hadoop.hbase.mapreduce.TestWALPlayer
            hadoop.hbase.mapreduce.TestMultiTableInputFormat
            hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels
            hadoop.hbase.mapreduce.TestHFileOutputFormat2
            hadoop.hbase.mapreduce.TestTableMapReduce
            hadoop.hbase.mapreduce.TestMultithreadedTableMapper
            hadoop.hbase.mapreduce.TestImportExport
            hadoop.hbase.mapreduce.TestCopyTable
            hadoop.hbase.mapreduce.TestTableInputFormatScan2
            hadoop.hbase.mapreduce.TestHashTable
            hadoop.hbase.mapreduce.TestTableInputFormatScan1
            hadoop.hbase.ipc.TestBlockingIPC
            hadoop.hbase.master.balancer.TestRegionLocationFinder
            hadoop.hbase.regionserver.TestWideScanner
            hadoop.hbase.coprocessor.TestCoprocessorInterface
            hadoop.hbase.procedure.TestProcedureManager
            hadoop.hbase.regionserver.TestMinVersions
            hadoop.hbase.filter.TestFilterFromRegionSide
            hadoop.hbase.io.encoding.TestPrefixTree
            hadoop.hbase.regionserver.TestScanWithBloomError
            hadoop.hbase.master.locking.TestLockProcedure
            hadoop.hbase.master.locking.TestLockManager
            hadoop.hbase.io.encoding.TestSeekBeforeWithReverseScan
            hadoop.hbase.regionserver.TestStoreFileRefresherChore
            hadoop.hbase.coprocessor.TestRegionObserverStacking
            hadoop.hbase.filter.TestFilter
            hadoop.hbase.executor.TestExecutorService
            hadoop.hbase.regionserver.TestResettingCounters
            hadoop.hbase.regionserver.TestScanner
            hadoop.hbase.regionserver.wal.TestWALActionsListener
            hadoop.hbase.io.hfile.TestHFile
            hadoop.hbase.filter.TestMultipleColumnPrefixFilter
            hadoop.hbase.filter.TestInvocationRecordFilter
            hadoop.hbase.filter.TestColumnPrefixFilter
            hadoop.hbase.io.hfile.TestScannerSelectionUsingKeyRange
            hadoop.hbase.regionserver.TestKeepDeletes
            hadoop.hbase.client.TestIntraRowPagination
            hadoop.hbase.regionserver.TestHRegionFileSystem
            hadoop.hbase.ipc.TestNettyRpcServer
            hadoop.hbase.io.TestHalfStoreFileReader
            hadoop.hbase.regionserver.TestBlocksScanned
            hadoop.hbase.filter.TestDependentColumnFilter
            hadoop.hbase.regionserver.TestHStoreFile
            hadoop.hbase.io.hfile.TestPrefetch
            hadoop.hbase.thrift.TestThriftHttpServer
            hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
            hadoop.hbase.thrift.TestThriftServer
            hadoop.hbase.thrift.TestThriftServerCmdLine
            hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels
            hadoop.hbase.backup.TestBackupHFileCleaner
            hadoop.hbase.client.TestReplicationShell
            hadoop.hbase.client.TestShell



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123
          JIRA Issue HBASE-18601
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887459/HBASE-18601.master.003.patch
          Optional Tests asflicense shadedjars javac javadoc unit xml compile findbugs hadoopcheck hbaseanti checkstyle rubocop ruby_lint
          uname Linux 33421a1b60d5 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / a6d8ced
          Default Java 1.8.0_144
          findbugs v3.1.0-RC3
          mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-mvninstall-hbase-rest.txt
          mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-mvninstall-hbase-spark.txt
          rubocop v0.50.0
          ruby-lint v2.3.1
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/new-findbugs-hbase-common.html
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-unit-hbase-client.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-unit-hbase-server.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-unit-hbase-mapreduce.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-unit-hbase-thrift.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-unit-hbase-shell.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-unit-hbase-endpoint.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-unit-hbase-backup.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-unit-hbase-examples.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-unit-hbase-rest.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-unit-hbase-spark.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-unit-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8651/testReport/
          modules C: hbase-protocol-shaded hbase-common hbase-hadoop2-compat hbase-client hbase-replication hbase-prefix-tree hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-backup hbase-it hbase-examples hbase-rest hbase-external-blockcache hbase-spark . U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8651/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 29s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 6 new or modified test files. 0 mvndep 0m 36s Maven dependency ordering for branch +1 mvninstall 3m 30s master passed +1 compile 9m 14s master passed +1 checkstyle 3m 9s master passed +1 mvneclipse 6m 22s master passed +1 shadedjars 3m 32s branch has no errors when building our shaded downstream artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-testing-util . +1 findbugs 11m 29s master passed +1 javadoc 6m 58s master passed 0 mvndep 0m 15s Maven dependency ordering for patch -1 mvninstall 0m 14s hbase-rest in the patch failed. -1 mvninstall 0m 31s hbase-spark in the patch failed. +1 compile 8m 46s the patch passed +1 javac 8m 46s the patch passed +1 checkstyle 2m 52s the patch passed +1 mvneclipse 5m 51s the patch passed +1 rubocop 0m 3s There were no new rubocop issues. +1 ruby-lint 0m 1s There were no new ruby-lint issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 28s The patch has no ill-formed XML file. +1 shadedjars 4m 1s patch has no errors when building our shaded downstream artifacts. -1 hadoopcheck 4m 54s The patch causes 16 errors with Hadoop v2.6.1. -1 hadoopcheck 5m 50s The patch causes 16 errors with Hadoop v2.6.2. -1 hadoopcheck 6m 43s The patch causes 16 errors with Hadoop v2.6.3. -1 hadoopcheck 7m 37s The patch causes 16 errors with Hadoop v2.6.4. -1 hadoopcheck 8m 32s The patch causes 16 errors with Hadoop v2.6.5. 0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-testing-util . -1 findbugs 0m 38s hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 6m 18s the patch passed +1 unit 0m 24s hbase-protocol-shaded in the patch passed. +1 unit 2m 23s hbase-common in the patch passed. +1 unit 0m 26s hbase-hadoop2-compat in the patch passed. -1 unit 1m 24s hbase-client in the patch failed. +1 unit 0m 9s hbase-replication in the patch passed. +1 unit 0m 24s hbase-prefix-tree in the patch passed. +1 unit 3m 1s hbase-procedure in the patch passed. -1 unit 19m 7s hbase-server in the patch failed. -1 unit 21m 4s hbase-mapreduce in the patch failed. +1 unit 0m 13s hbase-testing-util in the patch passed. -1 unit 0m 36s hbase-thrift in the patch failed. +1 unit 0m 24s hbase-rsgroup in the patch passed. -1 unit 0m 47s hbase-shell in the patch failed. -1 unit 1m 0s hbase-endpoint in the patch failed. -1 unit 0m 46s hbase-backup in the patch failed. +1 unit 0m 20s hbase-it in the patch passed. -1 unit 0m 34s hbase-examples in the patch failed. -1 unit 20m 54s hbase-rest in the patch failed. +1 unit 0m 12s hbase-external-blockcache in the patch passed. -1 unit 1m 3s hbase-spark in the patch failed. -1 unit 8m 10s root in the patch failed. +1 asflicense 3m 26s The patch does not generate ASF License warnings. 204m 11s Reason Tests FindBugs module:hbase-common   Possible null pointer dereference of null in org.apache.hadoop.hbase.trace.TraceUtil.addSampler(Sampler) Dereferenced at TraceUtil.java:null in org.apache.hadoop.hbase.trace.TraceUtil.addSampler(Sampler) Dereferenced at TraceUtil.java: [line 37] Failed junit tests hadoop.hbase.client.TestClientNoCluster   hadoop.hbase.client.TestClientScanner   hadoop.hbase.ipc.TestBlockingIPC   hadoop.hbase.master.balancer.TestRegionLocationFinder   hadoop.hbase.regionserver.TestWideScanner   hadoop.hbase.coprocessor.TestCoprocessorInterface   hadoop.hbase.procedure.TestProcedureManager   hadoop.hbase.regionserver.TestMinVersions   hadoop.hbase.filter.TestFilterFromRegionSide   hadoop.hbase.io.encoding.TestPrefixTree   hadoop.hbase.regionserver.TestScanWithBloomError   hadoop.hbase.master.locking.TestLockProcedure   hadoop.hbase.master.locking.TestLockManager   hadoop.hbase.io.encoding.TestSeekBeforeWithReverseScan   hadoop.hbase.regionserver.TestStoreFileRefresherChore   hadoop.hbase.coprocessor.TestRegionObserverStacking   hadoop.hbase.filter.TestFilter   hadoop.hbase.executor.TestExecutorService   hadoop.hbase.regionserver.TestResettingCounters   hadoop.hbase.regionserver.TestScanner   hadoop.hbase.regionserver.wal.TestWALActionsListener   hadoop.hbase.io.hfile.TestHFile   hadoop.hbase.filter.TestMultipleColumnPrefixFilter   hadoop.hbase.filter.TestInvocationRecordFilter   hadoop.hbase.filter.TestColumnPrefixFilter   hadoop.hbase.io.hfile.TestScannerSelectionUsingKeyRange   hadoop.hbase.regionserver.TestKeepDeletes   hadoop.hbase.client.TestIntraRowPagination   hadoop.hbase.regionserver.TestHRegionFileSystem   hadoop.hbase.ipc.TestNettyRpcServer   hadoop.hbase.io.TestHalfStoreFileReader   hadoop.hbase.regionserver.TestBlocksScanned   hadoop.hbase.filter.TestDependentColumnFilter   hadoop.hbase.regionserver.TestHStoreFile   hadoop.hbase.io.hfile.TestPrefetch   hadoop.hbase.mapreduce.TestImportTSVWithTTLs   hadoop.hbase.mapred.TestTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestTableInputFormat   hadoop.hbase.mapreduce.TestImportTsv   hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestTimeRangeMapRed   hadoop.hbase.mapreduce.TestSyncTable   hadoop.hbase.mapreduce.TestRowCounter   hadoop.hbase.mapred.TestTableMapReduceUtil   hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes   hadoop.hbase.mapred.TestTableMapReduce   hadoop.hbase.mapred.TestMultiTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestWALRecordReader   hadoop.hbase.mapred.TestTableInputFormat   hadoop.hbase.mapreduce.TestHRegionPartitioner   hadoop.hbase.mapreduce.TestTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestCellCounter   hadoop.hbase.mapred.TestTableOutputFormatConnectionExhaust   hadoop.hbase.mapreduce.TestWALPlayer   hadoop.hbase.mapreduce.TestMultiTableInputFormat   hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels   hadoop.hbase.mapreduce.TestHFileOutputFormat2   hadoop.hbase.mapreduce.TestTableMapReduce   hadoop.hbase.mapreduce.TestMultithreadedTableMapper   hadoop.hbase.mapreduce.TestImportExport   hadoop.hbase.mapreduce.TestCopyTable   hadoop.hbase.mapreduce.TestTableInputFormatScan2   hadoop.hbase.mapreduce.TestHashTable   hadoop.hbase.mapreduce.TestTableInputFormatScan1   hadoop.hbase.thrift.TestThriftHttpServer   hadoop.hbase.thrift2.TestThriftHBaseServiceHandler   hadoop.hbase.thrift.TestThriftServer   hadoop.hbase.thrift.TestThriftServerCmdLine   hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels   hadoop.hbase.client.TestReplicationShell   hadoop.hbase.client.TestShell   hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint   hadoop.hbase.client.TestAsyncAggregationClient   hadoop.hbase.regionserver.TestServerCustomProtocol   hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint   hadoop.hbase.replication.TestReplicationSyncUpToolWithBulkLoadedData   hadoop.hbase.coprocessor.TestImportExport   hadoop.hbase.coprocessor.TestAsyncCoprocessorEndpoint   hadoop.hbase.coprocessor.TestCoprocessorEndpoint   hadoop.hbase.coprocessor.TestRowProcessorEndpoint   hadoop.hbase.coprocessor.TestSecureExport   hadoop.hbase.coprocessor.TestClassLoading   hadoop.hbase.coprocessor.TestCoprocessorTableEndpoint   hadoop.hbase.client.TestRpcControllerFactory   hadoop.hbase.backup.TestBackupHFileCleaner   hadoop.hbase.client.example.TestHttpProxyExample   hadoop.hbase.client.example.TestAsyncClientExample   hadoop.hbase.coprocessor.example.TestRefreshHFilesEndpoint   hadoop.hbase.rest.TestResourceFilter   hadoop.hbase.rest.TestScannerResource   hadoop.hbase.rest.client.TestRemoteTable   hadoop.hbase.rest.TestMultiRowResource   hadoop.hbase.rest.TestTableResource   hadoop.hbase.rest.TestVersionResource   hadoop.hbase.rest.TestDeleteRow   hadoop.hbase.rest.TestNamespacesResource   hadoop.hbase.rest.TestSchemaResource   hadoop.hbase.rest.TestNamespacesInstanceResource   hadoop.hbase.rest.TestStatusResource   hadoop.hbase.rest.TestScannersWithLabels   hadoop.hbase.rest.TestGetAndPutResource   hadoop.hbase.rest.TestScannersWithFilters   hadoop.hbase.rest.TestGzipFilter   hadoop.hbase.rest.TestTableScan   hadoop.hbase.client.TestClientNoCluster   hadoop.hbase.client.TestClientScanner   hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint   hadoop.hbase.client.TestAsyncAggregationClient   hadoop.hbase.regionserver.TestServerCustomProtocol   hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint   hadoop.hbase.replication.TestReplicationSyncUpToolWithBulkLoadedData   hadoop.hbase.coprocessor.TestImportExport   hadoop.hbase.coprocessor.TestAsyncCoprocessorEndpoint   hadoop.hbase.coprocessor.TestCoprocessorEndpoint   hadoop.hbase.coprocessor.TestRowProcessorEndpoint   hadoop.hbase.coprocessor.TestSecureExport   hadoop.hbase.coprocessor.TestClassLoading   hadoop.hbase.coprocessor.TestCoprocessorTableEndpoint   hadoop.hbase.client.TestRpcControllerFactory   hadoop.hbase.rest.TestResourceFilter   hadoop.hbase.rest.TestScannerResource   hadoop.hbase.rest.client.TestRemoteTable   hadoop.hbase.rest.TestMultiRowResource   hadoop.hbase.rest.TestTableResource   hadoop.hbase.rest.TestVersionResource   hadoop.hbase.rest.TestDeleteRow   hadoop.hbase.rest.TestNamespacesResource   hadoop.hbase.rest.TestSchemaResource   hadoop.hbase.rest.TestNamespacesInstanceResource   hadoop.hbase.rest.TestStatusResource   hadoop.hbase.rest.TestScannersWithLabels   hadoop.hbase.rest.TestGetAndPutResource   hadoop.hbase.rest.TestScannersWithFilters   hadoop.hbase.rest.TestGzipFilter   hadoop.hbase.rest.TestTableScan   hadoop.hbase.client.example.TestHttpProxyExample   hadoop.hbase.client.example.TestAsyncClientExample   hadoop.hbase.coprocessor.example.TestRefreshHFilesEndpoint   hadoop.hbase.mapreduce.TestImportTSVWithTTLs   hadoop.hbase.mapred.TestTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestTableInputFormat   hadoop.hbase.mapreduce.TestImportTsv   hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestTimeRangeMapRed   hadoop.hbase.mapreduce.TestSyncTable   hadoop.hbase.mapreduce.TestRowCounter   hadoop.hbase.mapred.TestTableMapReduceUtil   hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes   hadoop.hbase.mapred.TestTableMapReduce   hadoop.hbase.mapred.TestMultiTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestWALRecordReader   hadoop.hbase.mapred.TestTableInputFormat   hadoop.hbase.mapreduce.TestHRegionPartitioner   hadoop.hbase.mapreduce.TestTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestCellCounter   hadoop.hbase.mapred.TestTableOutputFormatConnectionExhaust   hadoop.hbase.mapreduce.TestWALPlayer   hadoop.hbase.mapreduce.TestMultiTableInputFormat   hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels   hadoop.hbase.mapreduce.TestHFileOutputFormat2   hadoop.hbase.mapreduce.TestTableMapReduce   hadoop.hbase.mapreduce.TestMultithreadedTableMapper   hadoop.hbase.mapreduce.TestImportExport   hadoop.hbase.mapreduce.TestCopyTable   hadoop.hbase.mapreduce.TestTableInputFormatScan2   hadoop.hbase.mapreduce.TestHashTable   hadoop.hbase.mapreduce.TestTableInputFormatScan1   hadoop.hbase.ipc.TestBlockingIPC   hadoop.hbase.master.balancer.TestRegionLocationFinder   hadoop.hbase.regionserver.TestWideScanner   hadoop.hbase.coprocessor.TestCoprocessorInterface   hadoop.hbase.procedure.TestProcedureManager   hadoop.hbase.regionserver.TestMinVersions   hadoop.hbase.filter.TestFilterFromRegionSide   hadoop.hbase.io.encoding.TestPrefixTree   hadoop.hbase.regionserver.TestScanWithBloomError   hadoop.hbase.master.locking.TestLockProcedure   hadoop.hbase.master.locking.TestLockManager   hadoop.hbase.io.encoding.TestSeekBeforeWithReverseScan   hadoop.hbase.regionserver.TestStoreFileRefresherChore   hadoop.hbase.coprocessor.TestRegionObserverStacking   hadoop.hbase.filter.TestFilter   hadoop.hbase.executor.TestExecutorService   hadoop.hbase.regionserver.TestResettingCounters   hadoop.hbase.regionserver.TestScanner   hadoop.hbase.regionserver.wal.TestWALActionsListener   hadoop.hbase.io.hfile.TestHFile   hadoop.hbase.filter.TestMultipleColumnPrefixFilter   hadoop.hbase.filter.TestInvocationRecordFilter   hadoop.hbase.filter.TestColumnPrefixFilter   hadoop.hbase.io.hfile.TestScannerSelectionUsingKeyRange   hadoop.hbase.regionserver.TestKeepDeletes   hadoop.hbase.client.TestIntraRowPagination   hadoop.hbase.regionserver.TestHRegionFileSystem   hadoop.hbase.ipc.TestNettyRpcServer   hadoop.hbase.io.TestHalfStoreFileReader   hadoop.hbase.regionserver.TestBlocksScanned   hadoop.hbase.filter.TestDependentColumnFilter   hadoop.hbase.regionserver.TestHStoreFile   hadoop.hbase.io.hfile.TestPrefetch   hadoop.hbase.thrift.TestThriftHttpServer   hadoop.hbase.thrift2.TestThriftHBaseServiceHandler   hadoop.hbase.thrift.TestThriftServer   hadoop.hbase.thrift.TestThriftServerCmdLine   hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels   hadoop.hbase.backup.TestBackupHFileCleaner   hadoop.hbase.client.TestReplicationShell   hadoop.hbase.client.TestShell Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 JIRA Issue HBASE-18601 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887459/HBASE-18601.master.003.patch Optional Tests asflicense shadedjars javac javadoc unit xml compile findbugs hadoopcheck hbaseanti checkstyle rubocop ruby_lint uname Linux 33421a1b60d5 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / a6d8ced Default Java 1.8.0_144 findbugs v3.1.0-RC3 mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-mvninstall-hbase-rest.txt mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-mvninstall-hbase-spark.txt rubocop v0.50.0 ruby-lint v2.3.1 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/new-findbugs-hbase-common.html unit https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-unit-hbase-client.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-unit-hbase-server.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-unit-hbase-mapreduce.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-unit-hbase-thrift.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-unit-hbase-shell.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-unit-hbase-endpoint.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-unit-hbase-backup.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-unit-hbase-examples.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-unit-hbase-rest.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-unit-hbase-spark.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8651/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8651/testReport/ modules C: hbase-protocol-shaded hbase-common hbase-hadoop2-compat hbase-client hbase-replication hbase-prefix-tree hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-backup hbase-it hbase-examples hbase-rest hbase-external-blockcache hbase-spark . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8651/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          stack stack added a comment -

          Retry

          Show
          stack stack added a comment - Retry
          Hide
          stack stack added a comment -

          Tamas Penzes Fix your IDE so it does not do this 'helpful' change for you: +import java.util.*; We do explicit import of each class always sir.

          +public class TraceUtil { Needs InterfaceAudience Private (see the adjacent classes in the package – I like how you put this util back up in hbase-common in here in this package... good one). A bit of javadoc on how to use and a test even wouldn't go amiss (smile). We need to shove this nice utility back up into htrace. Let me open issue pointing to your example after it goes in.

          Skimmed the rest. LGTM. Thanks Tamas Penzes

          Show
          stack stack added a comment - Tamas Penzes Fix your IDE so it does not do this 'helpful' change for you: +import java.util.*; We do explicit import of each class always sir. +public class TraceUtil { Needs InterfaceAudience Private (see the adjacent classes in the package – I like how you put this util back up in hbase-common in here in this package... good one). A bit of javadoc on how to use and a test even wouldn't go amiss (smile). We need to shove this nice utility back up into htrace. Let me open issue pointing to your example after it goes in. Skimmed the rest. LGTM. Thanks Tamas Penzes
          Hide
          tamaas Tamas Penzes added a comment -

          stack I've fixed my IDEA, now it doesn't group imports.
          Javadoc added to TraceUtil wrapper class.

          Show
          tamaas Tamas Penzes added a comment - stack I've fixed my IDEA, now it doesn't group imports. Javadoc added to TraceUtil wrapper class.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 6 new or modified test files.
          0 mvndep 0m 39s Maven dependency ordering for branch
          +1 mvninstall 4m 56s master passed
          +1 compile 12m 36s master passed
          +1 checkstyle 3m 21s master passed
          +1 mvneclipse 8m 9s master passed
          +1 shadedjars 4m 44s branch has no errors when building our shaded downstream artifacts.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-testing-util .
          +1 findbugs 15m 57s master passed
          +1 javadoc 7m 47s master passed
          0 mvndep 0m 18s Maven dependency ordering for patch
          -1 mvninstall 0m 14s hbase-rest in the patch failed.
          -1 mvninstall 0m 36s hbase-spark in the patch failed.
          +1 compile 9m 36s the patch passed
          +1 javac 9m 36s the patch passed
          +1 checkstyle 2m 44s the patch passed
          +1 mvneclipse 6m 11s the patch passed
          +1 rubocop 0m 5s There were no new rubocop issues.
          +1 ruby-lint 0m 1s There were no new ruby-lint issues.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 25s The patch has no ill-formed XML file.
          +1 shadedjars 4m 23s patch has no errors when building our shaded downstream artifacts.
          -1 hadoopcheck 5m 30s The patch causes 16 errors with Hadoop v2.6.1.
          -1 hadoopcheck 6m 31s The patch causes 16 errors with Hadoop v2.6.2.
          -1 hadoopcheck 7m 35s The patch causes 16 errors with Hadoop v2.6.3.
          -1 hadoopcheck 8m 36s The patch causes 16 errors with Hadoop v2.6.4.
          -1 hadoopcheck 9m 38s The patch causes 16 errors with Hadoop v2.6.5.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-testing-util .
          -1 findbugs 0m 49s hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          -1 javadoc 0m 17s hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          -1 javadoc 3m 47s root generated 1 new + 25 unchanged - 0 fixed = 26 total (was 25)
          +1 unit 0m 31s hbase-protocol-shaded in the patch passed.
          +1 unit 2m 32s hbase-common in the patch passed.
          +1 unit 0m 33s hbase-hadoop2-compat in the patch passed.
          -1 unit 1m 38s hbase-client in the patch failed.
          +1 unit 0m 12s hbase-replication in the patch passed.
          +1 unit 0m 30s hbase-prefix-tree in the patch passed.
          +1 unit 3m 20s hbase-procedure in the patch passed.
          -1 unit 21m 4s hbase-server in the patch failed.
          -1 unit 21m 59s hbase-mapreduce in the patch failed.
          +1 unit 0m 17s hbase-testing-util in the patch passed.
          -1 unit 0m 41s hbase-thrift in the patch failed.
          +1 unit 0m 25s hbase-rsgroup in the patch passed.
          -1 unit 0m 47s hbase-shell in the patch failed.
          -1 unit 0m 54s hbase-endpoint in the patch failed.
          -1 unit 0m 48s hbase-backup in the patch failed.
          +1 unit 0m 22s hbase-it in the patch passed.
          -1 unit 0m 34s hbase-examples in the patch failed.
          -1 unit 21m 12s hbase-rest in the patch failed.
          +1 unit 0m 15s hbase-external-blockcache in the patch passed.
          -1 unit 1m 3s hbase-spark in the patch failed.
          -1 unit 8m 4s root in the patch failed.
          +1 asflicense 3m 37s The patch does not generate ASF License warnings.
          235m 15s



          Reason Tests
          FindBugs module:hbase-common
            Possible null pointer dereference of null in org.apache.hadoop.hbase.trace.TraceUtil.addSampler(Sampler) Dereferenced at TraceUtil.java:null in org.apache.hadoop.hbase.trace.TraceUtil.addSampler(Sampler) Dereferenced at TraceUtil.java:[line 60]
          Failed junit tests hadoop.hbase.client.TestClientNoCluster
            hadoop.hbase.client.TestClientScanner
            hadoop.hbase.executor.TestExecutorService
            hadoop.hbase.filter.TestDependentColumnFilter
            hadoop.hbase.regionserver.TestResettingCounters
            hadoop.hbase.regionserver.TestHStoreFile
            hadoop.hbase.procedure.TestProcedureManager
            hadoop.hbase.master.balancer.TestRegionLocationFinder
            hadoop.hbase.regionserver.wal.TestWALActionsListener
            hadoop.hbase.io.hfile.TestHFile
            hadoop.hbase.io.hfile.TestScannerSelectionUsingKeyRange
            hadoop.hbase.ipc.TestBlockingIPC
            hadoop.hbase.client.TestIntraRowPagination
            hadoop.hbase.filter.TestInvocationRecordFilter
            hadoop.hbase.io.TestHalfStoreFileReader
            hadoop.hbase.regionserver.TestStoreFileRefresherChore
            hadoop.hbase.filter.TestFilter
            hadoop.hbase.regionserver.TestWideScanner
            hadoop.hbase.ipc.TestNettyRpcServer
            hadoop.hbase.regionserver.TestBlocksScanned
            hadoop.hbase.io.encoding.TestPrefixTree
            hadoop.hbase.filter.TestMultipleColumnPrefixFilter
            hadoop.hbase.regionserver.TestHRegionFileSystem
            hadoop.hbase.master.locking.TestLockProcedure
            hadoop.hbase.regionserver.TestScanner
            hadoop.hbase.filter.TestColumnPrefixFilter
            hadoop.hbase.coprocessor.TestCoprocessorInterface
            hadoop.hbase.regionserver.TestScanWithBloomError
            hadoop.hbase.io.encoding.TestSeekBeforeWithReverseScan
            hadoop.hbase.regionserver.TestKeepDeletes
            hadoop.hbase.master.locking.TestLockManager
            hadoop.hbase.filter.TestFilterFromRegionSide
            hadoop.hbase.coprocessor.TestRegionObserverStacking
            hadoop.hbase.io.hfile.TestPrefetch
            hadoop.hbase.regionserver.TestMinVersions
            hadoop.hbase.mapreduce.TestMultiTableInputFormat
            hadoop.hbase.mapred.TestTableMapReduce
            hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels
            hadoop.hbase.mapreduce.TestWALPlayer
            hadoop.hbase.mapreduce.TestCellCounter
            hadoop.hbase.mapreduce.TestTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestTableInputFormat
            hadoop.hbase.mapreduce.TestSyncTable
            hadoop.hbase.mapreduce.TestRowCounter
            hadoop.hbase.mapreduce.TestHashTable
            hadoop.hbase.mapreduce.TestImportTsv
            hadoop.hbase.mapred.TestMultiTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestHFileOutputFormat2
            hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes
            hadoop.hbase.mapreduce.TestHRegionPartitioner
            hadoop.hbase.mapred.TestTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestTableInputFormatScan1
            hadoop.hbase.mapreduce.TestTimeRangeMapRed
            hadoop.hbase.mapreduce.TestImportTSVWithTTLs
            hadoop.hbase.mapreduce.TestCopyTable
            hadoop.hbase.mapred.TestTableOutputFormatConnectionExhaust
            hadoop.hbase.mapred.TestTableInputFormat
            hadoop.hbase.mapred.TestTableMapReduceUtil
            hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestImportExport
            hadoop.hbase.mapreduce.TestTableMapReduce
            hadoop.hbase.mapreduce.TestMultithreadedTableMapper
            hadoop.hbase.mapreduce.TestTableInputFormatScan2
            hadoop.hbase.mapreduce.TestWALRecordReader
            hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels
            hadoop.hbase.thrift.TestThriftServer
            hadoop.hbase.thrift.TestThriftHttpServer
            hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
            hadoop.hbase.thrift.TestThriftServerCmdLine
            hadoop.hbase.client.TestShell
            hadoop.hbase.client.TestReplicationShell
            hadoop.hbase.coprocessor.TestCoprocessorEndpoint
            hadoop.hbase.regionserver.TestServerCustomProtocol
            hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint
            hadoop.hbase.coprocessor.TestRowProcessorEndpoint
            hadoop.hbase.client.TestAsyncAggregationClient
            hadoop.hbase.client.TestRpcControllerFactory
            hadoop.hbase.coprocessor.TestImportExport
            hadoop.hbase.replication.TestReplicationSyncUpToolWithBulkLoadedData
            hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint
            hadoop.hbase.coprocessor.TestSecureExport
            hadoop.hbase.coprocessor.TestClassLoading
            hadoop.hbase.coprocessor.TestAsyncCoprocessorEndpoint
            hadoop.hbase.coprocessor.TestCoprocessorTableEndpoint
            hadoop.hbase.backup.TestBackupHFileCleaner
            hadoop.hbase.coprocessor.example.TestRefreshHFilesEndpoint
            hadoop.hbase.client.example.TestHttpProxyExample
            hadoop.hbase.client.example.TestAsyncClientExample
            hadoop.hbase.rest.TestScannersWithFilters
            hadoop.hbase.rest.TestStatusResource
            hadoop.hbase.rest.TestGzipFilter
            hadoop.hbase.rest.TestScannersWithLabels
            hadoop.hbase.rest.TestMultiRowResource
            hadoop.hbase.rest.TestNamespacesResource
            hadoop.hbase.rest.TestResourceFilter
            hadoop.hbase.rest.TestGetAndPutResource
            hadoop.hbase.rest.TestScannerResource
            hadoop.hbase.rest.TestTableScan
            hadoop.hbase.rest.TestSchemaResource
            hadoop.hbase.rest.TestTableResource
            hadoop.hbase.rest.TestVersionResource
            hadoop.hbase.rest.TestNamespacesInstanceResource
            hadoop.hbase.rest.TestDeleteRow
            hadoop.hbase.rest.client.TestRemoteTable
            hadoop.hbase.coprocessor.TestCoprocessorEndpoint
            hadoop.hbase.regionserver.TestServerCustomProtocol
            hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint
            hadoop.hbase.coprocessor.TestRowProcessorEndpoint
            hadoop.hbase.client.TestAsyncAggregationClient
            hadoop.hbase.client.TestRpcControllerFactory
            hadoop.hbase.coprocessor.TestImportExport
            hadoop.hbase.replication.TestReplicationSyncUpToolWithBulkLoadedData
            hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint
            hadoop.hbase.coprocessor.TestSecureExport
            hadoop.hbase.coprocessor.TestClassLoading
            hadoop.hbase.coprocessor.TestAsyncCoprocessorEndpoint
            hadoop.hbase.coprocessor.TestCoprocessorTableEndpoint
            hadoop.hbase.executor.TestExecutorService
            hadoop.hbase.filter.TestDependentColumnFilter
            hadoop.hbase.regionserver.TestResettingCounters
            hadoop.hbase.regionserver.TestHStoreFile
            hadoop.hbase.procedure.TestProcedureManager
            hadoop.hbase.master.balancer.TestRegionLocationFinder
            hadoop.hbase.regionserver.wal.TestWALActionsListener
            hadoop.hbase.io.hfile.TestHFile
            hadoop.hbase.io.hfile.TestScannerSelectionUsingKeyRange
            hadoop.hbase.ipc.TestBlockingIPC
            hadoop.hbase.client.TestIntraRowPagination
            hadoop.hbase.filter.TestInvocationRecordFilter
            hadoop.hbase.io.TestHalfStoreFileReader
            hadoop.hbase.regionserver.TestStoreFileRefresherChore
            hadoop.hbase.filter.TestFilter
            hadoop.hbase.regionserver.TestWideScanner
            hadoop.hbase.ipc.TestNettyRpcServer
            hadoop.hbase.regionserver.TestBlocksScanned
            hadoop.hbase.io.encoding.TestPrefixTree
            hadoop.hbase.filter.TestMultipleColumnPrefixFilter
            hadoop.hbase.regionserver.TestHRegionFileSystem
            hadoop.hbase.master.locking.TestLockProcedure
            hadoop.hbase.regionserver.TestScanner
            hadoop.hbase.filter.TestColumnPrefixFilter
            hadoop.hbase.coprocessor.TestCoprocessorInterface
            hadoop.hbase.regionserver.TestScanWithBloomError
            hadoop.hbase.io.encoding.TestSeekBeforeWithReverseScan
            hadoop.hbase.regionserver.TestKeepDeletes
            hadoop.hbase.master.locking.TestLockManager
            hadoop.hbase.filter.TestFilterFromRegionSide
            hadoop.hbase.coprocessor.TestRegionObserverStacking
            hadoop.hbase.io.hfile.TestPrefetch
            hadoop.hbase.regionserver.TestMinVersions
            hadoop.hbase.backup.TestBackupHFileCleaner
            hadoop.hbase.client.TestShell
            hadoop.hbase.client.TestReplicationShell
            hadoop.hbase.client.TestClientNoCluster
            hadoop.hbase.client.TestClientScanner
            hadoop.hbase.coprocessor.example.TestRefreshHFilesEndpoint
            hadoop.hbase.client.example.TestHttpProxyExample
            hadoop.hbase.client.example.TestAsyncClientExample
            hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels
            hadoop.hbase.thrift.TestThriftServer
            hadoop.hbase.thrift.TestThriftHttpServer
            hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
            hadoop.hbase.thrift.TestThriftServerCmdLine
            hadoop.hbase.rest.TestScannersWithFilters
            hadoop.hbase.rest.TestStatusResource
            hadoop.hbase.rest.TestGzipFilter
            hadoop.hbase.rest.TestScannersWithLabels
            hadoop.hbase.rest.TestMultiRowResource
            hadoop.hbase.rest.TestNamespacesResource
            hadoop.hbase.rest.TestResourceFilter
            hadoop.hbase.rest.TestGetAndPutResource
            hadoop.hbase.rest.TestScannerResource
            hadoop.hbase.rest.TestTableScan
            hadoop.hbase.rest.TestSchemaResource
            hadoop.hbase.rest.TestTableResource
            hadoop.hbase.rest.TestVersionResource
            hadoop.hbase.rest.TestNamespacesInstanceResource
            hadoop.hbase.rest.TestDeleteRow
            hadoop.hbase.rest.client.TestRemoteTable
            hadoop.hbase.mapreduce.TestMultiTableInputFormat
            hadoop.hbase.mapred.TestTableMapReduce
            hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels
            hadoop.hbase.mapreduce.TestWALPlayer
            hadoop.hbase.mapreduce.TestCellCounter
            hadoop.hbase.mapreduce.TestTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestTableInputFormat
            hadoop.hbase.mapreduce.TestSyncTable
            hadoop.hbase.mapreduce.TestRowCounter
            hadoop.hbase.mapreduce.TestHashTable
            hadoop.hbase.mapreduce.TestImportTsv
            hadoop.hbase.mapred.TestMultiTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestHFileOutputFormat2
            hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes
            hadoop.hbase.mapreduce.TestHRegionPartitioner
            hadoop.hbase.mapred.TestTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestTableInputFormatScan1
            hadoop.hbase.mapreduce.TestTimeRangeMapRed
            hadoop.hbase.mapreduce.TestImportTSVWithTTLs
            hadoop.hbase.mapreduce.TestCopyTable
            hadoop.hbase.mapred.TestTableOutputFormatConnectionExhaust
            hadoop.hbase.mapred.TestTableInputFormat
            hadoop.hbase.mapred.TestTableMapReduceUtil
            hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormat
            hadoop.hbase.mapreduce.TestImportExport
            hadoop.hbase.mapreduce.TestTableMapReduce
            hadoop.hbase.mapreduce.TestMultithreadedTableMapper
            hadoop.hbase.mapreduce.TestTableInputFormatScan2
            hadoop.hbase.mapreduce.TestWALRecordReader



          Subsystem Report/Notes
          Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:5d60123
          JIRA Issue HBASE-18601
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887739/HBASE-18601.master.004.patch
          Optional Tests asflicense shadedjars javac javadoc unit xml compile findbugs hadoopcheck hbaseanti checkstyle rubocop ruby_lint
          uname Linux ada5ed3a5b45 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / e10d783
          Default Java 1.8.0_144
          findbugs v3.1.0-RC3
          mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-mvninstall-hbase-rest.txt
          mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-mvninstall-hbase-spark.txt
          rubocop v0.50.0
          ruby-lint v2.3.1
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/new-findbugs-hbase-common.html
          javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/diff-javadoc-javadoc-hbase-common.txt
          javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/diff-javadoc-javadoc-root.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-unit-hbase-client.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-unit-hbase-server.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-unit-hbase-mapreduce.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-unit-hbase-thrift.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-unit-hbase-shell.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-unit-hbase-endpoint.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-unit-hbase-backup.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-unit-hbase-examples.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-unit-hbase-rest.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-unit-hbase-spark.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-unit-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8694/testReport/
          modules C: hbase-protocol-shaded hbase-common hbase-hadoop2-compat hbase-client hbase-replication hbase-prefix-tree hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-backup hbase-it hbase-examples hbase-rest hbase-external-blockcache hbase-spark . U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8694/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 6 new or modified test files. 0 mvndep 0m 39s Maven dependency ordering for branch +1 mvninstall 4m 56s master passed +1 compile 12m 36s master passed +1 checkstyle 3m 21s master passed +1 mvneclipse 8m 9s master passed +1 shadedjars 4m 44s branch has no errors when building our shaded downstream artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-testing-util . +1 findbugs 15m 57s master passed +1 javadoc 7m 47s master passed 0 mvndep 0m 18s Maven dependency ordering for patch -1 mvninstall 0m 14s hbase-rest in the patch failed. -1 mvninstall 0m 36s hbase-spark in the patch failed. +1 compile 9m 36s the patch passed +1 javac 9m 36s the patch passed +1 checkstyle 2m 44s the patch passed +1 mvneclipse 6m 11s the patch passed +1 rubocop 0m 5s There were no new rubocop issues. +1 ruby-lint 0m 1s There were no new ruby-lint issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 25s The patch has no ill-formed XML file. +1 shadedjars 4m 23s patch has no errors when building our shaded downstream artifacts. -1 hadoopcheck 5m 30s The patch causes 16 errors with Hadoop v2.6.1. -1 hadoopcheck 6m 31s The patch causes 16 errors with Hadoop v2.6.2. -1 hadoopcheck 7m 35s The patch causes 16 errors with Hadoop v2.6.3. -1 hadoopcheck 8m 36s The patch causes 16 errors with Hadoop v2.6.4. -1 hadoopcheck 9m 38s The patch causes 16 errors with Hadoop v2.6.5. 0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-testing-util . -1 findbugs 0m 49s hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) -1 javadoc 0m 17s hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) -1 javadoc 3m 47s root generated 1 new + 25 unchanged - 0 fixed = 26 total (was 25) +1 unit 0m 31s hbase-protocol-shaded in the patch passed. +1 unit 2m 32s hbase-common in the patch passed. +1 unit 0m 33s hbase-hadoop2-compat in the patch passed. -1 unit 1m 38s hbase-client in the patch failed. +1 unit 0m 12s hbase-replication in the patch passed. +1 unit 0m 30s hbase-prefix-tree in the patch passed. +1 unit 3m 20s hbase-procedure in the patch passed. -1 unit 21m 4s hbase-server in the patch failed. -1 unit 21m 59s hbase-mapreduce in the patch failed. +1 unit 0m 17s hbase-testing-util in the patch passed. -1 unit 0m 41s hbase-thrift in the patch failed. +1 unit 0m 25s hbase-rsgroup in the patch passed. -1 unit 0m 47s hbase-shell in the patch failed. -1 unit 0m 54s hbase-endpoint in the patch failed. -1 unit 0m 48s hbase-backup in the patch failed. +1 unit 0m 22s hbase-it in the patch passed. -1 unit 0m 34s hbase-examples in the patch failed. -1 unit 21m 12s hbase-rest in the patch failed. +1 unit 0m 15s hbase-external-blockcache in the patch passed. -1 unit 1m 3s hbase-spark in the patch failed. -1 unit 8m 4s root in the patch failed. +1 asflicense 3m 37s The patch does not generate ASF License warnings. 235m 15s Reason Tests FindBugs module:hbase-common   Possible null pointer dereference of null in org.apache.hadoop.hbase.trace.TraceUtil.addSampler(Sampler) Dereferenced at TraceUtil.java:null in org.apache.hadoop.hbase.trace.TraceUtil.addSampler(Sampler) Dereferenced at TraceUtil.java: [line 60] Failed junit tests hadoop.hbase.client.TestClientNoCluster   hadoop.hbase.client.TestClientScanner   hadoop.hbase.executor.TestExecutorService   hadoop.hbase.filter.TestDependentColumnFilter   hadoop.hbase.regionserver.TestResettingCounters   hadoop.hbase.regionserver.TestHStoreFile   hadoop.hbase.procedure.TestProcedureManager   hadoop.hbase.master.balancer.TestRegionLocationFinder   hadoop.hbase.regionserver.wal.TestWALActionsListener   hadoop.hbase.io.hfile.TestHFile   hadoop.hbase.io.hfile.TestScannerSelectionUsingKeyRange   hadoop.hbase.ipc.TestBlockingIPC   hadoop.hbase.client.TestIntraRowPagination   hadoop.hbase.filter.TestInvocationRecordFilter   hadoop.hbase.io.TestHalfStoreFileReader   hadoop.hbase.regionserver.TestStoreFileRefresherChore   hadoop.hbase.filter.TestFilter   hadoop.hbase.regionserver.TestWideScanner   hadoop.hbase.ipc.TestNettyRpcServer   hadoop.hbase.regionserver.TestBlocksScanned   hadoop.hbase.io.encoding.TestPrefixTree   hadoop.hbase.filter.TestMultipleColumnPrefixFilter   hadoop.hbase.regionserver.TestHRegionFileSystem   hadoop.hbase.master.locking.TestLockProcedure   hadoop.hbase.regionserver.TestScanner   hadoop.hbase.filter.TestColumnPrefixFilter   hadoop.hbase.coprocessor.TestCoprocessorInterface   hadoop.hbase.regionserver.TestScanWithBloomError   hadoop.hbase.io.encoding.TestSeekBeforeWithReverseScan   hadoop.hbase.regionserver.TestKeepDeletes   hadoop.hbase.master.locking.TestLockManager   hadoop.hbase.filter.TestFilterFromRegionSide   hadoop.hbase.coprocessor.TestRegionObserverStacking   hadoop.hbase.io.hfile.TestPrefetch   hadoop.hbase.regionserver.TestMinVersions   hadoop.hbase.mapreduce.TestMultiTableInputFormat   hadoop.hbase.mapred.TestTableMapReduce   hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels   hadoop.hbase.mapreduce.TestWALPlayer   hadoop.hbase.mapreduce.TestCellCounter   hadoop.hbase.mapreduce.TestTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestTableInputFormat   hadoop.hbase.mapreduce.TestSyncTable   hadoop.hbase.mapreduce.TestRowCounter   hadoop.hbase.mapreduce.TestHashTable   hadoop.hbase.mapreduce.TestImportTsv   hadoop.hbase.mapred.TestMultiTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestHFileOutputFormat2   hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes   hadoop.hbase.mapreduce.TestHRegionPartitioner   hadoop.hbase.mapred.TestTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestTableInputFormatScan1   hadoop.hbase.mapreduce.TestTimeRangeMapRed   hadoop.hbase.mapreduce.TestImportTSVWithTTLs   hadoop.hbase.mapreduce.TestCopyTable   hadoop.hbase.mapred.TestTableOutputFormatConnectionExhaust   hadoop.hbase.mapred.TestTableInputFormat   hadoop.hbase.mapred.TestTableMapReduceUtil   hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestImportExport   hadoop.hbase.mapreduce.TestTableMapReduce   hadoop.hbase.mapreduce.TestMultithreadedTableMapper   hadoop.hbase.mapreduce.TestTableInputFormatScan2   hadoop.hbase.mapreduce.TestWALRecordReader   hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels   hadoop.hbase.thrift.TestThriftServer   hadoop.hbase.thrift.TestThriftHttpServer   hadoop.hbase.thrift2.TestThriftHBaseServiceHandler   hadoop.hbase.thrift.TestThriftServerCmdLine   hadoop.hbase.client.TestShell   hadoop.hbase.client.TestReplicationShell   hadoop.hbase.coprocessor.TestCoprocessorEndpoint   hadoop.hbase.regionserver.TestServerCustomProtocol   hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint   hadoop.hbase.coprocessor.TestRowProcessorEndpoint   hadoop.hbase.client.TestAsyncAggregationClient   hadoop.hbase.client.TestRpcControllerFactory   hadoop.hbase.coprocessor.TestImportExport   hadoop.hbase.replication.TestReplicationSyncUpToolWithBulkLoadedData   hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint   hadoop.hbase.coprocessor.TestSecureExport   hadoop.hbase.coprocessor.TestClassLoading   hadoop.hbase.coprocessor.TestAsyncCoprocessorEndpoint   hadoop.hbase.coprocessor.TestCoprocessorTableEndpoint   hadoop.hbase.backup.TestBackupHFileCleaner   hadoop.hbase.coprocessor.example.TestRefreshHFilesEndpoint   hadoop.hbase.client.example.TestHttpProxyExample   hadoop.hbase.client.example.TestAsyncClientExample   hadoop.hbase.rest.TestScannersWithFilters   hadoop.hbase.rest.TestStatusResource   hadoop.hbase.rest.TestGzipFilter   hadoop.hbase.rest.TestScannersWithLabels   hadoop.hbase.rest.TestMultiRowResource   hadoop.hbase.rest.TestNamespacesResource   hadoop.hbase.rest.TestResourceFilter   hadoop.hbase.rest.TestGetAndPutResource   hadoop.hbase.rest.TestScannerResource   hadoop.hbase.rest.TestTableScan   hadoop.hbase.rest.TestSchemaResource   hadoop.hbase.rest.TestTableResource   hadoop.hbase.rest.TestVersionResource   hadoop.hbase.rest.TestNamespacesInstanceResource   hadoop.hbase.rest.TestDeleteRow   hadoop.hbase.rest.client.TestRemoteTable   hadoop.hbase.coprocessor.TestCoprocessorEndpoint   hadoop.hbase.regionserver.TestServerCustomProtocol   hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint   hadoop.hbase.coprocessor.TestRowProcessorEndpoint   hadoop.hbase.client.TestAsyncAggregationClient   hadoop.hbase.client.TestRpcControllerFactory   hadoop.hbase.coprocessor.TestImportExport   hadoop.hbase.replication.TestReplicationSyncUpToolWithBulkLoadedData   hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint   hadoop.hbase.coprocessor.TestSecureExport   hadoop.hbase.coprocessor.TestClassLoading   hadoop.hbase.coprocessor.TestAsyncCoprocessorEndpoint   hadoop.hbase.coprocessor.TestCoprocessorTableEndpoint   hadoop.hbase.executor.TestExecutorService   hadoop.hbase.filter.TestDependentColumnFilter   hadoop.hbase.regionserver.TestResettingCounters   hadoop.hbase.regionserver.TestHStoreFile   hadoop.hbase.procedure.TestProcedureManager   hadoop.hbase.master.balancer.TestRegionLocationFinder   hadoop.hbase.regionserver.wal.TestWALActionsListener   hadoop.hbase.io.hfile.TestHFile   hadoop.hbase.io.hfile.TestScannerSelectionUsingKeyRange   hadoop.hbase.ipc.TestBlockingIPC   hadoop.hbase.client.TestIntraRowPagination   hadoop.hbase.filter.TestInvocationRecordFilter   hadoop.hbase.io.TestHalfStoreFileReader   hadoop.hbase.regionserver.TestStoreFileRefresherChore   hadoop.hbase.filter.TestFilter   hadoop.hbase.regionserver.TestWideScanner   hadoop.hbase.ipc.TestNettyRpcServer   hadoop.hbase.regionserver.TestBlocksScanned   hadoop.hbase.io.encoding.TestPrefixTree   hadoop.hbase.filter.TestMultipleColumnPrefixFilter   hadoop.hbase.regionserver.TestHRegionFileSystem   hadoop.hbase.master.locking.TestLockProcedure   hadoop.hbase.regionserver.TestScanner   hadoop.hbase.filter.TestColumnPrefixFilter   hadoop.hbase.coprocessor.TestCoprocessorInterface   hadoop.hbase.regionserver.TestScanWithBloomError   hadoop.hbase.io.encoding.TestSeekBeforeWithReverseScan   hadoop.hbase.regionserver.TestKeepDeletes   hadoop.hbase.master.locking.TestLockManager   hadoop.hbase.filter.TestFilterFromRegionSide   hadoop.hbase.coprocessor.TestRegionObserverStacking   hadoop.hbase.io.hfile.TestPrefetch   hadoop.hbase.regionserver.TestMinVersions   hadoop.hbase.backup.TestBackupHFileCleaner   hadoop.hbase.client.TestShell   hadoop.hbase.client.TestReplicationShell   hadoop.hbase.client.TestClientNoCluster   hadoop.hbase.client.TestClientScanner   hadoop.hbase.coprocessor.example.TestRefreshHFilesEndpoint   hadoop.hbase.client.example.TestHttpProxyExample   hadoop.hbase.client.example.TestAsyncClientExample   hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels   hadoop.hbase.thrift.TestThriftServer   hadoop.hbase.thrift.TestThriftHttpServer   hadoop.hbase.thrift2.TestThriftHBaseServiceHandler   hadoop.hbase.thrift.TestThriftServerCmdLine   hadoop.hbase.rest.TestScannersWithFilters   hadoop.hbase.rest.TestStatusResource   hadoop.hbase.rest.TestGzipFilter   hadoop.hbase.rest.TestScannersWithLabels   hadoop.hbase.rest.TestMultiRowResource   hadoop.hbase.rest.TestNamespacesResource   hadoop.hbase.rest.TestResourceFilter   hadoop.hbase.rest.TestGetAndPutResource   hadoop.hbase.rest.TestScannerResource   hadoop.hbase.rest.TestTableScan   hadoop.hbase.rest.TestSchemaResource   hadoop.hbase.rest.TestTableResource   hadoop.hbase.rest.TestVersionResource   hadoop.hbase.rest.TestNamespacesInstanceResource   hadoop.hbase.rest.TestDeleteRow   hadoop.hbase.rest.client.TestRemoteTable   hadoop.hbase.mapreduce.TestMultiTableInputFormat   hadoop.hbase.mapred.TestTableMapReduce   hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels   hadoop.hbase.mapreduce.TestWALPlayer   hadoop.hbase.mapreduce.TestCellCounter   hadoop.hbase.mapreduce.TestTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestTableInputFormat   hadoop.hbase.mapreduce.TestSyncTable   hadoop.hbase.mapreduce.TestRowCounter   hadoop.hbase.mapreduce.TestHashTable   hadoop.hbase.mapreduce.TestImportTsv   hadoop.hbase.mapred.TestMultiTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestHFileOutputFormat2   hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes   hadoop.hbase.mapreduce.TestHRegionPartitioner   hadoop.hbase.mapred.TestTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestTableInputFormatScan1   hadoop.hbase.mapreduce.TestTimeRangeMapRed   hadoop.hbase.mapreduce.TestImportTSVWithTTLs   hadoop.hbase.mapreduce.TestCopyTable   hadoop.hbase.mapred.TestTableOutputFormatConnectionExhaust   hadoop.hbase.mapred.TestTableInputFormat   hadoop.hbase.mapred.TestTableMapReduceUtil   hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormat   hadoop.hbase.mapreduce.TestImportExport   hadoop.hbase.mapreduce.TestTableMapReduce   hadoop.hbase.mapreduce.TestMultithreadedTableMapper   hadoop.hbase.mapreduce.TestTableInputFormatScan2   hadoop.hbase.mapreduce.TestWALRecordReader Subsystem Report/Notes Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:5d60123 JIRA Issue HBASE-18601 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887739/HBASE-18601.master.004.patch Optional Tests asflicense shadedjars javac javadoc unit xml compile findbugs hadoopcheck hbaseanti checkstyle rubocop ruby_lint uname Linux ada5ed3a5b45 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / e10d783 Default Java 1.8.0_144 findbugs v3.1.0-RC3 mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-mvninstall-hbase-rest.txt mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-mvninstall-hbase-spark.txt rubocop v0.50.0 ruby-lint v2.3.1 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/new-findbugs-hbase-common.html javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/diff-javadoc-javadoc-hbase-common.txt javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/diff-javadoc-javadoc-root.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-unit-hbase-client.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-unit-hbase-server.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-unit-hbase-mapreduce.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-unit-hbase-thrift.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-unit-hbase-shell.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-unit-hbase-endpoint.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-unit-hbase-backup.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-unit-hbase-examples.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-unit-hbase-rest.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-unit-hbase-spark.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8694/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8694/testReport/ modules C: hbase-protocol-shaded hbase-common hbase-hadoop2-compat hbase-client hbase-replication hbase-prefix-tree hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-backup hbase-it hbase-examples hbase-rest hbase-external-blockcache hbase-spark . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8694/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          stack stack added a comment -

          Retry

          Show
          stack stack added a comment - Retry
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 docker 499m 47s Docker failed to build yetus/hbase:tp-29944.



          Subsystem Report/Notes
          JIRA Issue HBASE-18601
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887785/HBASE-18601.master.004.patch
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8697/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 docker 499m 47s Docker failed to build yetus/hbase:tp-29944. Subsystem Report/Notes JIRA Issue HBASE-18601 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887785/HBASE-18601.master.004.patch Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8697/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          mdrob Mike Drob added a comment -

          In AsyncRequestFutureImpl.java and PerformanceEvaluation.java there is +import org.apache.hadoop.tracing.TraceUtils;

          Please document that many of the methods in TraceUtil will return null when not tracing.

          IntegrationTestMTTR.java
          +          scope = TraceUtil.createTrace(getSpanName());
          +          TraceUtil.addSampler(AlwaysSampler.INSTANCE);
          

          I think these need to be reversed. Similar comment applies to the other ITs.

          TraceTree is big enough to be it's own class, I think. And could use some more doc.

          There's some TODOs hanging about - can you file a JIRA and reference it there?

          Overall, I think we're getting close.

          Show
          mdrob Mike Drob added a comment - In AsyncRequestFutureImpl.java and PerformanceEvaluation.java there is +import org.apache.hadoop.tracing.TraceUtils; Please document that many of the methods in TraceUtil will return null when not tracing. IntegrationTestMTTR.java + scope = TraceUtil.createTrace(getSpanName()); + TraceUtil.addSampler(AlwaysSampler.INSTANCE); I think these need to be reversed. Similar comment applies to the other ITs. TraceTree is big enough to be it's own class, I think. And could use some more doc. There's some TODOs hanging about - can you file a JIRA and reference it there? Overall, I think we're getting close.

            People

            • Assignee:
              tamaas Tamas Penzes
              Reporter:
              tamaas Tamas Penzes
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:

                Development