[HBASE-18509] [HLC] Finishing cleanups

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Hadoop Flags: Reviewed
• Assignee: Amit Patel
• Reporter: Apekshit Sharma
• Created: 02/Aug/17 22:41
• Updated: 24/Aug/17 19:13
• Resolved: 24/Aug/17 19:13

Description

Track all types of cleanups here:

• (done in 001.patch) -Rename classes to more consistent naming: SystemClock, SystemMonotonicClock, HybridLogicalClock-
• (done in 001.patch) -Move implementations out from Clock interface. It's a simple interface of 6 fns but very overloaded right now with everything put inside it.-
• (done in 004.patch) -Maybe encapsulate all clocks in RS/Master into a new class. Then RSServices can just have getClocks() function.-

  class Clocks {
    // all 3 types of clocks.
    // Fns:
    - update(ClockType, timestamp)
    - updateAll(List\<NodeTime>)
    - int64 now(ClockType)
    - List\<NodeTime> nowAll()
    }
  

Issue Links

• links to: Review Board (HBASE-14070.HLC)