Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-14070 Hybrid Logical Clocks for HBase
  3. HBASE-18496

Fix TestTimestampType failing on isLikelyOfType tests

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • None
    • HBASE-14070
    • None
    • None

    Description

      The tests testPhysicalIsLikelyOfType and testHybridIsLikelyOfType were failing after the initial commit of core HLC so this patch fixes that. Note that both Physical#isLikelyOfType and Hybrid#isLikelyOfType will return false if the input timestamp is from before the first half of the first day of 1970.

      Changes

      • Offset date by second day of year
      • Fixed instance of not properly setting ZonedDateTime in TestTimestampType#testPhysicalIsLikelyOfType
      • Changed timestamp for year 2016 in TimestampType to be UTC+0 instead of UTC+8

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            amit.patel Amit Patel
            amit.patel Amit Patel
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment