On Region Server crash, as ServerCrashProcedure handles reassignment of all the regions on a crashed server, don't process those regions through AssignmentManager.checkIfShouldMoveSystemRegionAsync(). This avoids duplicate and makes ServerCrashProcedure as one place to find all related code for handling server crash.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
+1
mvninstall
3m 35s
master passed
+1
compile
0m 39s
master passed
+1
checkstyle
0m 50s
master passed
+1
mvneclipse
0m 15s
master passed
+1
findbugs
3m 17s
master passed
+1
javadoc
0m 30s
master passed
+1
mvninstall
0m 46s
the patch passed
+1
compile
0m 39s
the patch passed
+1
javac
0m 39s
the patch passed
+1
checkstyle
0m 47s
the patch passed
+1
mvneclipse
0m 14s
the patch passed
+1
whitespace
0m 0s
The patch has no whitespace issues.
+1
hadoopcheck
32m 24s
Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
FAILURE: Integrated in Jenkins build HBase-2.0 #341 (See https://builds.apache.org/job/HBase-2.0/341/) HBASE-18493[AMv2] Skipped re-assignment of regions on crashed server (stack: rev 53c5bcc5827217bfa05136bd14b78fde93529783)
Hudson
added a comment - FAILURE: Integrated in Jenkins build HBase-2.0 #341 (See https://builds.apache.org/job/HBase-2.0/341/ )
HBASE-18493 [AMv2] Skipped re-assignment of regions on crashed server (stack: rev 53c5bcc5827217bfa05136bd14b78fde93529783)
(edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
Hudson
added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3544 (See https://builds.apache.org/job/HBase-Trunk_matrix/3544/ )
HBASE-18493 [AMv2] Skipped re-assignment of regions on crashed server (stack: rev acf9b87dca2cd190f4b5318efd5dc48e19b317f4)
(edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
Hudson
added a comment - FAILURE: Integrated in Jenkins build HBASE-14070 .HLC #233 (See https://builds.apache.org/job/HBASE-14070.HLC/233/ )
HBASE-18493 [AMv2] Skipped re-assignment of regions on crashed server (stack: rev acf9b87dca2cd190f4b5318efd5dc48e19b317f4)
(edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
People
Umesh Agashe
Umesh Agashe
Votes:
0Vote for this issue
Watchers:
3Start watching this issue
Dates
Created:
Updated:
Resolved:
{"report":{"fcp":4302.5,"ttfb":776.5,"pageVisibility":"visible","entityId":13091647,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":16,"apdex":0,"journeyId":"a477110d-325c-4c39-94ec-c9ceb2e9baba","navigationType":0,"readyForUser":4496.600000023842,"redirectCount":0,"resourceLoadedEnd":4113.299999952316,"resourceLoadedStart":785.7999999523163,"resourceTiming":[{"duration":228.39999997615814,"initiatorType":"link","name":"https://issues.apache.org/jira/s/b62489a2eaac59d9b8a093c1a51d034f-CDN/xd97tr/820010/13pdxe5/49fa3aa3d35a2cc689cbf274e66cc41a/_/download/contextbatch/css/_super/batch.css","startTime":785.7999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":785.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1014.1999999284744,"responseStart":0,"secureConnectionStart":0},{"duration":228.39999997615814,"initiatorType":"link","name":"https://issues.apache.org/jira/s/56490edcf9d54e35149505f78cca6a47-CDN/xd97tr/820010/13pdxe5/72cb823bcc50211a60c1ebe830467cae/_/download/contextbatch/css/jira.browse.project,jira.view.issue,project.issue.navigator,atl.general,atl.global,jira.global,jira.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&richediton=true&slack-enabled=true","startTime":786.1000000238419,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":786.1000000238419,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1014.5,"responseStart":0,"secureConnectionStart":0},{"duration":341.5,"initiatorType":"script","name":"https://issues.apache.org/jira/s/5263129088916436ab9aeb2417075b3f-CDN/xd97tr/820010/13pdxe5/49fa3aa3d35a2cc689cbf274e66cc41a/_/download/contextbatch/js/_super/batch.js?locale=en-UK","startTime":786.3999999761581,"connectEnd":786.3999999761581,"connectStart":786.3999999761581,"domainLookupEnd":786.3999999761581,"domainLookupStart":786.3999999761581,"fetchStart":786.3999999761581,"redirectEnd":0,"redirectStart":0,"requestStart":786.3999999761581,"responseEnd":1127.8999999761581,"responseStart":1127.8999999761581,"secureConnectionStart":786.3999999761581},{"duration":1907.7000000476837,"initiatorType":"script","name":"https://issues.apache.org/jira/s/611c208bd094adb71a6f4f3e7f6fff3d-CDN/xd97tr/820010/13pdxe5/72cb823bcc50211a60c1ebe830467cae/_/download/contextbatch/js/jira.browse.project,jira.view.issue,project.issue.navigator,atl.general,atl.global,jira.global,jira.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en-UK&richediton=true&slack-enabled=true","startTime":786.7999999523163,"connectEnd":786.7999999523163,"connectStart":786.7999999523163,"domainLookupEnd":786.7999999523163,"domainLookupStart":786.7999999523163,"fetchStart":786.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":786.7999999523163,"responseEnd":2694.5,"responseStart":2694.5,"secureConnectionStart":786.7999999523163},{"duration":356,"initiatorType":"script","name":"https://issues.apache.org/jira/s/d41d8cd98f00b204e9800998ecf8427e-CDN/xd97tr/820010/13pdxe5/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":787,"connectEnd":787,"connectStart":787,"domainLookupEnd":787,"domainLookupStart":787,"fetchStart":787,"redirectEnd":0,"redirectStart":0,"requestStart":787,"responseEnd":1143,"responseStart":1143,"secureConnectionStart":787},{"duration":1917.5,"initiatorType":"script","name":"https://issues.apache.org/jira/s/d41d8cd98f00b204e9800998ecf8427e-CDN/xd97tr/820010/13pdxe5/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":787.1000000238419,"connectEnd":787.1000000238419,"connectStart":787.1000000238419,"domainLookupEnd":787.1000000238419,"domainLookupStart":787.1000000238419,"fetchStart":787.1000000238419,"redirectEnd":0,"redirectStart":0,"requestStart":787.1000000238419,"responseEnd":2704.600000023842,"responseStart":2704.600000023842,"secureConnectionStart":787.1000000238419},{"duration":356.60000002384186,"initiatorType":"link","name":"https://issues.apache.org/jira/s/981f587853769311cda7c3b845131a06-CDN/xd97tr/820010/13pdxe5/cb5a5495a038c0744457f25821ba9ee8/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":787.2999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":787.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1143.8999999761581,"responseStart":0,"secureConnectionStart":0},{"duration":356.2999999523163,"initiatorType":"script","name":"https://issues.apache.org/jira/rest/api/1.0/shortcuts/820010/5840efff50357da9055d4714dc0713f/shortcuts.js?context=issuenavigation&context=issueaction","startTime":787.3999999761581,"connectEnd":787.3999999761581,"connectStart":787.3999999761581,"domainLookupEnd":787.3999999761581,"domainLookupStart":787.3999999761581,"fetchStart":787.3999999761581,"redirectEnd":0,"redirectStart":0,"requestStart":787.3999999761581,"responseEnd":1143.6999999284744,"responseStart":1143.6000000238419,"secureConnectionStart":787.3999999761581},{"duration":328.60000002384186,"initiatorType":"link","name":"https://issues.apache.org/jira/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/xd97tr/820010/13pdxe5/efa42a25652b26dfd802540c024826b3/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-jira.view.issue,-project.issue.navigator/batch.css?jira.create.linked.issue=true&richediton=true","startTime":815.3999999761581,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":815.3999999761581,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1144,"responseStart":0,"secureConnectionStart":0},{"duration":332.7000000476837,"initiatorType":"script","name":"https://issues.apache.org/jira/s/efa8931cd5ac13ed95c56ca8a1dc1967-CDN/xd97tr/820010/13pdxe5/efa42a25652b26dfd802540c024826b3/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-jira.view.issue,-project.issue.navigator/batch.js?jira.create.linked.issue=true&locale=en-UK&richediton=true","startTime":815.6999999284744,"connectEnd":815.6999999284744,"connectStart":815.6999999284744,"domainLookupEnd":815.6999999284744,"domainLookupStart":815.6999999284744,"fetchStart":815.6999999284744,"redirectEnd":0,"redirectStart":0,"requestStart":815.6999999284744,"responseEnd":1148.3999999761581,"responseStart":1148.3999999761581,"secureConnectionStart":815.6999999284744},{"duration":2159.5,"initiatorType":"script","name":"https://issues.apache.org/jira/s/d41d8cd98f00b204e9800998ecf8427e-CDN/xd97tr/820010/13pdxe5/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":933.3999999761581,"connectEnd":933.3999999761581,"connectStart":933.3999999761581,"domainLookupEnd":933.3999999761581,"domainLookupStart":933.3999999761581,"fetchStart":933.3999999761581,"redirectEnd":0,"redirectStart":0,"requestStart":933.3999999761581,"responseEnd":3092.899999976158,"responseStart":3092.899999976158,"secureConnectionStart":933.3999999761581},{"duration":2201.7999999523163,"initiatorType":"script","name":"https://issues.apache.org/jira/s/d41d8cd98f00b204e9800998ecf8427e-CDN/xd97tr/820010/13pdxe5/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":933.3999999761581,"connectEnd":933.3999999761581,"connectStart":933.3999999761581,"domainLookupEnd":933.3999999761581,"domainLookupStart":933.3999999761581,"fetchStart":933.3999999761581,"redirectEnd":0,"redirectStart":0,"requestStart":933.3999999761581,"responseEnd":3135.1999999284744,"responseStart":3135.1999999284744,"secureConnectionStart":933.3999999761581},{"duration":1410.1999999284744,"initiatorType":"xmlhttprequest","name":"https://issues.apache.org/jira/rest/webResources/1.0/resources","startTime":1295.1000000238419,"connectEnd":1295.1000000238419,"connectStart":1295.1000000238419,"domainLookupEnd":1295.1000000238419,"domainLookupStart":1295.1000000238419,"fetchStart":1295.1000000238419,"redirectEnd":0,"redirectStart":0,"requestStart":1295.1000000238419,"responseEnd":2705.2999999523163,"responseStart":2705.2999999523163,"secureConnectionStart":1295.1000000238419},{"duration":1313.7999999523163,"initiatorType":"script","name":"https://issues.apache.org/jira/s/d41d8cd98f00b204e9800998ecf8427e-CDN/xd97tr/820010/13pdxe5/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&richediton=true&slack-enabled=true","startTime":2799.5,"connectEnd":2799.5,"connectStart":2799.5,"domainLookupEnd":2799.5,"domainLookupStart":2799.5,"fetchStart":2799.5,"redirectEnd":0,"redirectStart":0,"requestStart":2799.5,"responseEnd":4113.299999952316,"responseStart":4113.299999952316,"secureConnectionStart":2799.5}],"fetchStart":0,"domainLookupStart":333,"domainLookupEnd":418,"connectStart":418,"connectEnd":643,"secureConnectionStart":528,"requestStart":643,"responseStart":777,"responseEnd":931,"domLoading":781,"domInteractive":4683,"domContentLoadedEventStart":4683,"domContentLoadedEventEnd":4769,"domComplete":4881,"loadEventStart":4881,"loadEventEnd":4885,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":4606.100000023842},{"name":"bigPipe.sidebar-id.end","time":4606.899999976158},{"name":"bigPipe.activity-panel-pipe-id.start","time":4607.100000023842},{"name":"bigPipe.activity-panel-pipe-id.end","time":4609.600000023842},{"name":"activityTabFullyLoaded","time":4789.299999952316}],"measures":[],"correlationId":"a9b6dd3019b1c1","effectiveType":"4g","downlink":9.7,"rtt":0,"serverDuration":126,"dbReadsTimeInMs":4,"dbConnsTimeInMs":13,"applicationHash":"ace47f9899e9ee25d7157d59aa17ab06aee30d3d","experiments":[]}}
HBASE-18493This message was automatically generated.