Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-18493

[AMv2] On region server crash do not process system table regions through AssignmentManager.checkIfShouldMoveSystemRegionAsync()

Details

    • Bug
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • 2.0.0
    • 2.0.0
    • amv2
    • None
    • Reviewed

    Description

      On Region Server crash, as ServerCrashProcedure handles reassignment of all the regions on a crashed server, don't process those regions through AssignmentManager.checkIfShouldMoveSystemRegionAsync(). This avoids duplicate and makes ServerCrashProcedure as one place to find all related code for handling server crash.

      Attachments

        1. hbase-18493.master.001.patch
          2 kB
          Umesh Agashe

        Issue Links

          Activity

            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 17s Docker mode activated.
            +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
            +1 @author 0m 0s The patch does not contain any @author tags.
            -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
            +1 mvninstall 3m 35s master passed
            +1 compile 0m 39s master passed
            +1 checkstyle 0m 50s master passed
            +1 mvneclipse 0m 15s master passed
            +1 findbugs 3m 17s master passed
            +1 javadoc 0m 30s master passed
            +1 mvninstall 0m 46s the patch passed
            +1 compile 0m 39s the patch passed
            +1 javac 0m 39s the patch passed
            +1 checkstyle 0m 47s the patch passed
            +1 mvneclipse 0m 14s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 hadoopcheck 32m 24s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
            +1 findbugs 4m 12s the patch passed
            +1 javadoc 0m 29s the patch passed
            +1 unit 116m 56s hbase-server in the patch passed.
            +1 asflicense 0m 17s The patch does not generate ASF License warnings.
            166m 32s



            Subsystem Report/Notes
            Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1
            JIRA Issue HBASE-18493
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882010/hbase-18493.master.001.patch
            Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
            uname Linux 16489d463772 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
            git revision master / 63e313b
            Default Java 1.8.0_144
            findbugs v3.1.0-RC3
            Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8099/testReport/
            modules C: hbase-server U: hbase-server
            Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8099/console
            Powered by Apache Yetus 0.4.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 35s master passed +1 compile 0m 39s master passed +1 checkstyle 0m 50s master passed +1 mvneclipse 0m 15s master passed +1 findbugs 3m 17s master passed +1 javadoc 0m 30s master passed +1 mvninstall 0m 46s the patch passed +1 compile 0m 39s the patch passed +1 javac 0m 39s the patch passed +1 checkstyle 0m 47s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 32m 24s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. +1 findbugs 4m 12s the patch passed +1 javadoc 0m 29s the patch passed +1 unit 116m 56s hbase-server in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 166m 32s Subsystem Report/Notes Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 JIRA Issue HBASE-18493 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882010/hbase-18493.master.001.patch Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 16489d463772 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 63e313b Default Java 1.8.0_144 findbugs v3.1.0-RC3 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8099/testReport/ modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8099/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
            stack Michael Stack added a comment -

            Pushed. Thanks uagashe

            stack Michael Stack added a comment - Pushed. Thanks uagashe
            hudson Hudson added a comment -

            FAILURE: Integrated in Jenkins build HBase-2.0 #341 (See https://builds.apache.org/job/HBase-2.0/341/)
            HBASE-18493 [AMv2] Skipped re-assignment of regions on crashed server (stack: rev 53c5bcc5827217bfa05136bd14b78fde93529783)

            • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
            hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-2.0 #341 (See https://builds.apache.org/job/HBase-2.0/341/ ) HBASE-18493 [AMv2] Skipped re-assignment of regions on crashed server (stack: rev 53c5bcc5827217bfa05136bd14b78fde93529783) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
            hudson Hudson added a comment -

            FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3544 (See https://builds.apache.org/job/HBase-Trunk_matrix/3544/)
            HBASE-18493 [AMv2] Skipped re-assignment of regions on crashed server (stack: rev acf9b87dca2cd190f4b5318efd5dc48e19b317f4)

            • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
            hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3544 (See https://builds.apache.org/job/HBase-Trunk_matrix/3544/ ) HBASE-18493 [AMv2] Skipped re-assignment of regions on crashed server (stack: rev acf9b87dca2cd190f4b5318efd5dc48e19b317f4) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
            hudson Hudson added a comment -

            FAILURE: Integrated in Jenkins build HBASE-14070.HLC #233 (See https://builds.apache.org/job/HBASE-14070.HLC/233/)
            HBASE-18493 [AMv2] Skipped re-assignment of regions on crashed server (stack: rev acf9b87dca2cd190f4b5318efd5dc48e19b317f4)

            • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
            hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBASE-14070 .HLC #233 (See https://builds.apache.org/job/HBASE-14070.HLC/233/ ) HBASE-18493 [AMv2] Skipped re-assignment of regions on crashed server (stack: rev acf9b87dca2cd190f4b5318efd5dc48e19b317f4) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java

            People

              uagashe Umesh Agashe
              uagashe Umesh Agashe
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: