[HBASE-18389] Remove byte[] from formal parameter of sizeOf() of ClassSize, ClassSize.MemoryLayout and ClassSize.UnsafeLayout

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.0.0-alpha-2, 2.0.0
• Component/s: util
• Hadoop Flags: Reviewed
• Assignee: Xiang Li
• Reporter: Xiang Li
• Created: 17/Jul/17 03:48
• Updated: 21/Mar/18 22:08
• Resolved: 21/Jul/17 18:17

Description

In ClassSize class and its internal static class, sizeOf() function has 2 formal parameters: byte[] b and int len. But the function's internal logic does not use or refer to byte[] b. Could be removed.

hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java

// Class of ClassSize
public static long sizeOf(byte[] b, int len) {
  return memoryLayout.sizeOf(b, len);
}

// Class of ClassSize.MemoryLayout
long sizeOf(byte[] b, int len) {
  return align(arrayHeaderSize() + len);
}

// Class of ClassSize.UnsafeLayout
long sizeOf(byte[] b, int len) {
  return align(arrayHeaderSize() + len * UnsafeAccess.theUnsafe.ARRAY_BYTE_INDEX_SCALE);
}