[HBASE-18274] hbase autorestart will overwrite the gc log

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.6, 1.1.11, 2.0.0-alpha-1
• Fix Version/s: 2.0.0-alpha-2, 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Fangyuan Deng
• Reporter: Fangyuan Deng
• Created: 27/Jun/17 13:16
• Updated: 01/Aug/18 06:21
• Resolved: 27/Jun/17 15:09

Description

While using hbase autorestart , the gc log will be overwirited after the process(hmaster or hregionserver) retarting.

This is because the autorestart loop is in internal_autostart function ( in hbase-daemon.sh), but we only rotate the gc log in autorestart function.

(internal_autostart)
ONE_HOUR_IN_SECS=3600
autostartWindowStartDate=`date +%s`
autostartCount=0
touch "$HBASE_AUTOSTART_FILE"

1. keep starting the command until asked to stop. Reloop on software crash
   while true
   do
   code # restart the hbase process util the cluster is shut down
   fi

(autorestart)
echo running $command, logging to $HBASE_LOGOUT

1. stop the command
   $thiscmd --config "${HBASE_CONF_DIR}" stop $command $args &
   wait_until_done $!
2. wait a user-specified sleep period
   sp=${HBASE_RESTART_SLEEP:-3}
   if [ $sp -gt 0 ]; then
   sleep $sp
   fi

check_before_start
hbase_rotate_log $HBASE_LOGOUT
hbase_rotate_log $HBASE_LOGGC
nohup $thiscmd --config "${HBASE_CONF_DIR}" --autostart-window-size ${AUTOSTART_WINDOW_SIZE} --autostart-window-retry-limit ${AUTOSTART_WINDOW_RETRY_LIMIT} \
internal_autostart $command $args < /dev/null > ${HBASE_LOGOUT} 2>&1 &