[HBASE-18273] hbase_rotate_log in hbase-daemon.sh script not working for some JDK

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 1.2.6, 1.1.11, 2.0.0-alpha-1
• Assignee: Fangyuan Deng
• Reporter: Fangyuan Deng
• Created: 27/Jun/17 13:03
• Updated: 17/Jul/19 20:22
• Resolved: 17/Jul/19 20:22

Description

When restarting a hbase process, hbase_rotate_log $HBASE_LOGGC will rotate GC logs.
the code looks like this,

if [ -f "$log" ]; then # rotate logs
while [ $num -gt 1 ]; do
prev=`expr $num - 1`
[ -f "$log.$prev" ] && mv -f "$log.$prev" "$log.$num"
num=$prev
done

But, some version JDK will add a suffix (.0) to the gc file, like hbase-xxx.gc.0, rather than hbase-xxx.gc.

So I add a check before rotate,

if [ ! -f "$log" ]; then #for some jdk, gc log has a postfix 0
if [ -f "$log.0" ]; then
mv -f "$log.0" "$log";
fi
fi