Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-18149

The setting rules for table-scope attributes and family-scope attributes should keep consistent

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.2.5, 2.0.0
    • 1.4.0, 2.0.0
    • shell
    • None
    • Reviewed
    • If the table-scope attributes value is false, you need not to enclose 'false' in single quotation.Both COMPACTION_ENABLED => false and COMPACTION_ENABLED => 'false' will take effect

    Description

      I use the following command to create a table.

      hbase(main):030:0> create 't3',{NAME => 'f2', BLOCKCACHE => false}, {COMPACTION_ENABLED => false}
      An argument ignored (unknown or overridden): COMPACTION_ENABLED
      0 row(s) in 1.1390 seconds
      
      hbase(main):031:0> describe 't3'
      Table t3 is ENABLED
      t3                                                                                                                                                                                           
      COLUMN FAMILIES DESCRIPTION                                                                                                                                                                  
      {NAME => 'f2', BLOOMFILTER => 'ROW', VERSIONS => '1', IN_MEMORY => 'false', KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', TTL => 'FOREVER', COMPRESSION => 'NONE', MIN_VERSIONS => '0', BLOCKCACHE => 'false', BLOCKSIZE => '65536', REPLICATION_SCOPE => '0'}
      1 row(s) in 0.0720 seconds
      

      BLOCKCACHE was in effect but COMPACTION_ENABLED didn't take effect.
      After checking code, I found that if the table-scope attributes value is false, you need to enclose 'false' in single quotation marks while family-scope is not required.
      so we should keep the consistent logic for table-scope and family-scope.
      the command alter also have the same problem.

      Attachments

        1. HBASE-18149-master-v1.patch
          6 kB
          Guangxu Cheng
        2. HBASE-18149-branch-1-v1.patch
          6 kB
          Guangxu Cheng
        3. HBASE-18149-master-v2.patch
          6 kB
          Guangxu Cheng

        Activity

          People

            gxcheng Guangxu Cheng
            gxcheng Guangxu Cheng
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: