Details
-
Sub-task
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
None
-
None
-
Reviewed
Description
For now we just close the connection so NettyRpcServer can not pass TestIPC.
Attachments
Attachments
- HBASE-18112.addendum.patch
- 1 kB
- Chia-Ping Tsai
- HBASE-18112-v5.patch
- 32 kB
- Toshihiro Suzuki
- HBASE-18112-v4.patch
- 31 kB
- Duo Zhang
- HBASE-18112-v4.patch
- 31 kB
- Toshihiro Suzuki
- HBASE-18112-v3.patch
- 31 kB
- Duo Zhang
- HBASE-18112-v3.patch
- 31 kB
- Toshihiro Suzuki
- HBASE-18112-v2.patch
- 31 kB
- Toshihiro Suzuki
- HBASE-18112-v2.patch
- 31 kB
- Toshihiro Suzuki
- HBASE-18112-v2.patch
- 31 kB
- Toshihiro Suzuki
- HBASE-18112.patch
- 31 kB
- Toshihiro Suzuki
Issue Links
- links to
Activity
I just attached the patch.
To handle RequestTooBigException, I created NettyRpcFrameDecoder class and use it instead of LengthFieldBasedFrameDecoder.
Can you please review my patch Apache9?
Could you please upload the patch to review board http://reviews.apache.org/ ?
And I think the approach is correct, LengthFieldBasedFrameDecoder just discards the large frame so it is not possible for us to send back useful information to client.
Thanks.
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 18s | Docker mode activated. |
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
+1 | mvninstall | 3m 40s | master passed |
+1 | compile | 0m 37s | master passed |
+1 | checkstyle | 0m 44s | master passed |
+1 | mvneclipse | 0m 16s | master passed |
+1 | findbugs | 2m 14s | master passed |
+1 | javadoc | 0m 27s | master passed |
+1 | mvninstall | 0m 44s | the patch passed |
+1 | compile | 0m 38s | the patch passed |
+1 | javac | 0m 38s | the patch passed |
+1 | checkstyle | 0m 44s | the patch passed |
+1 | mvneclipse | 0m 16s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | hadoopcheck | 32m 25s | Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. |
+1 | findbugs | 2m 9s | the patch passed |
+1 | javadoc | 0m 27s | the patch passed |
+1 | unit | 93m 22s | hbase-server in the patch passed. |
+1 | asflicense | 0m 16s | The patch does not generate ASF License warnings. |
139m 36s |
Subsystem | Report/Notes |
---|---|
Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:5d60123 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12886298/HBASE-18112.patch |
Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile |
uname | Linux 1b4a797effd0 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / 966f5ca |
Default Java | 1.8.0_144 |
findbugs | v3.1.0-RC3 |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/8541/testReport/ |
modules | C: hbase-server U: hbase-server |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/8541/console |
Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 20s | Docker mode activated. |
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
+1 | mvninstall | 3m 56s | master passed |
+1 | compile | 0m 39s | master passed |
+1 | checkstyle | 0m 46s | master passed |
+1 | mvneclipse | 0m 16s | master passed |
+1 | shadedjars | 4m 58s | branch has no errors when building our shaded downstream artifacts. |
+1 | findbugs | 2m 9s | master passed |
+1 | javadoc | 0m 28s | master passed |
+1 | mvninstall | 0m 44s | the patch passed |
+1 | compile | 0m 37s | the patch passed |
+1 | javac | 0m 37s | the patch passed |
+1 | checkstyle | 0m 44s | the patch passed |
+1 | mvneclipse | 0m 16s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 3m 57s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 36m 23s | Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. |
+1 | findbugs | 2m 13s | the patch passed |
+1 | javadoc | 0m 28s | the patch passed |
-1 | unit | 90m 17s | hbase-server in the patch failed. |
+1 | asflicense | 0m 16s | The patch does not generate ASF License warnings. |
144m 49s |
Reason | Tests |
---|---|
Timed out junit tests | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
org.apache.hadoop.hbase.master.TestMasterFailover | |
org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 | |
org.apache.hadoop.hbase.master.TestAssignmentManagerMetrics | |
org.apache.hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster | |
org.apache.hadoop.hbase.master.TestMasterWalManager | |
org.apache.hadoop.hbase.master.TestSplitLogManager | |
org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport | |
org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer | |
org.apache.hadoop.hbase.master.TestCatalogJanitorInMemoryStates | |
org.apache.hadoop.hbase.master.TestMaster | |
org.apache.hadoop.hbase.master.balancer.TestRegionsOnMasterOptions | |
org.apache.hadoop.hbase.master.TestMetaShutdownHandler |
Subsystem | Report/Notes |
---|---|
Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:5d60123 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12886591/HBASE-18112-v2.patch |
Optional Tests | asflicense shadedjars javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile |
uname | Linux 07d303e9d6dc 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh |
git revision | master / 58bfa13 |
Default Java | 1.8.0_144 |
findbugs | v3.1.0-RC3 |
unit | https://builds.apache.org/job/PreCommit-HBASE-Build/8579/artifact/patchprocess/patch-unit-hbase-server.txt |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/8579/testReport/ |
modules | C: hbase-server U: hbase-server |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/8579/console |
Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 0s | Docker mode activated. |
-1 | patch | 0m 5s | |
Subsystem | Report/Notes |
---|---|
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12887228/HBASE-18112-v2.patch |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/8633/console |
Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 26s | Docker mode activated. |
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
+1 | mvninstall | 4m 4s | master passed |
+1 | compile | 0m 36s | master passed |
+1 | checkstyle | 0m 44s | master passed |
+1 | mvneclipse | 0m 15s | master passed |
+1 | shadedjars | 4m 58s | branch has no errors when building our shaded downstream artifacts. |
+1 | findbugs | 2m 12s | master passed |
+1 | javadoc | 0m 29s | master passed |
+1 | mvninstall | 0m 44s | the patch passed |
+1 | compile | 0m 38s | the patch passed |
+1 | javac | 0m 38s | the patch passed |
+1 | checkstyle | 0m 44s | the patch passed |
+1 | mvneclipse | 0m 15s | the patch passed |
+1 | whitespace | 0m 1s | The patch has no whitespace issues. |
+1 | shadedjars | 3m 54s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 36m 49s | Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. |
+1 | findbugs | 2m 31s | the patch passed |
+1 | javadoc | 0m 27s | the patch passed |
+1 | unit | 92m 12s | hbase-server in the patch passed. |
+1 | asflicense | 0m 15s | The patch does not generate ASF License warnings. |
147m 43s |
Subsystem | Report/Notes |
---|---|
Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:5d60123 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12887238/HBASE-18112-v3.patch |
Optional Tests | asflicense shadedjars javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile |
uname | Linux c10df7359f49 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / fb3c8bf |
Default Java | 1.8.0_144 |
findbugs | v3.1.0-RC3 |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/8634/testReport/ |
modules | C: hbase-server U: hbase-server |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/8634/console |
Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
I updated the Diff in review board. https://reviews.apache.org/r/62207/
Could you please review the v3 patch Apache9, tedyu?
Hi Apache9, could you please review the latest patch? If I'm wrong with the review process, please let me know.
Sorry do not have enough cycles to do reviewing...
Busy with releasing 2.0.0-alpha4. Will take a look after the release.
Thanks.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 11s | Docker mode activated. |
Prechecks | |||
0 | findbugs | 0m 0s | Findbugs executables are not available. |
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
master Compile Tests | |||
+1 | mvninstall | 4m 40s | master passed |
+1 | compile | 0m 44s | master passed |
+1 | checkstyle | 1m 3s | master passed |
+1 | shadedjars | 6m 6s | branch has no errors when building our shaded downstream artifacts. |
+1 | javadoc | 0m 29s | master passed |
Patch Compile Tests | |||
-1 | mvninstall | 1m 58s | root in the patch failed. |
-1 | compile | 0m 34s | hbase-server in the patch failed. |
-1 | javac | 0m 34s | hbase-server in the patch failed. |
-1 | checkstyle | 1m 6s | hbase-server: The patch generated 10 new + 6 unchanged - 1 fixed = 16 total (was 7) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
-1 | shadedjars | 3m 15s | patch has 17 errors when building our shaded downstream artifacts. |
-1 | hadoopcheck | 4m 54s | The patch causes 18 errors with Hadoop v2.6.1. |
-1 | hadoopcheck | 6m 35s | The patch causes 18 errors with Hadoop v2.6.2. |
-1 | hadoopcheck | 8m 10s | The patch causes 18 errors with Hadoop v2.6.3. |
-1 | hadoopcheck | 9m 51s | The patch causes 18 errors with Hadoop v2.6.4. |
-1 | hadoopcheck | 11m 31s | The patch causes 18 errors with Hadoop v2.6.5. |
-1 | hadoopcheck | 13m 4s | The patch causes 18 errors with Hadoop v2.7.1. |
-1 | hadoopcheck | 14m 43s | The patch causes 18 errors with Hadoop v2.7.2. |
-1 | hadoopcheck | 16m 23s | The patch causes 18 errors with Hadoop v2.7.3. |
-1 | hadoopcheck | 17m 59s | The patch causes 18 errors with Hadoop v2.7.4. |
-1 | hadoopcheck | 19m 43s | The patch causes 18 errors with Hadoop v3.0.0-alpha4. |
+1 | javadoc | 0m 29s | the patch passed |
Other Tests | |||
-1 | unit | 0m 35s | hbase-server in the patch failed. |
+1 | asflicense | 0m 11s | The patch does not generate ASF License warnings. |
36m 58s |
This message was automatically generated.
Seems the pre commit job is broken and It's thanks-giving is the US so let's wait a while... Maybe Monday they will fix the job.
Thanks for your patience brfrn169.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 1m 51s | Docker mode activated. |
Prechecks | |||
0 | findbugs | 0m 0s | Findbugs executables are not available. |
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
master Compile Tests | |||
+1 | mvninstall | 4m 28s | master passed |
+1 | compile | 0m 40s | master passed |
+1 | checkstyle | 1m 2s | master passed |
+1 | shadedjars | 5m 54s | branch has no errors when building our shaded downstream artifacts. |
+1 | javadoc | 0m 29s | master passed |
Patch Compile Tests | |||
+1 | mvninstall | 5m 19s | the patch passed |
+1 | compile | 0m 44s | the patch passed |
+1 | javac | 0m 44s | the patch passed |
-1 | checkstyle | 1m 4s | hbase-server: The patch generated 11 new + 6 unchanged - 1 fixed = 17 total (was 7) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 4m 56s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 55m 10s | Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. |
+1 | javadoc | 0m 31s | the patch passed |
Other Tests | |||
+1 | unit | 106m 41s | hbase-server in the patch passed. |
+1 | asflicense | 0m 18s | The patch does not generate ASF License warnings. |
183m 24s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12899388/HBASE-18112-v4.patch |
Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
uname | Linux a6030a8e3a49 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / f521000d78 |
maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
Default Java | 1.8.0_151 |
checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/10031/artifact/patchprocess/diff-checkstyle-hbase-server.txt |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/10031/testReport/ |
modules | C: hbase-server U: hbase-server |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/10031/console |
Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 0s | Docker mode activated. |
-1 | patch | 0m 5s | |
Subsystem | Report/Notes |
---|---|
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12899944/HBASE-18112-v5.patch |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/10134/console |
Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
I submitted a wrong patch mistakenly. I just resubmitted the correct patch.
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 2m 19s | Docker mode activated. |
Prechecks | |||
0 | findbugs | 0m 0s | Findbugs executables are not available. |
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
master Compile Tests | |||
+1 | mvninstall | 4m 49s | master passed |
+1 | compile | 0m 41s | master passed |
+1 | checkstyle | 1m 2s | master passed |
+1 | shadedjars | 5m 54s | branch has no errors when building our shaded downstream artifacts. |
+1 | javadoc | 0m 26s | master passed |
Patch Compile Tests | |||
+1 | mvninstall | 4m 32s | the patch passed |
+1 | compile | 0m 41s | the patch passed |
+1 | javac | 0m 41s | the patch passed |
+1 | checkstyle | 1m 2s | hbase-server: The patch generated 0 new + 6 unchanged - 1 fixed = 6 total (was 7) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 4m 56s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 51m 27s | Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. |
+1 | javadoc | 0m 31s | the patch passed |
Other Tests | |||
+1 | unit | 90m 2s | hbase-server in the patch passed. |
+1 | asflicense | 0m 20s | The patch does not generate ASF License warnings. |
162m 59s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12899948/HBASE-18112-v5.patch |
Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
uname | Linux e96f96761021 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / 79a89beb2e |
maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
Default Java | 1.8.0_151 |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/10135/testReport/ |
modules | C: hbase-server U: hbase-server |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/10135/console |
Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
SUCCESS: Integrated in Jenkins build HBase-2.0 #941 (See https://builds.apache.org/job/HBase-2.0/941/)
HBASE-18112 Write RequestTooBigException back to client for (zhangduo: rev 29079886caddc85f6953cd07f1afaded5086f7db)
- (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java
- (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerPreambleHandler.java
- (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestBlockingIPC.java
- (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java
- (add) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcFrameDecoder.java
- (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestNettyIPC.java
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4143 (See https://builds.apache.org/job/HBase-Trunk_matrix/4143/)
HBASE-18112 Write RequestTooBigException back to client for (zhangduo: rev 9692b61a0ab572d0d37e01bd262700995e675975)
- (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java
- (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestBlockingIPC.java
- (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestNettyIPC.java
- (add) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcFrameDecoder.java
- (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerPreambleHandler.java
- (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java
int frameLengthInt = (int) frameLength; if (in.readableBytes() < frameLengthInt) { // here return; } in.skipBytes(FRAME_LENGTH_FIELD_LENGTH);
The bounds check should consider the FRAME_LENGTH_FIELD_LENGTH as the index will be moved later.
This bugs result in some failed tests after stack makes netty engine default in hbase2 (HBASE-19323)
Will take a look soon. I haven’t reviewed this part very carefully as I think it is just a copy of the code in LengthFieldXXXDecoder.
Thanks for finding this chia7712 .
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 9s | Docker mode activated. |
Prechecks | |||
0 | findbugs | 0m 0s | Findbugs executables are not available. |
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
-1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
master Compile Tests | |||
+1 | mvninstall | 4m 33s | master passed |
+1 | compile | 0m 41s | master passed |
+1 | checkstyle | 1m 2s | master passed |
+1 | shadedjars | 5m 26s | branch has no errors when building our shaded downstream artifacts. |
+1 | javadoc | 0m 26s | master passed |
Patch Compile Tests | |||
+1 | mvninstall | 4m 31s | the patch passed |
+1 | compile | 0m 40s | the patch passed |
+1 | javac | 0m 40s | the patch passed |
+1 | checkstyle | 1m 3s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 4m 28s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 51m 7s | Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. |
+1 | javadoc | 0m 27s | the patch passed |
Other Tests | |||
+1 | unit | 94m 25s | hbase-server in the patch passed. |
+1 | asflicense | 0m 18s | The patch does not generate ASF License warnings. |
163m 57s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12900840/HBASE-18112.addendum.patch |
Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
uname | Linux c611fa3799c8 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / 75cdbb5700 |
maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
Default Java | 1.8.0_151 |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/10256/testReport/ |
modules | C: hbase-server U: hbase-server |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/10256/console |
Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
I think the approach here is correct. +1.
And mind also doing a simplification?
// extract frame int readerIndex = in.readerIndex(); ByteBuf frame = in.retainedSlice(readerIndex, frameLengthInt); in.readerIndex(readerIndex + frameLengthInt); out.add(frame);
Can be simplified to
// extract frame
out.add(in.readRetainedSlice(frameLengthInt));
Thanks.
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4180 (See https://builds.apache.org/job/HBase-Trunk_matrix/4180/)
HBASE-18112 (addendum) fix the out-of-bounds index (chia7712: rev ebd8841e0ee9ca1ab7b6dab55178761360b8d85a)
- (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcFrameDecoder.java
Can I try this? Apache9