[HBASE-17872] The MSLABImpl generates the invaild cells when unsafe is not availble

• Type: Sub-task
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Chia-Ping Tsai
• Reporter: Chia-Ping Tsai
• Created: 04/Apr/17 10:12
• Updated: 30/Apr/17 22:22
• Resolved: 09/Apr/17 15:37

Description

We will get the wrong position of buffer in multithreaded environment, so the method makes the invalid cell in MSLAB.

  public static int copyFromBufferToBuffer(ByteBuffer in, ByteBuffer out, int sourceOffset,
      int destinationOffset, int length) {
    if (in.hasArray() && out.hasArray()) {
      // ...
    } else if (UNSAFE_AVAIL) {
      // ...
    } else {
      int outOldPos = out.position();
      out.position(destinationOffset);
      ByteBuffer inDup = in.duplicate();
      inDup.position(sourceOffset).limit(sourceOffset + length);
      out.put(inDup);
      out.position(outOldPos);
    }
    return destinationOffset + length;
  }