[HBASE-17706] TableSkewCostFunction improperly computes max skew

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.2.0
• Fix Version/s: 2.0.0
• Component/s: Balancer
• Labels: patch

Environment

CentOS Derivative with a derivative of the 3.18.43 kernel. HBase on CDH5.9.0 with some patches. HDFS CDH 5.9.0 with no patches.

• Flags: Patch
• Assignee: Kahlil Oppenheimer
• Reporter: Kahlil Oppenheimer
• Created: 28/Feb/17 04:40
• Updated: 31/Oct/17 23:38
• Resolved: 31/Oct/17 23:38

Description

We noticed while running unit tests that the TableSkewCostFunction computed cost did not change as the balancer ran and simulated moves across the cluster. After investigating, we found that this happened in particular when the cluster started out with at least one table very strongly skewed.

We noticed that the TableSkewCostFunction depends on a field of the BaseLoadBalancer.Cluster class called numMaxRegionsPerTable, but this field is not properly maintained as regionMoves are simulated for the cluster. The field only ever increases as the maximum number of regions per table increases, but it does not decrease as the maximum number per table goes down.

This patch corrects that behavior so that the field is accurately maintained, and thus the TableSkewCostFunction produces a more correct value as the balancer runs.

Issue Links

• is related to: HBASE-18480 The cost of BaseLoadBalancer.cluster is changed even if the rollback is done
• relates to: HBASE-17707 New More Accurate Table Skew cost function/generator