Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-17613

avoid copy of family when initializing the FSWALEntry

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 2.0.0
    • None
    • None
    • Reviewed

    Description

      We should compare the families before cloning it.

      Set<byte[]> familySet = Sets.newTreeSet(Bytes.BYTES_COMPARATOR);
      for (Cell cell : cells) {
        if (!CellUtil.matchingFamily(cell, WALEdit.METAFAMILY)) {
        // TODO: Avoid this clone?
          familySet.add(CellUtil.cloneFamily(cell));
        }
      }
      

      Attachments

        1. HBASE-17613.v0.patch
          6 kB
          Chia-Ping Tsai
        2. HBASE-17613.v1.patch
          6 kB
          Chia-Ping Tsai
        3. HBASE-17613.v2.patch
          6 kB
          Chia-Ping Tsai
        4. HBASE-17613.v2.patch
          6 kB
          Chia-Ping Tsai

        Activity

          People

            chia7712 Chia-Ping Tsai
            chia7712 Chia-Ping Tsai
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: