[HBASE-17347] ExportSnapshot may write snapshot info file to wrong directory when specifying target name

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 1.4.0, 2.0.0
• Component/s: snapshots
• Hadoop Flags: Reviewed
• Assignee: Jianwei Cui
• Reporter: Jianwei Cui
• Created: 20/Dec/16 13:50
• Updated: 21/Dec/16 02:39
• Resolved: 20/Dec/16 23:59

Description

Exportsnapshot will write a new snapshot info file when specifying the target name:

    if (!targetName.equals(snapshotName)) {
      SnapshotDescription snapshotDesc =
        SnapshotDescriptionUtils.readSnapshotInfo(inputFs, snapshotDir)
          .toBuilder()
          .setName(targetName)
          .build();
      SnapshotDescriptionUtils.writeSnapshotInfo(snapshotDesc, snapshotTmpDir, outputFs);
    }

The snapshot info file will be written to the snapshot tmp directory, however, it should be directly written to the snapshot directory if snapshot.export.skip.tmp is true. In addition, owner and permission should be set for the new snapshot info file when needed.