Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-17291

Remove ImmutableSegment#getKeyValueScanner

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.0.0
    • 2.0.0
    • Scanners
    • None
    • Reviewed

    Description

      This is based on a discussion over anastas's patch. The MemstoreSnapshot uses a KeyValueScanner which actually seems redundant considering we already have a SegmentScanner. The idea is that the snapshot scanner should be a simple iterator type of scanner but it lacks the capability to do the reference counting on that segment that is now used in snapshot. With snapshot having mulitple segments in the latest impl it is better we hold on to the segment by doing ref counting.

      Attachments

        1. HBASE-17291_1.patch
          12 kB
          ramkrishna.s.vasudevan
        2. HBASE-17291_2.patch
          22 kB
          ramkrishna.s.vasudevan
        3. HBASE-17291_3.patch
          19 kB
          ramkrishna.s.vasudevan
        4. HBASE-17291.patch
          10 kB
          ramkrishna.s.vasudevan

        Issue Links

          Activity

            People

              ram_krish ramkrishna.s.vasudevan
              ram_krish ramkrishna.s.vasudevan
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: