[HBASE-17235] Improvement in creation of CIS for onheap buffer cases

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Component/s: rpc
• Hadoop Flags: Reviewed
• Assignee: ramkrishna.s.vasudevan
• Reporter: ramkrishna.s.vasudevan
• Created: 02/Dec/16 07:33
• Updated: 02/Dec/16 19:49
• Resolved: 02/Dec/16 08:38

Description

      if (buf.hasArray()) {
        cis = CodedInputStream.newInstance(buf.array(), offset, buf.limit());
      } else {

Currently we do this for onheap buffers incase there is no reservoir or the size is less than the minSizeforReservoir. I could see that even if reservoir is there there are requests which goes with the above way of creating CIS. This could be made efficient to avoid underlying copies by just doing this

cis = UnsafeByteOperations.unsafeWrap(buf.array(), offset, buf.limit()).newCodedInput();