Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-17228

precommit grep -c ERROR may grab non errors

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 2.0.0
    • build, community, test
    • None

    Description

      it looks like that we do a simple "grep -c ERROR" to count the errors that we have from the build.
      https://github.com/apache/hbase/blob/master/dev-support/hbase-personality.sh#L305

      but in this way we ended up with a count=1 just because we have one enum called ERROR_CODE in hbase. and the enum shows up as debug message

      $ grep ERROR patch-hbaseprotoc-hbase-server.txt 
      [DEBUG] adding entry org/apache/hadoop/hbase/util/HBaseFsck$ErrorReporter$ERROR_CODE.class
      

      Attachments

        1. HBASE-17228.master.001.patch
          2 kB
          Michael Stack

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            stack Michael Stack
            mbertozzi Matteo Bertozzi
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment