Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-17064

Add TaskMonitor#getTasks() variant which accepts type selection

Log workAgile BoardRank to TopRank to BottomAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 2.0.0-alpha-2, 2.0.0
    • None
    • Reviewed

    Description

      In TaskMonitorTmpl.jamon :

      List<? extends MonitoredTask> tasks = taskMonitor.getTasks();
      Iterator<? extends MonitoredTask> iter = tasks.iterator();
      // apply requested filter
      while (iter.hasNext()) {
        MonitoredTask t = iter.next();
        if (filter.equals("general")) {
          if (t instanceof MonitoredRPCHandler)
            iter.remove();
      

      This means when user refreshes rs-status page, regardless of the type of filter, we always traverse and clone MonitoredTask's.

      getTasks() is synchronized :

        public synchronized List<MonitoredTask> getTasks() {
      

      A variant of getTasks() can be added which takes the type of filter so that unnecessary cloning is avoided.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            reidchan Reid Chan Assign to me
            yuzhihong@gmail.com Ted Yu
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment