Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-17056

Remove checked in PB generated files

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • 2.0.0
    • 2.0.0
    • None
    • None
    • Reviewed
    • Hide
      Purge all checked in generated protobuf files (30MB). Generate protobuf files inline with the build. Remove checked-in and patched protobuf. Get it from new hbase-thirdparty instead.

      Side-effect: Our protobuf went from 3.1.0 to 3.3.1.

      Build does not take noticeably longer (still about 2.5 minutes to do a mvn clean install -DskipTests).

      IDEs will probably require a mvn build first else they'll complain about missing (generated) files.
      Show
      Purge all checked in generated protobuf files (30MB). Generate protobuf files inline with the build. Remove checked-in and patched protobuf. Get it from new hbase-thirdparty instead. Side-effect: Our protobuf went from 3.1.0 to 3.3.1. Build does not take noticeably longer (still about 2.5 minutes to do a mvn clean install -DskipTests). IDEs will probably require a mvn build first else they'll complain about missing (generated) files.

    Description

      Now that we have the new PB maven plugin, there is no need to have the PB files checked in to the repo. The reason we did that was to ease up developer env setup.

      Attachments

        1. HBASE-17056.master.007.patch
          30.01 MB
          Michael Stack
        2. HBASE-17056.master.007.patch
          30.01 MB
          Michael Stack
        3. HBASE-17056.master.006.patch
          29.98 MB
          Michael Stack
        4. HBASE-17056.master.006.patch
          29.98 MB
          Michael Stack
        5. HBASE-17056.master.005.patch
          29.97 MB
          Michael Stack
        6. HBASE-17056.master.004.patch
          30.16 MB
          Michael Stack
        7. HBASE-17056.master.003.patch
          30.16 MB
          Michael Stack
        8. HBASE-17056.master.002.patch
          30.16 MB
          Michael Stack
        9. HBASE-17056.master.001.patch
          25.81 MB
          Michael Stack
        10. 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch
          1.25 MB
          Michael Stack

        Issue Links

          depends upon

          Sub-task - The sub-task of the issue HBASE-18240 Add hbase-thirdparty, a project with hbase utility including an hbase-shaded-thirdparty module with guava, netty, etc.

          • Major - Major loss of function.
          • Resolved
          is related to

          Task - A task that needs to be done. HBASE-17898 Update dependencies

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Activity

            People

              stack Michael Stack
              enis Enis Soztutar
              Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: