Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-16969

RegionCoprocessorServiceExec should override the toString() for debugging

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 1.3.0, 2.0.0
    • 1.4.0, 2.0.0
    • None
    • None

    Description

      The toString() method is used to log in BatchErrors#makeException.

      BatchErrors.java
      synchronized RetriesExhaustedWithDetailsException makeException(boolean logDetails) {
        if (logDetails) {LOG.error("Exception occurred! Exception details: " + throwables + ";\nActions: " + actions);
       }
      

      If RegionCoprocessorServiceExec doesn’t override the toString(), we will see the hash code in the log message. That message is useless for debugging.

      Attachments

        1. HBASE-16969.v1.patch
          2 kB
          Chia-Ping Tsai
        2. HBASE-16969.v1.patch
          2 kB
          Michael Stack
        3. HBASE-16969.v0.patch
          1.0 kB
          Chia-Ping Tsai
        4. HBASE-16969.branch-1.v0.patch
          2 kB
          Chia-Ping Tsai
        5. HBASE-16969.branch-1.v0.patch
          2 kB
          Chia-Ping Tsai
        6. HBASE-16969.branch-1.v0.patch
          2 kB
          Chia-Ping Tsai

        Activity

          People

            chia7712 Chia-Ping Tsai
            chia7712 Chia-Ping Tsai
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: