Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-16962

Add readPoint to preCompactScannerOpen() and preFlushScannerOpen() API

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.4.0, 2.0.0
    • None
    • None
    • Reviewed
    • Hide
      The following RegionObserver methods are deprecated

      InternalScanner preFlushScannerOpen(final ObserverContext<RegionCoprocessorEnvironment> c,
          final Store store, final KeyValueScanner memstoreScanner, final InternalScanner s)
          throws IOException;

      InternalScanner preCompactScannerOpen(final ObserverContext<RegionCoprocessorEnvironment> c,
          final Store store, List<? extends KeyValueScanner> scanners, final ScanType scanType,
          final long earliestPutTs, final InternalScanner s, CompactionRequest request)

      Instead, use the following methods:

      InternalScanner preFlushScannerOpen(final ObserverContext<RegionCoprocessorEnvironment> c,
          final Store store, final KeyValueScanner memstoreScanner, final InternalScanner s,
          final long readPoint) throws IOException;

      InternalScanner preCompactScannerOpen(final ObserverContext<RegionCoprocessorEnvironment> c,
          final Store store, List<? extends KeyValueScanner> scanners, final ScanType scanType,
          final long earliestPutTs, final InternalScanner s, final CompactionRequest request,
          final long readPoint) throws IOException
      Show
      The following RegionObserver methods are deprecated InternalScanner preFlushScannerOpen(final ObserverContext<RegionCoprocessorEnvironment> c,     final Store store, final KeyValueScanner memstoreScanner, final InternalScanner s)     throws IOException; InternalScanner preCompactScannerOpen(final ObserverContext<RegionCoprocessorEnvironment> c,     final Store store, List<? extends KeyValueScanner> scanners, final ScanType scanType,     final long earliestPutTs, final InternalScanner s, CompactionRequest request) Instead, use the following methods: InternalScanner preFlushScannerOpen(final ObserverContext<RegionCoprocessorEnvironment> c,     final Store store, final KeyValueScanner memstoreScanner, final InternalScanner s,     final long readPoint) throws IOException; InternalScanner preCompactScannerOpen(final ObserverContext<RegionCoprocessorEnvironment> c,     final Store store, List<? extends KeyValueScanner> scanners, final ScanType scanType,     final long earliestPutTs, final InternalScanner s, final CompactionRequest request,     final long readPoint) throws IOException

    Description

      Similar to HBASE-15759, I would like to add readPoint to the preCompactScannerOpen() API.

      I have a CP where I create a StoreScanner() as part of the preCompactScannerOpen() API. I need the readpoint which was obtained in Compactor.compact() method to be consistent.

      Attachments

        1. HBASE-16962.rough.patch
          8 kB
          Thiruvel Thirumoolan
        2. HBASE-16962.master.004.patch
          16 kB
          Thiruvel Thirumoolan
        3. HBASE-16962.master.003.patch
          16 kB
          Thiruvel Thirumoolan
        4. HBASE-16962.master.002.patch
          15 kB
          Thiruvel Thirumoolan
        5. HBASE-16962.master.001.patch
          10 kB
          Thiruvel Thirumoolan
        6. HBASE-16956.master.006.patch
          14 kB
          Thiruvel Thirumoolan
        7. HBASE-16956.branch-1.001.patch
          14 kB
          Thiruvel Thirumoolan

        Issue Links

          Activity

            People

              thiruvel Thiruvel Thirumoolan
              thiruvel Thiruvel Thirumoolan
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: