[HBASE-16929] Move default method of shipped to Shipper interface

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Assignee: Unassigned
• Reporter: Ted Yu
• Created: 21/Oct/16 21:28
• Updated: 17/Jun/22 05:16
• Resolved: 02/Mar/18 03:09

Description

HBASE-16626 added default method of shipped() to RegionScanner.

However, when building master branch of Phoenix against 2.0 SNAPSHOT, I got:

[ERROR] /a/phoenix/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionScanner.java:[27,8] org.apache.phoenix.coprocessor.DelegateRegionScanner is not abstract and does not override  abstract method shipped() in org.apache.hadoop.hbase.regionserver.Shipper
[ERROR] /a/phoenix/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java:[344,36] <anonymous org.apache.phoenix.coprocessor.BaseScannerRegionObserver$1> is not         abstract and does not override abstract method shipped() in org.apache.hadoop.hbase.regionserver.Shipper

Here is the snippet for DelegateRegionScanner:

public class DelegateRegionScanner implements RegionScanner {

It seems adding default method in RegionScanner is not enough for downstream projects.

After moving the default method to Shipper interface, the above two compilation errors are gone in Phoenix.

Issue Links

• supercedes: HBASE-16626 User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part