Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-16893

Use Iterables.removeIf instead of Iterator.remove in HBase filters

    Details

    • Type: Improvement
    • Status: Patch Available
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      This is a performance improvement to use Iterables.removeIf in the filterRowCells method of DependentColumnFilter as described here:

      https://rayokota.wordpress.com/2016/10/20/tips-on-writing-custom-hbase-filters/

      1. HBASE-16893.master.001.patch
        1 kB
        Robert Yokota
      2. HBASE-16893.master.002.patch
        1 kB
        Robert Yokota

        Issue Links

          Activity

          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          For master, can you rewrite using Java 8's support for removeIf() ?

          Show
          yuzhihong@gmail.com Ted Yu added a comment - For master, can you rewrite using Java 8's support for removeIf() ?
          Hide
          rayokota Robert Yokota added a comment -

          Ok, patch with Collection.removeIf is attached.

          Show
          rayokota Robert Yokota added a comment - Ok, patch with Collection.removeIf is attached.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 31s master passed
          +1 compile 0m 16s master passed
          +1 checkstyle 0m 23s master passed
          +1 mvneclipse 0m 9s master passed
          +1 findbugs 0m 48s master passed
          +1 javadoc 0m 16s master passed
          +1 mvninstall 0m 17s the patch passed
          +1 compile 0m 15s the patch passed
          +1 javac 0m 15s the patch passed
          +1 checkstyle 0m 22s the patch passed
          +1 mvneclipse 0m 8s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 hadoopcheck 27m 6s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2.
          +1 findbugs 0m 54s the patch passed
          +1 javadoc 0m 15s the patch passed
          +1 unit 2m 13s hbase-client in the patch passed.
          +1 asflicense 0m 7s The patch does not generate ASF License warnings.
          37m 33s



          Subsystem Report/Notes
          Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:8d52d23
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834532/HBASE-16893.master.002.patch
          JIRA Issue HBASE-16893
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux db417b362205 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 613bcb3
          Default Java 1.8.0_121
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/5905/testReport/
          modules C: hbase-client U: hbase-client
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/5905/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 31s master passed +1 compile 0m 16s master passed +1 checkstyle 0m 23s master passed +1 mvneclipse 0m 9s master passed +1 findbugs 0m 48s master passed +1 javadoc 0m 16s master passed +1 mvninstall 0m 17s the patch passed +1 compile 0m 15s the patch passed +1 javac 0m 15s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvneclipse 0m 8s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 27m 6s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. +1 findbugs 0m 54s the patch passed +1 javadoc 0m 15s the patch passed +1 unit 2m 13s hbase-client in the patch passed. +1 asflicense 0m 7s The patch does not generate ASF License warnings. 37m 33s Subsystem Report/Notes Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:8d52d23 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834532/HBASE-16893.master.002.patch JIRA Issue HBASE-16893 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux db417b362205 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 613bcb3 Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/5905/testReport/ modules C: hbase-client U: hbase-client Console output https://builds.apache.org/job/PreCommit-HBASE-Build/5905/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.

            People

            • Assignee:
              rayokota Robert Yokota
              Reporter:
              rayokota Robert Yokota
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:

                Development