[HBASE-16874] Fix TestMasterFailoverWithProcedures and ensure single proc-executor for kill/restart tests

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.1.8, 2.0.0
• Component/s: proc-v2
• Assignee: Matteo Bertozzi
• Reporter: Ted Yu
• Created: 18/Oct/16 21:05
• Updated: 18/Dec/16 21:03
• Resolved: 19/Oct/16 20:24

Description

When examining failed test :
https://builds.apache.org/job/HBase-TRUNK_matrix/lastCompletedBuild/jdk=JDK%201.8%20(latest),label=yahoo-not-h2/testReport/org.apache.hadoop.hbase.master.procedure/TestMasterFailoverWithProcedures/org_apache_hadoop_hbase_master_procedure_TestMasterFailoverWithProcedures/

I noticed the following:

2016-10-18 18:47:39,313 INFO  [Time-limited test] procedure.TestMasterFailoverWithProcedures(306): Restart 2 exec state: TRUNCATE_TABLE_CLEAR_FS_LAYOUT
Exception in thread "ProcedureExecutorWorker-1" java.lang.NullPointerException
	at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.stop(ProcedureExecutor.java:533)
	at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1197)
	at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:959)
	at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$700(ProcedureExecutor.java:73)
	at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1405)

This seems to be the result of race between stop() and join() methods.