[HBASE-16866] Avoid NPE in AsyncRequestFutureImpl#updateStats

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Chia-Ping Tsai
• Reporter: Chia-Ping Tsai
• Created: 18/Oct/16 01:16
• Updated: 18/Oct/16 23:34
• Resolved: 18/Oct/16 18:11

Description

If region disables the stats, it won’t response any ClientProtos.RegionLoadStats to client. So the NPE will happen in AsyncRequestFutureImpl#updateStats.
We should use relevant log instead of NPE because the data manipulation shouldn’t be broken by statistics.

  protected void updateStats(ServerName server, Map<byte[], MultiResponse.RegionResult> results) {
      …
      ClientProtos.RegionLoadStats stat = regionStats.getValue().getStat();
      RegionLoadStats regionLoadstats = ProtobufUtil.createRegionLoadStats(stat);
      …
  }