[HBASE-16670] Make RpcServer#processRequest logic more robust

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.4.0, 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Yu Li
• Reporter: Yu Li
• Created: 21/Sep/16 20:00
• Updated: 22/Sep/16 17:53
• Resolved: 22/Sep/16 07:47

Description

Currently in RpcServer#processRequest, we will check whether the request header has parameters but missed handling the abnormal case, so if there's no param in the header, it will throw NPE like below:

org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(java.io.IOException): java.io.IOException
	at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2269)
	at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123)
	at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:189)
	at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:169)
Caused by: java.lang.NullPointerException
	at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2211)