[HBASE-16576] Shell add_peer doesn't allow setting cluster_key for custom endpoints

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.5, 0.98.22, 2.0.0
• Fix Version/s: 1.4.0, 0.98.23, 1.3.3, 2.0.0
• Component/s: shell
• Hadoop Flags: Reviewed
• Assignee: Geoffrey Jacoby
• Reporter: Geoffrey Jacoby
• Created: 07/Sep/16 18:37
• Updated: 11/Dec/18 19:49
• Resolved: 09/Sep/16 21:54

Description

The HBase shell allows a user to create a replication peer using the add_peer method, which can take a peer id and a Ruby hash. It creates a ReplicationPeerConfig and passes it through to the Java ReplicationAdmin#addPeer.

The Ruby code makes an assumption that the Java API doesn't: that CLUSTER_KEY and ENDPOINT_CLASSNAME are mutually exclusive. If both are specified, it throws an error. If only ENDPOINT_CLASSNAME is set, the add_peer logic derives a local dummy cluster key based on the local cluster's configuration.

CLUSTER_KEY shouldn't be required when an ENDPOINT_CLASSNAME is specified, because a custom endpoint might not need it. The dummy default logic is fine.

But if an endpoint does require a remote cluster key, it shouldn't be forbidden to provide one, especially since the Java API permits it, and even the custom replication endpoint Java tests rely on this. (See TestReplicationEndpoint#testCustomReplicationEndpoint)