[HBASE-16541] Avoid unnecessary cell copy in Result#compareResults

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0, 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Chia-Ping Tsai
• Reporter: Chia-Ping Tsai
• Created: 01/Sep/16 11:21
• Updated: 04/Sep/16 17:30
• Resolved: 04/Sep/16 14:09

Description

Bar.java

// Bytes.equals(a, b) should be replaced by Bytes.equals(a, off, len, b, off len);
  public static void compareResults(Result res1, Result res2)
      throws Exception {
    ...
    Cell[] ourKVs = res1.rawCells();
    Cell[] replicatedKVs = res2.rawCells();
    for (int i = 0; i < res1.size(); i++) {
      if (!ourKVs[i].equals(replicatedKVs[i]) ||
          !Bytes.equals(CellUtil.cloneValue(ourKVs[i]), CellUtil.cloneValue(replicatedKVs[i]))) {
        throw new Exception("This result was different: "
            + res1.toString() + " compared to " + res2.toString());
      }
    }
  }