[HBASE-16283] Batch Append/Increment will always fail if set ReturnResults to false

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.1.5, 1.2.2, 2.0.0
• Fix Version/s: 2.0.0
• Component/s: API
• Hadoop Flags: Reviewed
• Assignee: Allan Yang
• Reporter: Allan Yang
• Created: 26/Jul/16 02:44
• Updated: 06/Sep/17 08:34
• Resolved: 17/Oct/16 22:42

Description

If set Append/Increment's ReturnResult attribute to false, and batch the appends/increments to server. The batch operation will always return false.
The reason is that, since return result is set to false, append/increment will return null instead of Result object. But in ResponseConverter#getResults, there is some check code

if (requestRegionActionCount != responseRegionActionResultCount) {
      throw new IllegalStateException("Request mutation count=" + requestRegionActionCount +
          " does not match response mutation result count=" + responseRegionActionResultCount);
    }

That means if the result count is not meet with request mutation count, it will fail the request.
The solution is simple, instead of returning a null result, returning a empty result if ReturnResult set to false.

Issue Links

• is duplicated by: HBASE-18755 Set Increment getReturnResults to false will cause batch failed by using BufferedMutator